Client::getSoapClient() - Code Metrics - Inspection of "Bug in documentation" - ddeboer/vatin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#17)

by Roel van

created 2017-01-23 09:18 UTC

Client::getSoapClient() A

↳ Parent: Client

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2.032

Importance

Changes	5
Bugs	0	Features	0

Metric	Value
c	5
b	0
f	0
dl	0
loc	15
ccs	8
cts	10
cp	0.8
rs	9.4285
cc	2
eloc	9
nc	2
nop	0
crap	2.032

<?php

namespace Ddeboer\Vatin\Vies;

use SoapFault;
use Ddeboer\Vatin\Exception\ViesException;

/**
 * A client for the VIES SOAP web service
 */
class Client
{
    /**
     * URL to WSDL
     *
     * @var string
     */
    private $wsdl = 'http://ec.europa.eu/taxation_customs/vies/checkVatService.wsdl';

    /**
     * SOAP client
     *
     * @var \SoapClient
     */
    private $soapClient;

    /**
     * SOAP classmap
     *
     * @var array
     */
    private $classmap = array(
        'checkVatResponse' => 'Ddeboer\Vatin\Vies\Response\CheckVatResponse'
    );

    /**
     * Constructor
     *
     * @param string|null $wsdl URL to WSDL
     */
    public function __construct($wsdl = null)
    {
        if ($wsdl) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->wsdl = $wsdl;
        }
    }

    /**
     * Check VAT
     *
     * @param string $countryCode Country code
     * @param string $vatNumber   VAT number
     *
     * @return Response\CheckVatResponse
     * @throws ViesException
     */
    public function checkVat($countryCode, $vatNumber)
    {
        try {
            return $this->getSoapClient()->checkVat(
                array(
                    'countryCode' => $countryCode,
                    'vatNumber' => $vatNumber
                )
            );
        } catch (SoapFault $e) {
            throw new ViesException('Error communicating with VIES service', 0, $e);
        }
    }

    /**
     * Get SOAP client
     *
     * @return \SoapClient
     */
    private function getSoapClient()
    {
        if (null === $this->soapClient) {
            $this->soapClient = new \SoapClient(
                $this->wsdl,
                array(
                    'classmap' => $this->classmap,
                    'user_agent' => 'Mozilla', // the request fails unless a (dummy) user agent is specified
                    'exceptions' => true,
                )
            );
        }

        return $this->soapClient;
    }
}


1		<?php
2
3		namespace Ddeboer\Vatin\Vies;
4
5		use SoapFault;
6		use Ddeboer\Vatin\Exception\ViesException;
7
8		/**
9		* A client for the VIES SOAP web service
10		*/
11		class Client
12		{
13		/**
14		* URL to WSDL
15		*
16		* @var string
17		*/
18		private $wsdl = 'http://ec.europa.eu/taxation_customs/vies/checkVatService.wsdl';
19
20		/**
21		* SOAP client
22		*
23		* @var \SoapClient
24		*/
25		private $soapClient;
26
27		/**
28		* SOAP classmap
29		*
30		* @var array
31		*/
32		private $classmap = array(
33		'checkVatResponse' => 'Ddeboer\Vatin\Vies\Response\CheckVatResponse'
34		);
35
36		/**
37		* Constructor
38		*
39		* @param string\|null $wsdl URL to WSDL
40		*/
41	2	public function __construct($wsdl = null)
42		{
43	2	if ($wsdl) {
		0 ignored issues – show Bug Best Practice introduced 2017-01-21 08:25 UTC by Report Bug Copy Issue Report The expression `$wsdl` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
44	1	$this->wsdl = $wsdl;
45	1	}
46	2	}
47
48		/**
49		* Check VAT
50		*
51		* @param string $countryCode Country code
52		* @param string $vatNumber VAT number
53		*
54		* @return Response\CheckVatResponse
55		* @throws ViesException
56		*/
57	2	public function checkVat($countryCode, $vatNumber)
58		{
59		try {
60	2	return $this->getSoapClient()->checkVat(
61		array(
62		'countryCode' => $countryCode,
63		'vatNumber' => $vatNumber
64		)
65		);
66	2	} catch (SoapFault $e) {
67	2	throw new ViesException('Error communicating with VIES service', 0, $e);
68		}
69		}
70
71		/**
72		* Get SOAP client
73		*
74		* @return \SoapClient
75		*/
76	2	private function getSoapClient()
77		{
78	2	if (null === $this->soapClient) {
79	2	$this->soapClient = new \SoapClient(
80	2	$this->wsdl,
81		array(
82	2	'classmap' => $this->classmap,
83	2	'user_agent' => 'Mozilla', // the request fails unless a (dummy) user agent is specified
84	2	'exceptions' => true,
85		)
86	2	);
87		}
88
89		return $this->soapClient;
90		}
91		}
92

ddeboer / vatin

Pull Request — master (#17)

Client::getSoapClient() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like