StepAggregator::process() - Code Metrics - Inspection of "BUGFIX: the column-name does not fit to the result..." - ddeboer/data-import - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#296)

unknown

created 2016-06-07 09:36 UTC

StepAggregator::process() C

↳ Parent: StepAggregator

Complexity

Conditions	15
Paths	96

Size

Total Lines	58
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	36
CRAP Score	15.0044

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	58
ccs	36
cts	37
cp	0.973
rs	6.4661
cc	15
eloc	31
nc	96
nop	0
crap	15.0044

How to fix Long Method Complexity

<?php

namespace Ddeboer\DataImport\Workflow;

use Ddeboer\DataImport\Exception;
use Ddeboer\DataImport\Exception\UnexpectedTypeException;
use Ddeboer\DataImport\Reader;
use Ddeboer\DataImport\Result;
use Ddeboer\DataImport\Step;
use Ddeboer\DataImport\Step\PriorityStep;
use Ddeboer\DataImport\Workflow;
use Ddeboer\DataImport\Writer;
use Psr\Log\LoggerInterface;
use Psr\Log\LoggerAwareInterface;
use Psr\Log\LoggerAwareTrait;
use Psr\Log\NullLogger;

/**
 * A mediator between a reader and one or more writers and converters
 *
 * @author David de Boer <[email protected]>
 */
class StepAggregator implements Workflow, LoggerAwareInterface
{
    use LoggerAwareTrait;

    /**
     * @var Reader
     */
    private $reader;

    /**
     * Identifier for the Import/Export
     *
     * @var string|null
     */
    private $name = null;

    /**
     * @var boolean
     */
    private $skipItemOnFailure = false;

    /**
     * @var \SplPriorityQueue
     */
    private $steps;

    /**
     * @var Writer[]
     */
    private $writers = [];

    /**
     * @var boolean
     */
    protected $shouldStop = false;

    /**
     * @param Reader $reader
     * @param string $name
     */
    public function __construct(Reader $reader, $name = null)
    {
        $this->name = $name;
        $this->reader = $reader;

        // Defaults
        $this->logger = new NullLogger();
        $this->steps = new \SplPriorityQueue();
    }

    /**
     * Add a step to the current workflow
     *
     * @param Step         $step
     * @param integer|null $priority
     *
     * @return $this
     */
    public function addStep(Step $step, $priority = null)
    {
        $priority = null === $priority && $step instanceof PriorityStep ? $step->getPriority() : null;
        $priority = null === $priority ? 0 : $priority;

        $this->steps->insert($step, $priority);

        return $this;
    }

    /**
     * Add a new writer to the current workflow
     *
     * @param Writer $writer
     *
     * @return $this
     */
    public function addWriter(Writer $writer)
    {
        array_push($this->writers, $writer);

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function process()
    {
        $count      = 0;
        $exceptions = new \SplObjectStorage();
        $startTime  = new \DateTime;

        foreach ($this->writers as $writer) {
            $writer->prepare();
        }

        if (is_callable('pcntl_signal')) {
            pcntl_signal(SIGTERM, array($this, 'stop'));
            pcntl_signal(SIGINT, array($this, 'stop'));
        }

        // Read all items
        foreach ($this->reader as $index => $item) {

            if (is_callable('pcntl_signal_dispatch')) {
                pcntl_signal_dispatch();
            }

            if ($this->shouldStop) {
                break;
            }

            try {
                foreach (clone $this->steps as $step) {
                    if (false === $step->process($item)) {
                        continue 2;
                    }
                }

                if (!is_array($item) && !($item instanceof \ArrayAccess && $item instanceof \Traversable)) {
                    throw new UnexpectedTypeException($item, 'array');
                }

                foreach ($this->writers as $writer) {
                    $writer->writeItem($item);
                }
            } catch(Exception $e) {
                if (!$this->skipItemOnFailure) {
                    throw $e;
                }

                $exceptions->attach($e, $index);
                $this->logger->error($e->getMessage());
            }

            $count++;
        }

        foreach ($this->writers as $writer) {
            $writer->finish();
        }

        return new Result($this->name, $startTime, new \DateTime, $count, $exceptions);
    }

    /**
     * Stops processing and force return Result from process() function
     */
    public function stop()
    {
        $this->shouldStop = true;
    }

    /**
     * Sets the value which determines whether the item should be skipped when error occures
     *
     * @param boolean $skipItemOnFailure When true skip current item on process exception and log the error
     *
     * @return $this
     */
    public function setSkipItemOnFailure($skipItemOnFailure)
    {
        $this->skipItemOnFailure = $skipItemOnFailure;

        return $this;
    }

    /**
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }
}


1		<?php
2
3		namespace Ddeboer\DataImport\Workflow;
4
5		use Ddeboer\DataImport\Exception;
6		use Ddeboer\DataImport\Exception\UnexpectedTypeException;
7		use Ddeboer\DataImport\Reader;
8		use Ddeboer\DataImport\Result;
9		use Ddeboer\DataImport\Step;
10		use Ddeboer\DataImport\Step\PriorityStep;
11		use Ddeboer\DataImport\Workflow;
12		use Ddeboer\DataImport\Writer;
13		use Psr\Log\LoggerInterface;
14		use Psr\Log\LoggerAwareInterface;
15		use Psr\Log\LoggerAwareTrait;
16		use Psr\Log\NullLogger;
17
18		/**
19		* A mediator between a reader and one or more writers and converters
20		*
21		* @author David de Boer <[email protected]>
22		*/
23		class StepAggregator implements Workflow, LoggerAwareInterface
24		{
25		use LoggerAwareTrait;
26
27		/**
28		* @var Reader
29		*/
30		private $reader;
31
32		/**
33		* Identifier for the Import/Export
34		*
35		* @var string\|null
36		*/
37		private $name = null;
38
39		/**
40		* @var boolean
41		*/
42		private $skipItemOnFailure = false;
43
44		/**
45		* @var \SplPriorityQueue
46		*/
47		private $steps;
48
49		/**
50		* @var Writer[]
51		*/
52		private $writers = [];
53
54		/**
55		* @var boolean
56		*/
57		protected $shouldStop = false;
58
59		/**
60		* @param Reader $reader
61		* @param string $name
62		*/
63	13	public function __construct(Reader $reader, $name = null)
64		{
65	13	$this->name = $name;
66	13	$this->reader = $reader;
67
68		// Defaults
69	13	$this->logger = new NullLogger();
70	13	$this->steps = new \SplPriorityQueue();
71	13	}
72
73		/**
74		* Add a step to the current workflow
75		*
76		* @param Step $step
77		* @param integer\|null $priority
78		*
79		* @return $this
80		*/
81	6	public function addStep(Step $step, $priority = null)
82		{
83	6	$priority = null === $priority && $step instanceof PriorityStep ? $step->getPriority() : null;
84	6	$priority = null === $priority ? 0 : $priority;
85
86	6	$this->steps->insert($step, $priority);
87
88	6	return $this;
89		}
90
91		/**
92		* Add a new writer to the current workflow
93		*
94		* @param Writer $writer
95		*
96		* @return $this
97		*/
98	9	public function addWriter(Writer $writer)
99		{
100	9	array_push($this->writers, $writer);
101
102	9	return $this;
103		}
104
105		/**
106		* {@inheritdoc}
107		*/
108	11	public function process()
109		{
110	11	$count = 0;
111	11	$exceptions = new \SplObjectStorage();
112	11	$startTime = new \DateTime;
113
114	11	foreach ($this->writers as $writer) {
115	8	$writer->prepare();
116	11	}
117
118	11	if (is_callable('pcntl_signal')) {
119	11	pcntl_signal(SIGTERM, array($this, 'stop'));
120	11	pcntl_signal(SIGINT, array($this, 'stop'));
121	11	}
122
123		// Read all items
124	11	foreach ($this->reader as $index => $item) {
125
126	11	if (is_callable('pcntl_signal_dispatch')) {
127	11	pcntl_signal_dispatch();
128	11	}
129
130	11	if ($this->shouldStop) {
131		break;
132		}
133
134		try {
135	11	foreach (clone $this->steps as $step) {
136	5	if (false === $step->process($item)) {
137	2	continue 2;
138		}
139	9	}
140
141	9	if (!is_array($item) && !($item instanceof \ArrayAccess && $item instanceof \Traversable)) {
142	2	throw new UnexpectedTypeException($item, 'array');
143		}
144
145	7	foreach ($this->writers as $writer) {
146	6	$writer->writeItem($item);
147	6	}
148	9	} catch(Exception $e) {
149	3	if (!$this->skipItemOnFailure) {
150	2	throw $e;
151		}
152
153	1	$exceptions->attach($e, $index);
154	1	$this->logger->error($e->getMessage());
155		}
156
157	7	$count++;
158	9	}
159
160	9	foreach ($this->writers as $writer) {
161	6	$writer->finish();
162	9	}
163
164	9	return new Result($this->name, $startTime, new \DateTime, $count, $exceptions);
165		}
166
167		/**
168		* Stops processing and force return Result from process() function
169		*/
170		public function stop()
171		{
172		$this->shouldStop = true;
173		}
174
175		/**
176		* Sets the value which determines whether the item should be skipped when error occures
177		*
178		* @param boolean $skipItemOnFailure When true skip current item on process exception and log the error
179		*
180		* @return $this
181		*/
182	1	public function setSkipItemOnFailure($skipItemOnFailure)
183		{
184	1	$this->skipItemOnFailure = $skipItemOnFailure;
185
186	1	return $this;
187		}
188
189		/**
190		* @return string
191		*/
192		public function getName()
193		{
194		return $this->name;
195		}
196		}
197

ddeboer / data-import

Pull Request — master (#296)

StepAggregator::process() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like