dcngmbh / moox_core

Classes/Hooks/PageRendererRender/PreProcessHook.php

<?php
namespace DCNGmbH\MooxCore\Hooks\PageRendererRender;

/***************************************************************
 *
 *  The MIT License (MIT)
 *
 *  Copyright (c) 2014 Benjamin Kott, http://www.bk2k.info
 *
 *  Permission is hereby granted, free of charge, to any person obtaining a copy
 *  of this software and associated documentation files (the "Software"), to deal
 *  in the Software without restriction, including without limitation the rights
 *  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 *  copies of the Software, and to permit persons to whom the Software is
 *  furnished to do so, subject to the following conditions:
 *
 *  The above copyright notice and this permission notice shall be included in
 *  all copies or substantial portions of the Software.
 *
 *  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 *  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 *  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 *  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 *  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 *  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 *  THE SOFTWARE.
 *
 ***************************************************************/

use DCNGmbH\MooxCore\Service\CompileService;

/**
 * @author Benjamin Kott <info@bk2k.info>
 */
class PreProcessHook {

	/**
	 * @param array $params
	 * @param \TYPO3\CMS\Core\Page\PageRenderer $pagerenderer
	 */
	public function execute(&$params, &$pagerenderer) {

The parameter $pagerenderer is not used and could be removed.

		if (TYPO3_MODE !== 'FE' || !is_array($params['cssFiles'])) {
			return;
		}
		$files = array();
		foreach ($params['cssFiles'] as $file => $settings) {
			$compiledFile = CompileService::getCompiledFile($file);
			if ($compiledFile) {

The expression $compiledFile of type string|false is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== false instead.

				$settings['file'] = $compiledFile;
				$files[$compiledFile] = $settings;
			} else {
				$files[$file] = $settings;
			}
		}
		$params['cssFiles'] = $files;
	}

}