dbunt1tled / php-value-objects

src/VObjects/Person/NameExtended.php

<?php

declare(strict_types=1);

namespace DBUnt1tled\VO\VObjects\Person;

use DBUnt1tled\VO\Exception\InvalidVOArgumentException;
use DBUnt1tled\VO\VObjects\Scalar\Strings;
use DBUnt1tled\VO\VObjects\ValueObjectInterface;

class NameExtended extends Name
{
    /** @var Strings */
    private $middleName;

    /**
     * NameExtended constructor.
     * @param Strings $firstName
     * @param Strings $middleName
     * @param Strings $lastName
     * @throws \ReflectionException
     */
    public function __construct(Strings $firstName, Strings $middleName, Strings $lastName)
    {
        parent::__construct($firstName, $lastName);
        $this->guardExtended($middleName);
        $this->middleName = $middleName;

$middleName is of type DBUnt1tled\VO\VObjects\ValueObjectInterface, but the property $middleName was declared to be of type DBUnt1tled\VO\VObjects\Scalar\Strings. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }

    /**
     * @param $value
     * @param mixed ...$other
     */
    public function guardExtended($value, ...$other): void

The parameter $other is not used and could be removed.

    {
        /** @var ValueObjectInterface $value*/
        if (mb_strlen($value->getValue()) < self::NAME_MIN_LENGTH) {
            throw new InvalidVOArgumentException(sprintf('Middle name must contain a minimum of %s symbols.', self::NAME_MIN_LENGTH), $value);
        }
    }

    /**
     * @param string $firstName
     * @param string $middleName
     * @param string $lastName
     * @return NameExtended
     * @throws \ReflectionException
     */
    public static function createFromString(string $firstName, string $middleName, string $lastName = ''): self
    {
        return new static(new Strings($firstName), new Strings($middleName), new Strings($lastName));
    }

    /**
     * @return string
     */
    public function getMiddleName(): string
    {
        return $this->middleName->getValue();
    }

    /**
     * @return string
     */
    public function getFullName(): string
    {
        return $this->getFirstName().' '.$this->getMiddleName().' '.$this->getLastName();
    }
}