BillMe::createOrder() - Code Metrics - Inspection of "code optimizations and query improval" - dbrax/bill-me - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — main ( 5c14c4...efbfd7 )

by Emmanuel

created 2021-02-07 15:11 UTC

BillMe::createOrder() A

↳ Parent: BillMe

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	46
rs	9.1781
c	0
b	0
f	0
cc	3
nc	4
nop	9

How to fix Many Parameters

<?php

/**
 * Author: Emmanuel Paul Mnzava
 * Twitter: @epmnzava
 * Github: https://github.com/dbrax/bill-me
 * Email: [email protected]
 * 
 */

namespace Epmnzava\BillMe;

use Epmnzava\BillMe\Models\Order;
use Epmnzava\BillMe\Models\Invoice;
use Epmnzava\BillMe\Models\OrderItem;
use Epmnzava\BillMe\Mail\Client\Invoices\InvoiceCreated;
use Epmnzava\BillMe\Mail\Client\OrderReceived;
use Epmnzava\BillMe\Mail\Merchant\NewOrder;
use Carbon\Carbon;

use Mail;

class BillMe extends Queries
{



    /** A function that triggers order creation */
    public function createOrder(
        string $firstname,
        string $lastname,
        string $email,
        string $mobile_number,
        int $amount,
        string $payment_method,
        string $notes,
        string $address,
        array $orderitems
    ) {

        $order = new Order;
        $order->firstname = $firstname;
        $order->lastname = $lastname;
        $order->email = $email;
        $order->mobile_number = $mobile_number;
        $order->amount = $amount;
        $order->payment_method = $payment_method;
        $order->status = "pending";
        $order->notes = $notes;
        $order->address = $address;
        $order->date = date("Y-m-d");

        $order->save();

        // order items ... here

        if (!empty($orderitems)) {
            /* $orderItem=new OrderItem();
          $orderItem->order_id=$order->id;
          $orderItem->amount=$orderitems->amount;
          $orderItem->quantity=$orderitems->quantity;


          */
        }

        //perform checks if the user needs email service use a separate function here add bulk sms functionality ...


        $this->createInvoice($order);

        if (config('bill-me.send_mail') == 1)
            $this->sendMailNotifications($order);
    }


    public function sendMailNotifications(Order $order)
    {
        Mail::to(["email" => $order->email, "name" => $order->email])->send(new OrderReceived($order));
        Mail::to(["email" => $order->email, "name" => $order->email])->send(new NewOrder($order));
    }




    public function createInvoice(Order $order)
    {

        $invoice = new Invoice;
        $invoice->orderid = $order->id;
        $invoice->firstname = $order->firstname;
        $invoice->lastname = $order->lastname;
        $invoice->mobile_number = $order->mobile_number;
        $invoice->email = $order->email;
        $invoice->amount = $order->amount;
        $invoice->status = $order->status;
        $invoice->address = $order->address;
        $invoice->date = date('Y-m-d');
        $invoice->save();

        if (config('bill-me.send_mail'))
            Mail::to(["address" => $invoice->email, "name" => $invoice->email])->send(new InvoiceCreated($invoice));




        $order_update = Order::find($order->id);
        $order_update->invoiceid = $invoice->id;
        $order_update->save();
    }


    /**
     * Function that gets you invoice details by using orderid
     */

    public function getInvoiceByOrderId($orderid)
    {
        return Invoice::where('orderid', $orderid)->first();
    }

    /**
     * Function that gets you invoice details by using invoiceid
     */

    public function getInvoiceByInvoiceId($invoiceid)
    {

        return Invoice::find($invoiceid);
    }



    /**
     * Function that gets you order details by using orderid
     */

    public function getOrderByOrderId($orderid)
    {
        return Order::find($orderid);
    }

    /**
     * Function that gets you order details by using invoiceid
     */

    public function getOrderByInvoiceId($invoiceid)
    {
        return Order::find(Invoice::where('id', $invoiceid)->first()->orderid);
    }


    /**
     * Function that updates invoice status and returns void
     */
    public function update_invoice_status(string $invoiceid, string $status): void
    {
        $invoice = Invoice::find($invoiceid);
        $invoice->status = $status;
        $invoice->save();
    }


    public function update_invoice(string $invoiceid, Invoice $invoice): void

    {
    }




    /**
     * Function that updates order status and returns void
     */
    public function update_order_status(string $orderid, string $status): void
    {
        $order = Order::find($orderid);
        $order->status = $status;
        $order->save();
    }



    public function update_order(string $order_id, Order $order): void

    {
    }

    public function cancel_order(string $orderid): void
    {
        $order = Order::find($orderid);
        $order->status = "cancelled";
        $order->save();
    }

    public function delete_order(string $orderid)
    {

        $order = Order::find($orderid);
        $order->delete();
        $this->delete_invoice($orderid);
    }

    public function delete_invoice(string $orderid): void
    {

        $invoice = Invoice::where('orderid', $orderid)->delete();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }
}


1			<?php
2
3			/**
4			* Author: Emmanuel Paul Mnzava
5			* Twitter: @epmnzava
6			* Github: https://github.com/dbrax/bill-me
7			* Email: [email protected]
8			*
9			*/
10
11			namespace Epmnzava\BillMe;
12
13			use Epmnzava\BillMe\Models\Order;
14			use Epmnzava\BillMe\Models\Invoice;
15			use Epmnzava\BillMe\Models\OrderItem;
16			use Epmnzava\BillMe\Mail\Client\Invoices\InvoiceCreated;
17			use Epmnzava\BillMe\Mail\Client\OrderReceived;
18			use Epmnzava\BillMe\Mail\Merchant\NewOrder;
19			use Carbon\Carbon;
20
21			use Mail;
22
23			class BillMe extends Queries
24			{
25
26
27
28			/** A function that triggers order creation */
29			public function createOrder(
30			string $firstname,
31			string $lastname,
32			string $email,
33			string $mobile_number,
34			int $amount,
35			string $payment_method,
36			string $notes,
37			string $address,
38			array $orderitems
39			) {
40
41			$order = new Order;
42			$order->firstname = $firstname;
43			$order->lastname = $lastname;
44			$order->email = $email;
45			$order->mobile_number = $mobile_number;
46			$order->amount = $amount;
47			$order->payment_method = $payment_method;
48			$order->status = "pending";
49			$order->notes = $notes;
50			$order->address = $address;
51			$order->date = date("Y-m-d");
52
53			$order->save();
54
55			// order items ... here
56
57			if (!empty($orderitems)) {
58			/* $orderItem=new OrderItem();
59			$orderItem->order_id=$order->id;
60			$orderItem->amount=$orderitems->amount;
61			$orderItem->quantity=$orderitems->quantity;
62
63
64			*/
65			}
66
67			//perform checks if the user needs email service use a separate function here add bulk sms functionality ...
68
69
70			$this->createInvoice($order);
71
72			if (config('bill-me.send_mail') == 1)
73			$this->sendMailNotifications($order);
74			}
75
76
77			public function sendMailNotifications(Order $order)
78			{
79			Mail::to(["email" => $order->email, "name" => $order->email])->send(new OrderReceived($order));
80			Mail::to(["email" => $order->email, "name" => $order->email])->send(new NewOrder($order));
81			}
82
83
84
85
86			public function createInvoice(Order $order)
87			{
88
89			$invoice = new Invoice;
90			$invoice->orderid = $order->id;
91			$invoice->firstname = $order->firstname;
92			$invoice->lastname = $order->lastname;
93			$invoice->mobile_number = $order->mobile_number;
94			$invoice->email = $order->email;
95			$invoice->amount = $order->amount;
96			$invoice->status = $order->status;
97			$invoice->address = $order->address;
98			$invoice->date = date('Y-m-d');
99			$invoice->save();
100
101			if (config('bill-me.send_mail'))
102			Mail::to(["address" => $invoice->email, "name" => $invoice->email])->send(new InvoiceCreated($invoice));
103
104
105
106
107			$order_update = Order::find($order->id);
108			$order_update->invoiceid = $invoice->id;
109			$order_update->save();
110			}
111
112
113			/**
114			* Function that gets you invoice details by using orderid
115			*/
116
117			public function getInvoiceByOrderId($orderid)
118			{
119			return Invoice::where('orderid', $orderid)->first();
120			}
121
122			/**
123			* Function that gets you invoice details by using invoiceid
124			*/
125
126			public function getInvoiceByInvoiceId($invoiceid)
127			{
128
129			return Invoice::find($invoiceid);
130			}
131
132
133
134			/**
135			* Function that gets you order details by using orderid
136			*/
137
138			public function getOrderByOrderId($orderid)
139			{
140			return Order::find($orderid);
141			}
142
143			/**
144			* Function that gets you order details by using invoiceid
145			*/
146
147			public function getOrderByInvoiceId($invoiceid)
148			{
149			return Order::find(Invoice::where('id', $invoiceid)->first()->orderid);
150			}
151
152
153			/**
154			* Function that updates invoice status and returns void
155			*/
156			public function update_invoice_status(string $invoiceid, string $status): void
157			{
158			$invoice = Invoice::find($invoiceid);
159			$invoice->status = $status;
160			$invoice->save();
161			}
162
163
164			public function update_invoice(string $invoiceid, Invoice $invoice): void
			0 ignored issues – show Unused Code introduced 2021-02-07 07:12 UTC by Report Bug Copy Issue Report The parameter `$invoiceid` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2021-02-07 07:12 UTC by Report Bug Copy Issue Report The parameter `$invoice` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
165			{
166			}
167
168
169
170
171			/**
172			* Function that updates order status and returns void
173			*/
174			public function update_order_status(string $orderid, string $status): void
175			{
176			$order = Order::find($orderid);
177			$order->status = $status;
178			$order->save();
179			}
180
181
182
183			public function update_order(string $order_id, Order $order): void
			0 ignored issues – show Unused Code introduced 2021-02-07 07:12 UTC by Report Bug Copy Issue Report The parameter `$order_id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2021-02-07 07:12 UTC by Report Bug Copy Issue Report The parameter `$order` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
184			{
185			}
186
187			public function cancel_order(string $orderid): void
188			{
189			$order = Order::find($orderid);
190			$order->status = "cancelled";
191			$order->save();
192			}
193
194			public function delete_order(string $orderid)
195			{
196
197			$order = Order::find($orderid);
198			$order->delete();
199			$this->delete_invoice($orderid);
200			}
201
202			public function delete_invoice(string $orderid): void
203			{
204
205			$invoice = Invoice::where('orderid', $orderid)->delete();
			0 ignored issues – show Unused Code introduced 2021-02-07 07:19 UTC by Report Bug Copy Issue Report `$invoice` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
206			}
207			}
208

dbrax / bill-me

Push — main ( 5c14c4...efbfd7 )

BillMe::createOrder() A

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like