Dazzle\Util\System\SystemUnix

Complexity

Total Complexity

6

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	__destruct()	0	4	1
A	run()	0	13	2
A	kill()	0	6	1
A	existsPid()	0	6	1

<?php

namespace Dazzle\Util\System;

use Dazzle\Util\Isolate\IsolateInterface;

class SystemUnix implements SystemInterface
{
    /**
     * @var IsolateInterface|null
     */
    protected $isolator;

    /**
     * @param IsolateInterface|null $isolator
     */
    public function __construct(IsolateInterface $isolator = null)
    {
        $this->isolator = $isolator;
    }

    /**
     *
     */
    public function __destruct()
    {
        unset($this->isolator);
    }

    /**
     * @override
     * @inheritDoc
     */
    public function run($command)
    {
        $command = $command . '>/dev/null 2>&1 & echo $!';

        if ($this->isolator !== null)
        {
            return $this->isolator->call('exec', [ $command ]);
        }
        else
        {
            return exec($command);
        }
    }

    /**
     * @override
     * @inheritDoc
     */
    public function kill($pid)
    {
        exec('kill -9 ' . $pid . ' >/dev/null 2>&1', $output, $result);

        return $result == 0;

It seems like you are loosely comparing $result of type integer|null to 0; this is ambiguous as not only 0 == 0 is true, but null == 0 is true, too. Consider using a strict comparison ===.

    }

    /**
     * @override
     * @inheritDoc
     */
    public function existsPid($pid)
    {
        exec('kill -0 ' . $pid . ' >/dev/null 2>&1', $output, $result);

        return $result == 0;

It seems like you are loosely comparing $result of type integer|null to 0; this is ambiguous as not only 0 == 0 is true, but null == 0 is true, too. Consider using a strict comparison ===.

    }
}