Issues in Throwable.php (master) - Issues in master - dazzle-php/throwable - Measure and Improve Code Quality continuously with Scrutinizer

Issues (45)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Throwable/Throwable.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Dazzle\Throwable;

abstract class Throwable
{
    /**
     * Parse Throwable message to proper format.
     *
     * @param string[] $ex
     * @return string
     */
    public static function parseThrowableMessage($ex)
    {
        $message = $ex['message'];

        if ($ex['isError'] && strpos($message, ' in ') !== false)
        {
            $message = preg_replace('#([a-zA-Z0-9-_]+?)/#siU', '', $message);
            $message = preg_replace('#/#si', '', $message, 1);
        }
        else
        {
            $message = trim($message, '"');
            $file = str_replace('.php', '', basename($ex['file']));
            $line = $ex['line'];
            $message = '"' . $message . '" in ' . $file . ':' . $line;
        }

        return '[' . static::getBasename($ex['class']) . '] ' . $message;
    }

    /**
     * Return throwable stack in recursive array format.
     *
     * @param \Error|\Exception $ex
     * @param string[] &$data
     * @param int $offset
     * @return mixed
     */
    public static function getThrowableStack($ex, &$data = [], $offset = 0)
    {
        $data = static::getThrowableData($ex, $offset);

        if (($current = $ex->getPrevious()) !== null)
        {
            static::getThrowableStack($current, $data['prev'], count(static::getTraceElements($ex)));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return $data;
    }

    /**
     * Return throwable data in array format.
     *
     * @param \Error|\Exception $ex
     * @param int $offset
     * @return string[]
     */
    public static function getThrowableData($ex, $offset = 0)
    {
        return [
            'message'   => $ex->getMessage(),
            'class'     => get_class($ex),
            'file'      => $ex->getFile(),
            'line'      => $ex->getLine(),
            'code'      => $ex->getCode(),
            'trace'     => static::getTraceElements($ex, $offset),
            'isError'   => $ex instanceof \Error,
if ($x instanceof DoesNotExist) {
    // Do something.
}
            'prev'      => null
        ];
    }

    /**
     * @param \Error|\Exception $ex
     * @param int $offset
     * @return string[]
     */
    protected static function getTraceElements($ex, $offset = 0)
    {
        $trace = $ex->getTrace();
        $file  = str_replace('.php', '', basename($ex->getFile()));
        $elements = [
            '[throwable] ' . get_class($ex) . '(...) in ' . $file .':' . $ex->getLine()
        ];

        foreach ($trace as $currentTrack)
        {
            $elements[] = static::parseTraceElement($currentTrack);
        }
        $elements[] = '[main]';

        array_splice($elements, -$offset+1, $offset);

        return $elements;
    }

    /**
     * @param mixed[] $element
     * @return string
     */
    protected static function parseTraceElement($element)
    {
        $element['class']    = isset($element['class'])    ? $element['class']    : 'Undefined';
        $element['file']     = isset($element['file'])     ? $element['file']     : 'unknown';
        $element['line']     = isset($element['line'])     ? $element['line']     : 0;
        $element['type']     = isset($element['type'])     ? $element['type']     : '';
        $element['function'] = isset($element['function']) ? $element['function'] : '::undefined';
        $element['args']     = isset($element['args'])     ? $element['args']     : [];

        return implode('', [
            '[call] ',
            $element['class'],
            $element['type'],
            $element['function'],
            '(',
            static::parseArgs($element['args']),
            ') in ',
            str_replace('.php', '', basename($element['file'])),
            ':',
            $element['line']
        ]);
    }

    /**
     * @param mixed[] $args
     * @return string
     */
    protected static function parseArgs($args)
    {
        $elements = [];

        foreach ($args as $element)
        {
            if (is_array($element))
            {
                $element = 'Array';
            }
            else if (is_object($element))
            {
                $element = get_class($element);
            }
            else if (is_string($element))
            {
                $element = (strlen($element) > 32) ? substr($element, 0, 32) . '...' : $element;
                $element = '"' . $element . '"';
            }

            $elements[] = $element;
        }

        return implode(', ', $elements);
    }

    /**
     * @param string $class
     * @return string
     */
    protected static function getBasename($class)
    {
        $tmp = explode('\\', $class);
        $className = end($tmp);

        return $className;
    }
}


1		<?php
2
3		namespace Dazzle\Throwable;
4
5		abstract class Throwable
6		{
7		/**
8		* Parse Throwable message to proper format.
9		*
10		* @param string[] $ex
11		* @return string
12		*/
13	11	public static function parseThrowableMessage($ex)
14		{
15	11	$message = $ex['message'];
16
17	11	if ($ex['isError'] && strpos($message, ' in ') !== false)
18		{
19		$message = preg_replace('#([a-zA-Z0-9-_]+?)/#siU', '', $message);
20		$message = preg_replace('#/#si', '', $message, 1);
21		}
22		else
23		{
24	11	$message = trim($message, '"');
25	11	$file = str_replace('.php', '', basename($ex['file']));
26	11	$line = $ex['line'];
27	11	$message = '"' . $message . '" in ' . $file . ':' . $line;
28		}
29
30	11	return '[' . static::getBasename($ex['class']) . '] ' . $message;
31		}
32
33		/**
34		* Return throwable stack in recursive array format.
35		*
36		* @param \Error\|\Exception $ex
37		* @param string[] &$data
38		* @param int $offset
39		* @return mixed
40		*/
41	19	public static function getThrowableStack($ex, &$data = [], $offset = 0)
42		{
43	19	$data = static::getThrowableData($ex, $offset);
44
45	19	if (($current = $ex->getPrevious()) !== null)
46		{
47	19	static::getThrowableStack($current, $data['prev'], count(static::getTraceElements($ex)));
		0 ignored issues – show Documentation introduced 2017-06-17 21:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$data['prev']` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
48		}
49
50	19	return $data;
51		}
52
53		/**
54		* Return throwable data in array format.
55		*
56		* @param \Error\|\Exception $ex
57		* @param int $offset
58		* @return string[]
59		*/
60	21	public static function getThrowableData($ex, $offset = 0)
61		{
62		return [
63	21	'message' => $ex->getMessage(),
64	21	'class' => get_class($ex),
65	21	'file' => $ex->getFile(),
66	21	'line' => $ex->getLine(),
67	21	'code' => $ex->getCode(),
68	21	'trace' => static::getTraceElements($ex, $offset),
69	21	'isError' => $ex instanceof \Error,
		0 ignored issues – show Bug introduced 2017-06-17 21:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `Error` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
70		'prev' => null
71		];
72		}
73
74		/**
75		* @param \Error\|\Exception $ex
76		* @param int $offset
77		* @return string[]
78		*/
79	23	protected static function getTraceElements($ex, $offset = 0)
80		{
81	23	$trace = $ex->getTrace();
82	23	$file = str_replace('.php', '', basename($ex->getFile()));
83		$elements = [
84	23	'[throwable] ' . get_class($ex) . '(...) in ' . $file .':' . $ex->getLine()
85		];
86
87	23	foreach ($trace as $currentTrack)
88		{
89	23	$elements[] = static::parseTraceElement($currentTrack);
90		}
91	23	$elements[] = '[main]';
92
93	23	array_splice($elements, -$offset+1, $offset);
94
95	23	return $elements;
96		}
97
98		/**
99		* @param mixed[] $element
100		* @return string
101		*/
102	25	protected static function parseTraceElement($element)
103		{
104	25	$element['class'] = isset($element['class']) ? $element['class'] : 'Undefined';
105	25	$element['file'] = isset($element['file']) ? $element['file'] : 'unknown';
106	25	$element['line'] = isset($element['line']) ? $element['line'] : 0;
107	25	$element['type'] = isset($element['type']) ? $element['type'] : '';
108	25	$element['function'] = isset($element['function']) ? $element['function'] : '::undefined';
109	25	$element['args'] = isset($element['args']) ? $element['args'] : [];
110
111	25	return implode('', [
112	25	'[call] ',
113	25	$element['class'],
114	25	$element['type'],
115	25	$element['function'],
116	25	'(',
117	25	static::parseArgs($element['args']),
118	25	') in ',
119	25	str_replace('.php', '', basename($element['file'])),
120	25	':',
121	25	$element['line']
122		]);
123		}
124
125		/**
126		* @param mixed[] $args
127		* @return string
128		*/
129	26	protected static function parseArgs($args)
130		{
131	26	$elements = [];
132
133	26	foreach ($args as $element)
134		{
135	25	if (is_array($element))
136		{
137	25	$element = 'Array';
138		}
139	25	else if (is_object($element))
140		{
141	24	$element = get_class($element);
142		}
143	25	else if (is_string($element))
144		{
145	24	$element = (strlen($element) > 32) ? substr($element, 0, 32) . '...' : $element;
146	24	$element = '"' . $element . '"';
147		}
148
149	25	$elements[] = $element;
150		}
151
152	26	return implode(', ', $elements);
153		}
154
155		/**
156		* @param string $class
157		* @return string
158		*/
159	13	protected static function getBasename($class)
160		{
161	13	$tmp = explode('\\', $class);
162	13	$className = end($tmp);
163
164	13	return $className;
165		}
166		}
167

dazzle-php / throwable

Issues (45)

Security Analysis no request data

src/Throwable/Throwable.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like