Dazzle\Stream\Sync\StreamReader

Complexity

Total Complexity

13

Size/Duplication

Total Lines	122
Duplicated Lines	40.16 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

88.1%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	__destruct()	0	7	1
A	isReadable()	0	4	1
A	setBufferSize()	0	4	1
A	getBufferSize()	0	4	1
B	read()	34	34	6
A	close()	15	15	2

<?php

namespace Dazzle\Stream\Sync;

use Dazzle\Stream\StreamSeeker;
use Dazzle\Throwable\Exception\Runtime\ReadException;
use Dazzle\Throwable\Exception\Logic\InvalidArgumentException;

class StreamReader extends StreamSeeker implements StreamReaderInterface
{
    /**
     * @var bool
     */
    protected $readable;

    /**
     * @var int
     */
    protected $bufferSize;

    /**
     * @param resource $resource
     * @param bool $autoClose
     * @throws InvalidArgumentException
     */
    public function __construct($resource, $autoClose = true)
    {
        parent::__construct($resource, $autoClose);

        $this->readable = true;
        $this->bufferSize = 4096;
    }

    /**
     *
     */
    public function __destruct()
    {
        unset($this->readable);
        unset($this->bufferSize);

        parent::__destruct();
    }

    /**
     * @override
     * @inheritDoc
     */
    public function isReadable()
    {
        return $this->readable;
    }

    /**
     * @override
     * @inheritDoc
     */
    public function setBufferSize($bufferSize)
    {
        $this->bufferSize = $bufferSize;
    }

    /**
     * @override
     * @inheritDoc
     */
    public function getBufferSize()
    {
        return $this->bufferSize;
    }

    /**
     * @override
     * @inheritDoc
     */
    public function read($length = null)

This method seems to be duplicated in your project.

    {
        if (!$this->readable)
        {
            return $this->throwAndEmitException(
                new ReadException('Stream is no longer readable.')
            );
        }

        if ($length === null)
        {
            $length = $this->bufferSize;
        }

        $ret = fread($this->resource, $length);

        if ($ret === false)
        {
            return $this->throwAndEmitException(
                new ReadException('Cannot read stream.')
            );
        }
        else if ($ret !== '')
        {
            $this->emit('data', [ $this, $ret ]);

            if (strlen($ret) < $length)
            {
                $this->emit('end', [ $this ]);
            }
        }

        return $ret;
    }

    /**
     * @override
     * @inheritDoc
     */
    public function close()

This method seems to be duplicated in your project.

    {
        if ($this->closing)
        {
            return;
        }

        $this->closing = true;
        $this->readable = false;
        $this->writable = false;

The property writable does not exist. Did you maybe forget to declare it?

        $this->emit('close', [ $this ]);
        $this->handleClose();
        $this->emit('done', [ $this ]);
    }
}