Completed
Pull Request — master (#11)
by
unknown
02:38
created
src/Redis/Driver/DriverInterface.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -6,5 +6,8 @@
 block discarded – undo
6 6
 
7 7
 interface DriverInterface
8 8
 {
9
+    /**
10
+     * @return string
11
+     */
9 12
     public function commands(Request $request);
10 13
 }
11 14
\ No newline at end of file
Please login to merge, or discard this patch.
src/Redis/Driver/RequestInterface.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,4 +5,5 @@
 block discarded – undo
5 5
 use Clue\Redis\Protocol\Model\ModelInterface as ClueModelInterface;
6 6
 
7 7
 interface RequestInterface extends ClueModelInterface
8
-{}
8
+{
9
+}
Please login to merge, or discard this patch.
src/Redis/Redis.php 3 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -162,7 +162,7 @@
 block discarded – undo
162 162
 
163 163
         $this->reqs = [];
164 164
 
165
-         // TODO patch missing pub/sub, pipeline, auth
165
+            // TODO patch missing pub/sub, pipeline, auth
166 166
         $this->handleStop();
167 167
         $this->emit('stop', [ $this ]);
168 168
 
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 
144 144
         // TODO patch missing pub/sub, pipeline, auth
145 145
         $this->handleStart();
146
-        $this->emit('start', [ $this ]);
146
+        $this->emit('start', [$this]);
147 147
 
148 148
         return true;
149 149
     }
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
 
175 175
          // TODO patch missing pub/sub, pipeline, auth
176 176
         $this->handleStop();
177
-        $this->emit('stop', [ $this ]);
177
+        $this->emit('stop', [$this]);
178 178
 
179 179
         return true;
180 180
     }
@@ -226,8 +226,8 @@  discard block
 block discarded – undo
226 226
     {
227 227
         if ($this->stream !== null)
228 228
         {
229
-            $this->stream->on('data', [ $this, 'handleData' ]);
230
-            $this->stream->on('close', [ $this, 'stop' ]);
229
+            $this->stream->on('data', [$this, 'handleData']);
230
+            $this->stream->on('close', [$this, 'stop']);
231 231
         }
232 232
     }
233 233
 
@@ -238,8 +238,8 @@  discard block
 block discarded – undo
238 238
     {
239 239
         if ($this->stream !== null)
240 240
         {
241
-            $this->stream->removeListener('data', [ $this, 'handleData' ]);
242
-            $this->stream->removeListener('close', [ $this, 'stop' ]);
241
+            $this->stream->removeListener('data', [$this, 'handleData']);
242
+            $this->stream->removeListener('close', [$this, 'stop']);
243 243
         }
244 244
     }
245 245
 
@@ -256,7 +256,7 @@  discard block
 block discarded – undo
256 256
         }
257 257
         catch (ParserException $error)
258 258
         {
259
-            $this->emit('error', [ $this, $error ]);
259
+            $this->emit('error', [$this, $error]);
260 260
             $this->stop();
261 261
             return;
262 262
         }
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
             }
270 270
             catch (UnderflowException $error)
271 271
             {
272
-                $this->emit('error', [ $this, $error ]);
272
+                $this->emit('error', [$this, $error]);
273 273
                 $this->stop();
274 274
                 return;
275 275
             }
Please login to merge, or discard this patch.
Braces   +8 added lines, -4 removed lines patch added patch discarded remove patch
@@ -128,9 +128,11 @@  discard block
 block discarded – undo
128 128
             $stream = $this->createClient($this->endpoint);
129 129
         }
130 130
         catch (Error $ex)
131
-        {}
131
+        {
132
+}
132 133
         catch (Exception $ex)
133
-        {}
134
+        {
135
+}
134 136
 
135 137
         if ($ex !== null)
136 138
         {
@@ -320,9 +322,11 @@  discard block
 block discarded – undo
320 322
             return new Socket($endpoint, $this->loop);
321 323
         }
322 324
         catch (Error $ex)
323
-        {}
325
+        {
326
+}
324 327
         catch (Exception $ex)
325
-        {}
328
+        {
329
+}
326 330
 
327 331
         throw new ExecutionException('Redis connection socket could not be created!', 0, $ex);
328 332
     }
Please login to merge, or discard this patch.
src/Redis/Command/Api/ApiConnInterface.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
      * @param string $message
19 19
      * @return mixed
20 20
      */
21
-    public function ping($message='pong');
21
+    public function ping($message = 'pong');
22 22
 
23 23
     /**
24 24
      * @doc https://redis.io/commands/quit
Please login to merge, or discard this patch.
src/Redis/Command/Compose/ApiSetHashTrait.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -48,13 +48,13 @@
 block discarded – undo
48 48
         $command = Enum::HGETALL;
49 49
         $args = [$key];
50 50
 
51
-        return $this->dispatch(Builder::build($command, $args))->then(function ($value) {
51
+        return $this->dispatch(Builder::build($command, $args))->then(function($value) {
52 52
             if (!empty($value)) {
53 53
                 $tmp = [];
54 54
                 $size = count($value);
55
-                for ($i=0; $i<$size; $i+=2) {
55
+                for ($i = 0; $i < $size; $i += 2) {
56 56
                     $field = $value[$i];
57
-                    $val = $value[$i+1];
57
+                    $val = $value[$i + 1];
58 58
                     $tmp[$field] = $val;
59 59
                 }
60 60
                 $value = $tmp;
Please login to merge, or discard this patch.
Braces   +8 added lines, -4 removed lines patch added patch discarded remove patch
@@ -49,10 +49,12 @@  discard block
 block discarded – undo
49 49
         $args = [$key];
50 50
 
51 51
         return $this->dispatch(Builder::build($command, $args))->then(function ($value) {
52
-            if (!empty($value)) {
52
+            if (!empty($value))
53
+            {
53 54
                 $tmp = [];
54 55
                 $size = count($value);
55
-                for ($i=0; $i<$size; $i+=2) {
56
+                for ($i=0; $i<$size; $i+=2)
57
+                {
56 58
                     $field = $value[$i];
57 59
                     $val = $value[$i+1];
58 60
                     $tmp[$field] = $val;
@@ -133,8 +135,10 @@  discard block
 block discarded – undo
133 135
     {
134 136
         $command = Enum::HMSET;
135 137
         $args = [$key];
136
-        if (!empty($fvMap)) {
137
-            foreach ($fvMap as $field => $value) {
138
+        if (!empty($fvMap))
139
+        {
140
+            foreach ($fvMap as $field => $value)
141
+            {
138 142
                 $tmp[] = $field;
139 143
                 $tmp[] = $value;
140 144
             }
Please login to merge, or discard this patch.
src/Redis/Command/Compose/ApiGeospatialTrait.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@
 block discarded – undo
60 60
     {
61 61
         // TODO: Implement geoDist() method.
62 62
         $command = Enum::GEODIST;
63
-        $args = [$key, $memberA, $memberB ,$unit];
63
+        $args = [$key, $memberA, $memberB, $unit];
64 64
 
65 65
         return $this->dispatch(Builder::build($command, $args));
66 66
     }
Please login to merge, or discard this patch.
src/Redis/Command/Compose/ApiKeyValTrait.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -347,7 +347,7 @@
 block discarded – undo
347 347
      * @override
348 348
      * @inheritDoc
349 349
      */
350
-    public function del($key,...$keys)
350
+    public function del($key, ...$keys)
351 351
     {
352 352
         $command = Enum::DEL;
353 353
         $keys[] = $key;
Please login to merge, or discard this patch.
Braces   +10 added lines, -5 removed lines patch added patch discarded remove patch
@@ -47,7 +47,8 @@  discard block
 block discarded – undo
47 47
         $command = Enum::BITFIELD;
48 48
         $subCommand = strtoupper($subCommand);
49 49
         //TODO: control flow improvement
50
-        switch ($subCommand) {
50
+        switch ($subCommand)
51
+        {
51 52
             case 'GET' : {
52 53
                 @list ($type, $offset) = $param;
53 54
                 $args = [$key, $subCommand, $type, $offset];
@@ -304,8 +305,10 @@  discard block
 block discarded – undo
304 305
     {
305 306
         $command = Enum::MSET;
306 307
         $args = [];
307
-        if (!empty($kvMap)) {
308
-            foreach ($kvMap as $key => $val) {
308
+        if (!empty($kvMap))
309
+        {
310
+            foreach ($kvMap as $key => $val)
311
+            {
309 312
                 $args[] = $key;
310 313
                 $args[] = $val;
311 314
             }
@@ -322,8 +325,10 @@  discard block
 block discarded – undo
322 325
     {
323 326
         $command = Enum::MSETNX;
324 327
         $args = [];
325
-        if (!empty($kvMap)) {
326
-            foreach ($kvMap as $key => $val) {
328
+        if (!empty($kvMap))
329
+        {
330
+            foreach ($kvMap as $key => $val)
331
+            {
327 332
                 $args[] = $key;
328 333
                 $args[] = $val;
329 334
             }
Please login to merge, or discard this patch.
src/Redis/Command/Compose/ApiListTrait.php 2 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -25,9 +25,9 @@  discard block
 block discarded – undo
25 25
         $keys[] = $timeout;
26 26
         $args = $keys;
27 27
         $promise = $this->dispatch(Builder::build($command, $args));
28
-        $promise = $promise->then(function ($value) {
28
+        $promise = $promise->then(function($value) {
29 29
             if (is_array($value)) {
30
-                list($k,$v) = $value;
30
+                list($k, $v) = $value;
31 31
 
32 32
                 return [
33 33
                     'key'=>$k,
@@ -52,9 +52,9 @@  discard block
 block discarded – undo
52 52
         $keys[] = $timeout;
53 53
         $args = $keys;
54 54
         $promise = $this->dispatch(Builder::build($command, $args));
55
-        $promise = $promise->then(function ($value) {
55
+        $promise = $promise->then(function($value) {
56 56
             if (is_array($value)) {
57
-                list($k,$v) = $value;
57
+                list($k, $v) = $value;
58 58
 
59 59
                 return [
60 60
                     'key'=>$k,
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
      * @override
138 138
      * @inheritDoc
139 139
      */
140
-    public function lPush($key,...$values)
140
+    public function lPush($key, ...$values)
141 141
     {
142 142
         $command = Enum::LPUSH;
143 143
         array_unshift($values, $key);
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -26,7 +26,8 @@  discard block
 block discarded – undo
26 26
         $args = $keys;
27 27
         $promise = $this->dispatch(Builder::build($command, $args));
28 28
         $promise = $promise->then(function ($value) {
29
-            if (is_array($value)) {
29
+            if (is_array($value))
30
+            {
30 31
                 list($k,$v) = $value;
31 32
 
32 33
                 return [
@@ -53,7 +54,8 @@  discard block
 block discarded – undo
53 54
         $args = $keys;
54 55
         $promise = $this->dispatch(Builder::build($command, $args));
55 56
         $promise = $promise->then(function ($value) {
56
-            if (is_array($value)) {
57
+            if (is_array($value))
58
+            {
57 59
                 list($k,$v) = $value;
58 60
 
59 61
                 return [
Please login to merge, or discard this patch.
src/Redis/Command/Api/ApiSetSortedInterface.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -66,7 +66,6 @@
 block discarded – undo
66 66
      * @param $key
67 67
      * @param $star
68 68
      * @param $stop
69
-     * @param array $options
70 69
      * @return mixed
71 70
      */
72 71
     public function zRange($key, $star = 0, $stop = -1, $withScores = false);
Please login to merge, or discard this patch.