ApiHyperLogTrait::pFMerge() - Code Metrics - Inspection of "Add most parts implements of ApiCoreTrait tests" - dazzle-php/redis - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#11)

unknown

created 2017-07-28 16:44 UTC

ApiHyperLogTrait::pFMerge() A

↳ Parent: ApiHyperLogTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	7
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	7
loc	7
ccs	0
cts	4
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	2
crap	2

<?php

namespace Dazzle\Redis\Command\Compose;

use Dazzle\Redis\Command\Builder;
use Dazzle\Redis\Command\Enum;
use Dazzle\Redis\Driver\Request;

trait ApiHyperLogTrait
{
    /**
     * @param Request $request
     * @return mixed
     */
    abstract function dispatch(Request $request);


    /**
     * @override
     * @inheritDoc
     */
    public function pFAdd($key, ...$elements)
    {
        $command = Enum::PFADD;
        $args = [$key];
        $args = array_merge($args, $elements);

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function pFCount(...$keys)
    {
        $command = Enum::PFCOUNT;
        $args = $keys;

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function pFMerge($dstKey, ...$srcKeys)

    {
        $command = Enum::PFMERGE;
        $args = array_merge([$dstKey], $srcKeys);

        return $this->dispatch(Builder::build($command, $args));
    }
}


1		<?php
2
3		namespace Dazzle\Redis\Command\Compose;
4
5		use Dazzle\Redis\Command\Builder;
6		use Dazzle\Redis\Command\Enum;
7		use Dazzle\Redis\Driver\Request;
8
9		trait ApiHyperLogTrait
10		{
11		/**
12		* @param Request $request
13		* @return mixed
14		*/
15		abstract function dispatch(Request $request);
		0 ignored issues – show Best Practice introduced 2017-07-02 15:04 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
16
17		/**
18		* @override
19		* @inheritDoc
20		*/
21		public function pFAdd($key, ...$elements)
22		{
23		$command = Enum::PFADD;
24		$args = [$key];
25		$args = array_merge($args, $elements);
26
27		return $this->dispatch(Builder::build($command, $args));
28		}
29
30		/**
31		* @override
32		* @inheritDoc
33		*/
34		public function pFCount(...$keys)
35		{
36		$command = Enum::PFCOUNT;
37		$args = $keys;
38
39		return $this->dispatch(Builder::build($command, $args));
40		}
41
42		/**
43		* @override
44		* @inheritDoc
45		*/
46	View Code Duplication	public function pFMerge($dstKey, ...$srcKeys)
		0 ignored issues – show Duplication introduced 2017-07-23 15:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
47		{
48		$command = Enum::PFMERGE;
49		$args = array_merge([$dstKey], $srcKeys);
50
51		return $this->dispatch(Builder::build($command, $args));
52		}
53		}
54

dazzle-php / redis

Pull Request — master (#11)

ApiHyperLogTrait::pFMerge() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like