Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 9 | trait ApiSetTrait |
||
| 10 | { |
||
| 11 | /** |
||
| 12 | * @param Request $request |
||
| 13 | * @return mixed |
||
| 14 | */ |
||
| 15 | abstract function dispatch(Request $request); |
||
| 16 | |||
| 17 | /** |
||
| 18 | * @override |
||
| 19 | * @inheritDoc |
||
| 20 | */ |
||
| 21 | public function sScan($key, $cursor, array $options = []) |
||
| 29 | |||
| 30 | /** |
||
| 31 | * @override |
||
| 32 | * @inheritDoc |
||
| 33 | */ |
||
| 34 | public function sInter(...$keys) |
||
| 41 | |||
| 42 | /** |
||
| 43 | * @override |
||
| 44 | * @inheritDoc |
||
| 45 | */ |
||
| 46 | 1 | public function sInterStore($dst, ...$keys) |
|
| 54 | |||
| 55 | /** |
||
| 56 | * @override |
||
| 57 | * @inheritDoc |
||
| 58 | */ |
||
| 59 | 1 | public function sIsMember($key, $member) |
|
| 66 | |||
| 67 | /** |
||
| 68 | * @override |
||
| 69 | * @inheritDoc |
||
| 70 | */ |
||
| 71 | 1 | View Code Duplication | public function sMembers($key) |
| 78 | |||
| 79 | /** |
||
| 80 | * @override |
||
| 81 | * @inheritDoc |
||
| 82 | */ |
||
| 83 | 1 | View Code Duplication | public function sMove($src, $dst, $member) |
| 90 | |||
| 91 | /** |
||
| 92 | * @override |
||
| 93 | * @inheritDoc |
||
| 94 | */ |
||
| 95 | 1 | View Code Duplication | public function sPop($key, $count) |
| 102 | |||
| 103 | /** |
||
| 104 | * @override |
||
| 105 | * @inheritDoc |
||
| 106 | */ |
||
| 107 | 1 | View Code Duplication | public function sRandMember($key, $count) |
| 114 | |||
| 115 | /** |
||
| 116 | * @override |
||
| 117 | * @inheritDoc |
||
| 118 | */ |
||
| 119 | 1 | public function sRem($key, ...$members) |
|
| 127 | |||
| 128 | /** |
||
| 129 | * @override |
||
| 130 | * @inheritDoc |
||
| 131 | */ |
||
| 132 | 1 | public function sUnion(...$keys) |
|
| 139 | |||
| 140 | /** |
||
| 141 | * @override |
||
| 142 | * @inheritDoc |
||
| 143 | */ |
||
| 144 | 1 | public function sUnionStore($dst, ...$keys) |
|
| 152 | |||
| 153 | |||
| 154 | /** |
||
| 155 | * @override |
||
| 156 | * @inheritDoc |
||
| 157 | */ |
||
| 158 | 14 | public function sAdd($key, ...$members) |
|
| 166 | |||
| 167 | /** |
||
| 168 | * @override |
||
| 169 | * @inheritDoc |
||
| 170 | */ |
||
| 171 | 1 | View Code Duplication | public function sCard($key) |
| 178 | |||
| 179 | /** |
||
| 180 | * @override |
||
| 181 | * @inheritDoc |
||
| 182 | */ |
||
| 183 | 1 | public function sDiff(...$keys) |
|
| 190 | |||
| 191 | /** |
||
| 192 | * @override |
||
| 193 | * @inheritDoc |
||
| 194 | */ |
||
| 195 | 1 | public function sDiffStore($dst, ...$keys) |
|
| 203 | } |
||
| 204 |
Adding explicit visibility (
private,protected, orpublic) is generally recommend to communicate to other developers how, and from where this method is intended to be used.