Dazzle\Redis\Command\Compose\ApiSetHashTrait

Complexity

Total Complexity

19

Size/Duplication

Total Lines	213
Duplicated Lines	10.8 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

16 Methods

Rating	Name	Duplication	Size	Complexity
	dispatch()	0	1	?
A	hDel()	0	8	1
A	hGet()	0	7	1
A	hGetAll()	0	20	3
A	hIncrBy()	0	7	1
A	hIncrByFloat()	0	7	1
A	hKeys()	7	7	1
A	hLen()	7	7	1
A	hMGet()	0	8	1
A	hMSet()	0	16	3
A	hSet()	0	7	1
A	hSetNx()	0	7	1
A	hStrLen()	0	7	1
A	hVals()	7	7	1
A	hScan()	0	9	1
A	hExists()	0	7	1

<?php

namespace Dazzle\Redis\Command\Compose;

use Dazzle\Redis\Command\Builder;
use Dazzle\Redis\Command\Enum;
use Dazzle\Redis\Driver\Request;

trait ApiSetHashTrait
{
    /**
     * @param Request $request
     * @return mixed
     */
    abstract function dispatch(Request $request);

It is generally recommended to explicitly declare the visibility for methods.

    /**
     * @override
     * @inheritDoc
     */
    public function hDel($key, ...$fields)
    {
        $command = Enum::HDEL;
        $args = [$key];
        $args = array_merge($args, $fields);

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function hGet($key, $field)
    {
        $command = Enum::HGET;
        $args = [$key, $field];

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function hGetAll($key)
    {
        $command = Enum::HGETALL;
        $args = [$key];

        return $this->dispatch(Builder::build($command, $args))->then(function ($value) {
            if (!empty($value)) {
                $tmp = [];
                $size = count($value);
                for ($i=0; $i<$size; $i+=2) {
                    $field = $value[$i];
                    $val = $value[$i+1];
                    $tmp[$field] = $val;
                }
                $value = $tmp;
            }

            return $value;
        });
    }

    /**
     * @override
     * @inheritDoc
     */
    public function hIncrBy($key, $field, $increment)
    {
        $command = Enum::HINCRBY;
        $args = [$key, $field, $increment];

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function hIncrByFloat($key, $field, $increment)
    {
        $command = Enum::HINCRBYFLOAT;
        $args = [$key, $field, $increment];

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function hKeys($key)

This method seems to be duplicated in your project.

    {
        $command = Enum::HKEYS;
        $args = [$key];

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function hLen($key)

This method seems to be duplicated in your project.

    {
        $command = Enum::HLEN;
        $args = [$key];

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function hMGet($key, ...$fields)
    {
        $command = Enum::HMGET;
        $args = [$key];
        $args = array_merge($args, $fields);

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function hMSet($key, array $fvMap)
    {
        //TODO: replace param $fvMap to ...$fvs,cauz hash map not allow duplicate key
        $command = Enum::HMSET;
        $args = [$key];
        if (!empty($fvMap)) {
            foreach ($fvMap as $field => $value) {
                $tmp[] = $field;

$tmp was never initialized. Although not strictly required by PHP, it is generally a good practice to add $tmp = array(); before regardless.

                $tmp[] = $value;
            }
            $fvMap = $tmp;

The variable $tmp does not seem to be defined for all execution paths leading up to this point.

        }
        $args = array_merge($args, $fvMap);

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function hSet($key, $field, $value)
    {
        $command = Enum::HSET;
        $args = [$key, $field, $value];

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function hSetNx($key, $filed, $value)
    {
        $command = Enum::HSETNX;
        $args = [$key, $filed, $value];

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function hStrLen($key, $field)
    {
        $command = Enum::HSTRLEN;
        $args = [$key, $field];

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function hVals($key)

This method seems to be duplicated in your project.

    {
        $command = Enum::HVALS;
        $args = [$key];

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function hScan($key, $cursor, array $options = [])
    {
        // TODO: Implement hScan() method.
        $command = Enum::HSCAN;
        $args = [$key, $cursor];
        $args = array_merge($args, $options);

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @inheritDoc
     */
    public function hExists($key, $field)
    {
        $command = Enum::HEXISTS;
        $args = [$key, $field];

        return $this->dispatch(Builder::build($command, $args));
    }
}