Dazzle\Redis\Command\Compose\ApiGeospatialTrait

Complexity

Total Complexity

6

Size/Duplication

Total Lines	85
Duplicated Lines	18.82 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
	dispatch()	0	1	?
A	geoAdd()	0	9	1
A	geoHash()	0	5	1
A	geoPos()	0	9	1
A	geoDist()	0	8	1
A	geoRadius()	8	8	1
A	geoRadiusByMember()	8	8	1

<?php

namespace Dazzle\Redis\Command\Compose;

use Dazzle\Redis\Command\Builder;
use Dazzle\Redis\Command\Enum;
use Dazzle\Redis\Driver\Request;

trait ApiGeospatialTrait
{
    /**
     * @param Request $request
     * @return mixed
     */
    abstract function dispatch(Request $request);

It is generally recommended to explicitly declare the visibility for methods.

    /**
     * @override
     * @inheritDoc
     */
    public function geoAdd($key, array $coordinates)
    {
        // TODO: Implement geoAdd() method.
        $command = Enum::GEOADD;
        $args = [$key];
        $args = array_merge($args, $coordinates);

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function geoHash($key, ...$members)

The parameter $key is not used and could be removed.

The parameter $members is not used and could be removed.

    {
        // TODO: Implement geoHash() method.
        $command = Enum::GEOHASH;

$command is not used, you could remove the assignment.

    }

    /**
     * @override
     * @inheritDoc
     */
    public function geoPos($key, ...$members)
    {
        // TODO: Implement geoPos() method.
        $command = Enum::GEOPOS;
        $args = [$key];
        $args = array_merge($args, $members);

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function geoDist($key, $memberA, $memberB, $unit)
    {
        // TODO: Implement geoDist() method.
        $command = Enum::GEODIST;
        $args = [$key, $memberA, $memberB ,$unit];

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function geoRadius($key, $longitude, $latitude, $unit, $command, $count, $sort)

The parameter $command is not used and could be removed.

This method seems to be duplicated in your project.

    {
        // TODO: Implement geoRadius() method.
        $command = Enum::GEORADIUS;
        $args = [$key, $longitude, $latitude, $unit, $command, $count, $sort];

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function geoRadiusByMember($key, $member, $unit, $command, $count, $sort, $store, $storeDist)

The parameter $command is not used and could be removed.

This method seems to be duplicated in your project.

    {
        // TODO: Implement geoRadiusByMember() method.
        $command = Enum::GEORADIUSBYMEMBER;
        $args = [$key, $member, $unit, $command, $count, $sort, $store, $storeDist];

        return $this->dispatch(Builder::build($command, $args));
    }
}