Dazzle\Redis\Command\Compose\ApiChannelTrait

Complexity

Total Complexity

6

Size/Duplication

Total Lines	85
Duplicated Lines	9.41 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
	dispatch()	0	1	?
A	pSubscribe()	0	8	1
A	pubSub()	0	7	1
A	publish()	8	8	1
A	pUnsubscribe()	0	8	1
A	unSubscribe()	0	8	1
A	subscribe()	0	8	1

<?php

namespace Dazzle\Redis\Command\Compose;

use Dazzle\Redis\Command\Builder;
use Dazzle\Redis\Command\Enum;
use Dazzle\Redis\Driver\Request;

trait ApiChannelTrait
{
    /**
     * @param Request $request
     * @return mixed
     */
    abstract function dispatch(Request $request);

It is generally recommended to explicitly declare the visibility for methods.

    /**
     * @override
     * @inheritDoc
     */
    public function pSubscribe(...$patterns)
    {
        // TODO: Implement pSubscribe() method.
        $command = Enum::PSUBSCRIBE;
        $args = $patterns;

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function pubSub($command, array $args = [])

The parameter $command is not used and could be removed.

    {
        // TODO: Implement pubSub() method.
        $command = Enum::PUBSUB;

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function publish($channel, $message)

This method seems to be duplicated in your project.

    {
        // TODO: Implement publish() method.
        $command = Enum::PUBLISH;
        $args = [$channel, $message];

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function pUnsubscribe(...$patterns)
    {
        // TODO: Implement pUnsubscribe() method.
        $command = Enum::PUNSUBSCRIBE;
        $args = $patterns;

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function unSubscribe(...$channels)
    {
        // TODO: Implement unSubscribe() method.
        $command = Enum::UNSUBSCRIBE;
        $args = $channels;

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function subscribe(...$channels)
    {
        // TODO: Implement subscribe() method.
        $command = Enum::SUBSCRIBE;
        $args = $channels;

        return $this->dispatch(Builder::build($command, $args));
    }
}