Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
9 | trait ApiSetTrait |
||
10 | { |
||
11 | /** |
||
12 | * @param Request $request |
||
13 | * @return mixed |
||
14 | */ |
||
15 | abstract function dispatch(Request $request); |
||
16 | |||
17 | /** |
||
18 | * @override |
||
19 | * @inheritDoc |
||
20 | */ |
||
21 | public function sScan($key, $cursor, array $options = []) |
||
29 | |||
30 | /** |
||
31 | * @override |
||
32 | * @inheritDoc |
||
33 | */ |
||
34 | public function sInter(...$keys) |
||
41 | |||
42 | /** |
||
43 | * @override |
||
44 | * @inheritDoc |
||
45 | */ |
||
46 | 1 | public function sInterStore($dst, ...$keys) |
|
54 | |||
55 | /** |
||
56 | * @override |
||
57 | * @inheritDoc |
||
58 | */ |
||
59 | 1 | public function sIsMember($key, $member) |
|
66 | |||
67 | /** |
||
68 | * @override |
||
69 | * @inheritDoc |
||
70 | */ |
||
71 | 1 | View Code Duplication | public function sMembers($key) |
78 | |||
79 | /** |
||
80 | * @override |
||
81 | * @inheritDoc |
||
82 | */ |
||
83 | 1 | public function sMove($src, $dst, ...$members) |
|
91 | |||
92 | /** |
||
93 | * @override |
||
94 | * @inheritDoc |
||
95 | */ |
||
96 | 1 | View Code Duplication | public function sPop($key, $count) |
103 | |||
104 | /** |
||
105 | * @override |
||
106 | * @inheritDoc |
||
107 | */ |
||
108 | 1 | View Code Duplication | public function sRandMember($key, $count) |
115 | |||
116 | /** |
||
117 | * @override |
||
118 | * @inheritDoc |
||
119 | */ |
||
120 | 1 | public function sRem($key, ...$members) |
|
128 | |||
129 | /** |
||
130 | * @override |
||
131 | * @inheritDoc |
||
132 | */ |
||
133 | 1 | public function sUnion(...$keys) |
|
140 | |||
141 | /** |
||
142 | * @override |
||
143 | * @inheritDoc |
||
144 | */ |
||
145 | 1 | public function sUnionStore($dst, ...$keys) |
|
153 | |||
154 | |||
155 | /** |
||
156 | * @override |
||
157 | * @inheritDoc |
||
158 | */ |
||
159 | 14 | public function sAdd($key, ...$members) |
|
167 | |||
168 | /** |
||
169 | * @override |
||
170 | * @inheritDoc |
||
171 | */ |
||
172 | 1 | View Code Duplication | public function sCard($key) |
179 | |||
180 | /** |
||
181 | * @override |
||
182 | * @inheritDoc |
||
183 | */ |
||
184 | 1 | public function sDiff(...$keys) |
|
191 | |||
192 | /** |
||
193 | * @override |
||
194 | * @inheritDoc |
||
195 | */ |
||
196 | 1 | public function sDiffStore($dst, ...$keys) |
|
204 | } |
||
205 |
Adding explicit visibility (
private
,protected
, orpublic
) is generally recommend to communicate to other developers how, and from where this method is intended to be used.