Config::__construct() - Code Metrics - Inspection of "Rebase on Dazzle/Redis master branch" - dazzle-php/redis - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

unknown

created 2017-07-03 14:29 UTC

Config::__construct() D

↳ Parent: Config

Complexity

Conditions	13
Paths	260

Size

Total Lines	50
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	182

Importance

Changes

Metric	Value
dl	0
loc	50
ccs	0
cts	40
cp	0
rs	4
c	0
b	0
f	0
cc	13
eloc	29
nc	260
nop	1
crap	182

How to fix Complexity

<?php

namespace Kraken\Redis;

use InvalidArgumentException;

class Config
{
    public function __construct($target)
    {
        if ($target === null) {
            $target = 'tcp://127.0.0.1';
        }

        if (strpos($target, '://') === false) {
            $target = 'tcp://' . $target;
        }

        $parts = parse_url($target);
        if ($parts === false || !isset($parts['host']) || $parts['scheme'] !== 'tcp') {
            throw new InvalidArgumentException('Given URL can not be parsed');
        }

        if (!isset($parts['port'])) {
            $parts['port'] = 6379;
            $this->port = 6379;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }

        if ($parts['host'] === 'localhost') {
            $parts['host'] = '127.0.0.1';
            $this->host = '127.0.0.1';
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }

        $auth = null;
        if (isset($parts['user'])) {
            $auth = $parts['user'];
            $this->auth = $auth;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }

        if (isset($parts['pass'])) {
            $auth .= ':' . $parts['pass'];
        }

        if ($auth !== null) {
            $parts['auth'] = $auth;
        }

        if (isset($parts['path']) && $parts['path'] !== '') {
            $parts['db'] = substr($parts['path'], 1);
        }

        unset($parts['scheme'], $parts['user'], $parts['pass'], $parts['path']);

        $this->host = $parts['host'];
        $this->port = $parts['port'];
        $this->auth = $auth;
        $this->db =  $parts['db'];
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function getHost()
    {

    }

    public function getPort()
    {

    }

    public function getDb()
    {

    }
}

1			<?php
2
3			namespace Kraken\Redis;
4
5			use InvalidArgumentException;
6
7			class Config
8			{
9			public function __construct($target)
10			{
11			if ($target === null) {
12			$target = 'tcp://127.0.0.1';
13			}
14
15			if (strpos($target, '://') === false) {
16			$target = 'tcp://' . $target;
17			}
18
19			$parts = parse_url($target);
20			if ($parts === false \|\| !isset($parts['host']) \|\| $parts['scheme'] !== 'tcp') {
21			throw new InvalidArgumentException('Given URL can not be parsed');
22			}
23
24			if (!isset($parts['port'])) {
25			$parts['port'] = 6379;
26			$this->port = 6379;
			0 ignored issues – show Bug introduced 2017-07-02 15:22 UTC by Report Bug Copy Issue Report The property `port` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
27			}
28
29			if ($parts['host'] === 'localhost') {
30			$parts['host'] = '127.0.0.1';
31			$this->host = '127.0.0.1';
			0 ignored issues – show Bug introduced 2017-07-02 15:22 UTC by Report Bug Copy Issue Report The property `host` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
32			}
33
34			$auth = null;
35			if (isset($parts['user'])) {
36			$auth = $parts['user'];
37			$this->auth = $auth;
			0 ignored issues – show Bug introduced 2017-07-02 15:22 UTC by Report Bug Copy Issue Report The property `auth` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
38			}
39
40			if (isset($parts['pass'])) {
41			$auth .= ':' . $parts['pass'];
42			}
43
44			if ($auth !== null) {
45			$parts['auth'] = $auth;
46			}
47
48			if (isset($parts['path']) && $parts['path'] !== '') {
49			$parts['db'] = substr($parts['path'], 1);
50			}
51
52			unset($parts['scheme'], $parts['user'], $parts['pass'], $parts['path']);
53
54			$this->host = $parts['host'];
55			$this->port = $parts['port'];
56			$this->auth = $auth;
57			$this->db = $parts['db'];
			0 ignored issues – show Bug introduced 2017-07-02 15:22 UTC by Report Bug Copy Issue Report The property `db` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
58			}
59
60			public function getHost()
61			{
62
63			}
64
65			public function getPort()
66			{
67
68			}
69
70			public function getDb()
71			{
72
73			}
74			}

dazzle-php / redis

Pull Request — master (#2)

Config::__construct() D

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like