Dazzle\Redis\Redis

Complexity

Total Complexity

5

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	16

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	__destruct()	0	4	1
A	pipe()	0	21	2
A	connect()	0	4	1

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 15 and the first side effect is on line 88.

namespace Dazzle\Redis;

use Dazzle\Promise\Deferred;
use Dazzle\Redis\Command\Enum;
use Dazzle\Loop\LoopInterface;
use Dazzle\Loop\LoopAwareTrait;
use Dazzle\Redis\Driver\Request;
use Dazzle\Redis\Command\Builder;
use Dazzle\Promise\PromiseInterface;
use Dazzle\Throwable\Exception\RuntimeException;
use Error;

class Redis

There is one abstract method dispatch in this class; you could implement it, or declare this class as abstract.

{
    use LoopAwareTrait;
    use Command\Compose\ApiChannelTrait;
    use Command\Compose\ApiClusterTrait;
    use Command\Compose\ApiConnTrait;
    use Command\Compose\ApiCoreTrait;
    use Command\Compose\ApiGeospatialTrait;
    use Command\Compose\ApiHyperLogTrait;
    use Command\Compose\ApiKeyValTrait;
    use Command\Compose\ApiListTrait;
    use Command\Compose\ApiSetTrait;
    use Command\Compose\ApiSetHashTrait;
    use Command\Compose\ApiSetSortedTrait;
    use Command\Compose\ApiTransactionTrait;

    /**
     * @var string
     */
    protected $endpoint;

    /**
     * @param string $endpoint
     * @param LoopInterface $loop
     */
    public function __construct($endpoint, LoopInterface $loop)
    {
        $this->endpoint = $endpoint;
        $this->loop = $loop;
        $this->dispatcher = new Dispatcher($loop);

The property dispatcher does not exist. Did you maybe forget to declare it?

        $this->driver = $this->dispatcher->getDriver();

The property driver does not exist. Did you maybe forget to declare it?

    }

    /**
     *
     */
    public function __destruct()
    {

    }

    /**
     * Pipe Redis request.
     *
     * @param Request $command
     * @return PromiseInterface
     */
    private function pipe(Request $command)

This method is not used, and could be removed.

    {
        $request = new Deferred();
        $promise = $request->getPromise();
        if ($this->dispatcher->isEnding())
        {
            $request->reject(new RuntimeException('Connection closed'));
        } 
        else 
        {
            $payload = $this->driver->commands($command);

            $this->dispatcher->on('request', function () use ($payload) {
                $this->dispatcher->handleRequest($payload);
            });

            $this->dispatcher->appendRequest($request);
        }

        return $promise;
    }

    public function connect($config = [])

The parameter $config is not used and could be removed.

    {
        $this->dispatcher->watch($this->endpoint);
    }
};