Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 9 | trait ApiListTrait |
||
| 10 | { |
||
| 11 | /** |
||
| 12 | * @param Request $request |
||
| 13 | * @return mixed |
||
| 14 | */ |
||
| 15 | abstract function dispatch(Request $request); |
||
| 16 | |||
| 17 | /** |
||
| 18 | * @override |
||
| 19 | * @inheritDoc |
||
| 20 | */ |
||
| 21 | 1 | View Code Duplication | public function blPop(array $keys, $timeout) |
| 42 | |||
| 43 | /** |
||
| 44 | * @override |
||
| 45 | * @inheritDoc |
||
| 46 | */ |
||
| 47 | 1 | View Code Duplication | public function brPop(array $keys, $timeout) |
| 68 | |||
| 69 | /** |
||
| 70 | * @override |
||
| 71 | * @inheritDoc |
||
| 72 | */ |
||
| 73 | 1 | public function brPopLPush($src, $dst, $timeout) |
|
| 80 | |||
| 81 | /** |
||
| 82 | * @override |
||
| 83 | * @inheritDoc |
||
| 84 | */ |
||
| 85 | 5 | public function lIndex($key, $index) |
|
| 92 | |||
| 93 | /** |
||
| 94 | * @override |
||
| 95 | * @inheritDoc |
||
| 96 | */ |
||
| 97 | 1 | public function lInsert($key, $action, $pivot, $value) |
|
| 104 | |||
| 105 | /** |
||
| 106 | * @override |
||
| 107 | * @inheritDoc |
||
| 108 | */ |
||
| 109 | 1 | View Code Duplication | public function lLen($key) |
| 116 | |||
| 117 | /** |
||
| 118 | * @override |
||
| 119 | * @inheritDoc |
||
| 120 | */ |
||
| 121 | 1 | View Code Duplication | public function lPop($key) |
| 128 | |||
| 129 | /** |
||
| 130 | * @override |
||
| 131 | * @inheritDoc |
||
| 132 | */ |
||
| 133 | 15 | public function lPush($key,...$values) |
|
| 140 | |||
| 141 | 1 | View Code Duplication | public function lPushX($key, $value) |
| 148 | |||
| 149 | /** |
||
| 150 | * @override |
||
| 151 | * @inheritDoc |
||
| 152 | */ |
||
| 153 | 1 | View Code Duplication | public function lRange($key, $start = 0, $stop = -1) |
| 160 | |||
| 161 | /** |
||
| 162 | * @override |
||
| 163 | * @inheritDoc |
||
| 164 | */ |
||
| 165 | 1 | public function lRem($key, $count, $value) |
|
| 172 | |||
| 173 | /** |
||
| 174 | * @override |
||
| 175 | * @inheritDoc |
||
| 176 | */ |
||
| 177 | 1 | public function lSet($key, $index, $value) |
|
| 184 | |||
| 185 | /** |
||
| 186 | * @override |
||
| 187 | * @inheritDoc |
||
| 188 | */ |
||
| 189 | 1 | public function lTrim($key, $start, $stop) |
|
| 196 | |||
| 197 | /** |
||
| 198 | * @override |
||
| 199 | * @inheritDoc |
||
| 200 | */ |
||
| 201 | 1 | View Code Duplication | public function rPop($key) |
| 208 | |||
| 209 | /** |
||
| 210 | * @override |
||
| 211 | * @inheritDoc |
||
| 212 | */ |
||
| 213 | 1 | View Code Duplication | public function rPopLPush($src, $dst) |
| 220 | |||
| 221 | /** |
||
| 222 | * @override |
||
| 223 | * @inheritDoc |
||
| 224 | */ |
||
| 225 | 2 | public function rPush($key, ...$values) |
|
| 233 | |||
| 234 | /** |
||
| 235 | * @override |
||
| 236 | * @inheritDoc |
||
| 237 | */ |
||
| 238 | 1 | View Code Duplication | public function rPushX($key, $value) |
| 245 | } |
||
| 246 |
Adding explicit visibility (
private,protected, orpublic) is generally recommend to communicate to other developers how, and from where this method is intended to be used.