Dazzle\Redis\Command\Compose\ApiHyperLogTrait

Complexity

Total Complexity

3

Size/Duplication

Total Lines	45
Duplicated Lines	15.56 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
	dispatch()	0	1	?
A	pFAdd()	0	8	1
A	pFCount()	0	7	1
A	pFMerge()	7	7	1

<?php

namespace Dazzle\Redis\Command\Compose;

use Dazzle\Redis\Command\Builder;
use Dazzle\Redis\Command\Enum;
use Dazzle\Redis\Driver\Request;

trait ApiHyperLogTrait
{
    /**
     * @param Request $request
     * @return mixed
     */
    abstract function dispatch(Request $request);

It is generally recommended to explicitly declare the visibility for methods.

    /**
     * @override
     * @inheritDoc
     */
    public function pFAdd($key, ...$elements)
    {
        $command = Enum::PFADD;
        $args = [$key];
        $args = array_merge($args, $elements);

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function pFCount(...$keys)
    {
        $command = Enum::PFCOUNT;
        $args = $keys;

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function pFMerge($dstKey, ...$srcKeys)

This method seems to be duplicated in your project.

    {
        $command = Enum::PFMERGE;
        $args = array_merge([$dstKey], $srcKeys);

        return $this->dispatch(Builder::build($command, $args));
    }
}