Issues in PromiseRejected.php (master) - Issues in master - dazzle-php/promise - Measure and Improve Code Quality continuously with Scrutinizer

Issues (27)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Promise/PromiseRejected.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Dazzle\Promise;

use Dazzle\Throwable\Exception\Logic\InvalidArgumentException;
use Dazzle\Throwable\Exception\Runtime\RejectionException;
use Dazzle\Throwable\ThrowableProxy;
use Error;
use Exception;

class PromiseRejected implements PromiseInterface
{
    /**
     * @var Error|Exception|ThrowableProxy|string|null
     */
    protected $reason;

    /**
     * @param Error|Exception|string|null
     * @throws InvalidArgumentException
     */
    public function __construct($reason = null)
    {
        if ($reason instanceof PromiseInterface)
        {
            throw new InvalidArgumentException(
                'You cannot create PromiseRejected with a promise. Use Promise::doReject($promiseOrValue) instead.'
            );
        }

        $this->reason = $reason;
    }

    /**
     *
     */
    public function __destruct()
    {
        unset($this->reason);
    }

    /**
     * @override
     * @inheritDoc
     */
    public function then(callable $onFulfilled = null, callable $onRejected = null, callable $onCancel = null)

    {
        if (null === $onRejected)
        {
            return $this;
        }

        try
        {
            return Promise::doResolve($onRejected($this->getReason()));
        }
        catch (Error $ex)
        {
            return new PromiseRejected($ex);
        }
        catch (Exception $ex)
        {
            return new PromiseRejected($ex);
        }
    }

    /**
     * @override
     * @inheritDoc
     */
    public function done(callable $onFulfilled = null, callable $onRejected = null, callable $onCancel = null)

    {
        if (null === $onRejected)
        {
            $this->throwError($this->getReason());

        }

        $result = $onRejected($this->getReason());

        if ($result instanceof self)
        {
            $this->throwError($result->getReason());

        }

        if ($result instanceof PromiseInterface)
        {
            $result->done();
        }
    }

    /**
     * @override
     * @inheritDoc
     */
    public function spread(callable $onFulfilled = null, callable $onRejected = null, callable $onCancel = null)
    {
        return $this->then(
            null,
            function($rejections) use($onRejected) {
                return $onRejected(...((array) $rejections));
            }
        );
    }

    /**
     * @override
     * @inheritDoc
     */
    public function success(callable $onSuccess)
    {
        return $this->then($onSuccess);
    }

    /**
     * @override
     * @inheritDoc
     */
    public function failure(callable $onFailure)
    {
        return $this->then(null, $onFailure);
    }

    /**
     * @override
     * @inheritDoc
     */
    public function abort(callable $onCancel)
    {
        return $this->then(null, null, $onCancel);
    }

    /**
     * @override
     * @inheritDoc
     */
    public function always(callable $onFulfilledOrRejected)

    {
        return $this->then(
            null,
            function($reason) use($onFulfilledOrRejected) {
                return Promise::doResolve($onFulfilledOrRejected())->then(function() use($reason) {
                    return new static($reason);
                });
            }
        );
    }

    /**
     * @override
     * @inheritDoc
     */
    public function isPending()
    {
        return false;
    }

    /**
     * @override
     * @inheritDoc
     */
    public function isFulfilled()
    {
        return false;
    }

    /**
     * @override
     * @inheritDoc
     */
    public function isRejected()
    {
        return true;
    }

    /**
     * @override
     * @inheritDoc
     */
    public function isCancelled()
    {
        return false;
    }

    /**
     * @override
     * @inheritDoc
     */
    public function getPromise()
    {
        return $this;
    }

    /**
     * @override
     * @inheritDoc
     */
    public function resolve($value = null)
    {
        return $this;
    }

    /**
     * @override
     * @inheritDoc
     */
    public function reject($reason = null)
    {
        return $this;
    }

    /**
     * @override
     * @inheritDoc
     */
    public function cancel($reason = null)
    {
        return $this;
    }

    /**
     * @see Promise::getValue
     */
    protected function getValue()
    {
        return null;
    }

    /**
     * @see Promise::getReason
     */
    protected function getReason()
    {
        return ($this->reason instanceof ThrowableProxy) ? $this->reason->toThrowable() : $this->reason;
    }

    /**
     * @param Error|Exception|string $reason
     * @throws Error|Exception
     */
    protected function throwError($reason)
    {
        if ($reason instanceof Error || $reason instanceof Exception)
        {
            throw $reason;
        }

        throw new RejectionException($reason);
    }
}


1			<?php
2
3			namespace Dazzle\Promise;
4
5			use Dazzle\Throwable\Exception\Logic\InvalidArgumentException;
6			use Dazzle\Throwable\Exception\Runtime\RejectionException;
7			use Dazzle\Throwable\ThrowableProxy;
8			use Error;
9			use Exception;
10
11			class PromiseRejected implements PromiseInterface
12			{
13			/**
14			* @var Error\|Exception\|ThrowableProxy\|string\|null
15			*/
16			protected $reason;
17
18			/**
19			* @param Error\|Exception\|string\|null
20			* @throws InvalidArgumentException
21			*/
22	179		public function __construct($reason = null)
23			{
24	179		if ($reason instanceof PromiseInterface)
25			{
26	1		throw new InvalidArgumentException(
27	1		'You cannot create PromiseRejected with a promise. Use Promise::doReject($promiseOrValue) instead.'
28			);
29			}
30
31	179		$this->reason = $reason;
32	179		}
33
34			/**
35			*
36			*/
37	111		public function __destruct()
38			{
39	111		unset($this->reason);
40	111		}
41
42			/**
43			* @override
44			* @inheritDoc
45			*/
46	109	View Code Duplication	public function then(callable $onFulfilled = null, callable $onRejected = null, callable $onCancel = null)
			0 ignored issues – show Duplication introduced 2017-06-24 20:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
47			{
48	109		if (null === $onRejected)
49			{
50	26		return $this;
51			}
52
53			try
54			{
55	106		return Promise::doResolve($onRejected($this->getReason()));
56			}
57	8		catch (Error $ex)
58			{
59			return new PromiseRejected($ex);
60			}
61	8		catch (Exception $ex)
62			{
63	8		return new PromiseRejected($ex);
64			}
65			}
66
67			/**
68			* @override
69			* @inheritDoc
70			*/
71	76	View Code Duplication	public function done(callable $onFulfilled = null, callable $onRejected = null, callable $onCancel = null)
			0 ignored issues – show Duplication introduced 2017-06-24 20:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
72			{
73	76		if (null === $onRejected)
74			{
75	22		$this->throwError($this->getReason());
			0 ignored issues – show Bug introduced 2017-06-24 20:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->getReason()` targeting `Dazzle\Promise\PromiseRejected::getReason()` can also be of type `null`; however, `Dazzle\Promise\PromiseRejected::throwError()` does only seem to accept `object<Exception>\|string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
76			}
77
78	58		$result = $onRejected($this->getReason());
79
80	51		if ($result instanceof self)
81			{
82	10		$this->throwError($result->getReason());
			0 ignored issues – show Bug introduced 2017-06-24 20:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$result->getReason()` targeting `Dazzle\Promise\PromiseRejected::getReason()` can also be of type `null`; however, `Dazzle\Promise\PromiseRejected::throwError()` does only seem to accept `object<Exception>\|string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
83			}
84
85	41		if ($result instanceof PromiseInterface)
86			{
87	2		$result->done();
88			}
89	41		}
90
91			/**
92			* @override
93			* @inheritDoc
94			*/
95	2		public function spread(callable $onFulfilled = null, callable $onRejected = null, callable $onCancel = null)
96			{
97	2		return $this->then(
98	2		null,
99			function($rejections) use($onRejected) {
100	2		return $onRejected(...((array) $rejections));
101	2		}
102			);
103			}
104
105			/**
106			* @override
107			* @inheritDoc
108			*/
109	1		public function success(callable $onSuccess)
110			{
111	1		return $this->then($onSuccess);
112			}
113
114			/**
115			* @override
116			* @inheritDoc
117			*/
118	1		public function failure(callable $onFailure)
119			{
120	1		return $this->then(null, $onFailure);
121			}
122
123			/**
124			* @override
125			* @inheritDoc
126			*/
127	1		public function abort(callable $onCancel)
128			{
129	1		return $this->then(null, null, $onCancel);
130			}
131
132			/**
133			* @override
134			* @inheritDoc
135			*/
136	5	View Code Duplication	public function always(callable $onFulfilledOrRejected)
			0 ignored issues – show Duplication introduced 2017-06-24 20:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
137			{
138	5		return $this->then(
139	5		null,
140			function($reason) use($onFulfilledOrRejected) {
141	4		return Promise::doResolve($onFulfilledOrRejected())->then(function() use($reason) {
142	3		return new static($reason);
143	4		});
144	5		}
145			);
146			}
147
148			/**
149			* @override
150			* @inheritDoc
151			*/
152	1		public function isPending()
153			{
154	1		return false;
155			}
156
157			/**
158			* @override
159			* @inheritDoc
160			*/
161	3		public function isFulfilled()
162			{
163	3		return false;
164			}
165
166			/**
167			* @override
168			* @inheritDoc
169			*/
170	3		public function isRejected()
171			{
172	3		return true;
173			}
174
175			/**
176			* @override
177			* @inheritDoc
178			*/
179	3		public function isCancelled()
180			{
181	3		return false;
182			}
183
184			/**
185			* @override
186			* @inheritDoc
187			*/
188			public function getPromise()
189			{
190			return $this;
191			}
192
193			/**
194			* @override
195			* @inheritDoc
196			*/
197			public function resolve($value = null)
198			{
199			return $this;
200			}
201
202			/**
203			* @override
204			* @inheritDoc
205			*/
206			public function reject($reason = null)
207			{
208			return $this;
209			}
210
211			/**
212			* @override
213			* @inheritDoc
214			*/
215	5		public function cancel($reason = null)
216			{
217	5		return $this;
218			}
219
220			/**
221			* @see Promise::getValue
222			*/
223			protected function getValue()
224			{
225			return null;
226			}
227
228			/**
229			* @see Promise::getReason
230			*/
231	156		protected function getReason()
232			{
233	156		return ($this->reason instanceof ThrowableProxy) ? $this->reason->toThrowable() : $this->reason;
234			}
235
236			/**
237			* @param Error\|Exception\|string $reason
238			* @throws Error\|Exception
239			*/
240	32		protected function throwError($reason)
241			{
242	32		if ($reason instanceof Error \|\| $reason instanceof Exception)
243			{
244	15		throw $reason;
245			}
246
247	17		throw new RejectionException($reason);
248			}
249			}
250

dazzle-php / promise

Issues (27)

Security Analysis no request data

src/Promise/PromiseRejected.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like