Dazzle\Http\Http\Driver\Reader\HttpReader

Complexity

Total Complexity

13

Size/Duplication

Total Lines	112
Duplicated Lines	48.21 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

88.24%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	2
A	__destruct()	0	5	1
B	readRequest()	27	27	5
B	readResponse()	27	27	5

<?php

namespace Dazzle\Http\Http\Driver\Reader;

use Dazzle\Throwable\Exception\Runtime\ReadException;
use Dazzle\Throwable\Exception\Logic\InvalidFormatException;
use Dazzle\Http\Http\Driver\Parser\HttpParser;
use Dazzle\Http\Http\Driver\Parser\HttpParserInterface;
use Dazzle\Util\Buffer\BufferInterface;
use GuzzleHttp\Psr7;
use Error;
use Exception;

class HttpReader implements HttpReaderInterface
{
    /**
     * @var int
     */
    const DEFAULT_MAX_SIZE = 0x4000; // 16 kB

    /**
     * @var int
     */
    const DEFAULT_START_LINE_LENGTH = 0x400; // 1 kB

    /**
     * @var string
     */
    const HTTP_EOM = "\r\n\r\n";

    /**
     * @var HttpParserInterface
     */
    protected $parser;

    /**
     * @var int
     */
    protected $maxFrameSize;

    /**
     * @param mixed[] $options
     */
    public function __construct($options = [])
    {
        $this->parser = new HttpParser();

        $this->maxFrameSize = isset($options['maxFrameSize'])
            ? (int) $options['maxFrameSize']
            : self::DEFAULT_MAX_SIZE;
    }

    /**
     *
     */
    public function __destruct()
    {
        unset($this->parser);
        unset($this->maxFrameSize);
    }

    /**
     * @override
     * @inheritDoc
     */
    public function readRequest(BufferInterface $buffer, $data)

This method seems to be duplicated in your project.

    {
        $buffer->push($data);

        if (($position = $buffer->search(self::HTTP_EOM)) === false)
        {
            if ($buffer->length() > $this->maxFrameSize)
            {
                throw new ReadException(
                    sprintf('Message start line exceeded maximum size of %d bytes.', $this->maxFrameSize)
                );
            }

            return null;
        }

        try
        {
            return $this->parser->parseRequest($buffer->drain());
        }
        catch (Error $ex)

Consider adding a comment why this CATCH block is empty.

        {}
        catch (Exception $ex)

Consider adding a comment why this CATCH block is empty.

        {}

        throw new InvalidFormatException('Could not parse start line.', 0, $ex);
    }

    /**
     * @override
     * @inheritDoc
     */
    public function readResponse(BufferInterface $buffer, $data)

This method seems to be duplicated in your project.

    {
        $buffer->push($data);

        if (($position = $buffer->search(self::HTTP_EOM)) === false)
        {
            if ($buffer->length() > $this->maxFrameSize)
            {
                throw new ReadException(
                    sprintf('Message start line exceeded maximum size of %d bytes.', $this->maxFrameSize)
                );
            }

            return null;
        }

        try
        {
            return $this->parser->parseResponse($buffer->drain());
        }
        catch (Error $ex)

Consider adding a comment why this CATCH block is empty.

        {}
        catch (Exception $ex)

Consider adding a comment why this CATCH block is empty.

        {}

        throw new InvalidFormatException('Could not parse start line.');
    }
}