Issues in Request.php (master) - Issues in master - dazzle-php/channel - Measure and Improve Code Quality continuously with Scrutinizer

Issues (41)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Channel/Extra/Request.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Dazzle\Channel\Extra;

use Dazzle\Channel\Protocol\ProtocolInterface;
use Dazzle\Channel\Channel;
use Dazzle\Channel\ChannelInterface;
use Dazzle\Promise\Promise;
use Dazzle\Promise\PromiseInterface;
use Dazzle\Util\Support\TimeSupport;
use Dazzle\Throwable\Exception\Runtime\TimeoutException;
use Dazzle\Throwable\Exception\System\TaskIncompleteException;
use Dazzle\Throwable\ThrowableProxy;
use Error;
use Exception;

class Request
{
    /**
     * @var ChannelInterface
     */
    protected $channel;

    /**
     * @var string
     */
    protected $name;

    /**
     * @var ProtocolInterface|string
     */
    protected $message;

    /**
     * @var float
     */
    protected $params;

    /**
     * @var int
     */
    protected $counter;

    /**
     * @param ChannelInterface $channel
     * @param string $name
     * @param string|ProtocolInterface $message
     * @param mixed[] $params
     */
    public function __construct($channel, $name, $message, $params = [])
    {
        $this->channel = $channel;
        $this->name = $name;
        $this->message = ($message instanceof ProtocolInterface) ? $message : $this->channel->createProtocol($message);
        $this->params = [

            'timeout'           => isset($params['timeout']) ? $params['timeout'] : 2.0,
            'retriesLimit'      => isset($params['retriesLimit']) ? $params['retriesLimit'] : 10,
            'retriesInterval'   => isset($params['retriesInterval']) ? $params['retriesInterval'] : 0.25
        ];
        $this->counter = 1;
        $this->message->setTimestamp(
            TimeSupport::now() + ($this->params['retriesInterval'] + $this->params['timeout']) * 1e3 * $this->params['retriesLimit'],
            true
        );
    }

    /**
     *
     */
    public function __destruct()
    {
        unset($this->channel);
        unset($this->name);
        unset($this->message);
        unset($this->params);
        unset($this->counter);
    }

    /**
     * Send the prepared request.
     *
     * @return PromiseInterface
     * @resolves mixed
     * @rejects Error|Exception|string|null
     * @cancels Error|Exception|string|null
     */
    public function __invoke()
    {
        return $this->send(new Promise());
    }

    /**
     * Send the prepared request.
     *
     * @return PromiseInterface
     * @resolves mixed
     * @rejects Error|Exception|string|null
     * @cancels Error|Exception|string|null
     */
    public function call()
    {
        return $this->send(new Promise());
    }

    /**
     * Send the request using passed Promise.
     *
     * @param PromiseInterface $promise
     * @return PromiseInterface
     */
    protected function send(PromiseInterface $promise)
    {
        if (!$promise->isPending())
        {
            return $promise;
        }

        $this->channel->send(
            $this->name,
            $this->message,
            Channel::MODE_STANDARD,
            function($value) use($promise) {
                $promise->resolve($value);
            },
            function($ex) use($promise) {
                $promise->reject($ex);
            },
            function($ex) use($promise) {
                $this->retryOrReset($promise, $ex);
            },
            $this->params['timeout']
        );

        return $promise;
    }

    /**
     * @param PromiseInterface $promise
     * @param Error|Exception|ThrowableProxy $ex
     */
    protected function retryOrReset(PromiseInterface $promise, $ex)
    {
        if ($ex instanceof TaskIncompleteException)
        {
            $this->counter = 1;
            $this->channel->getLoop()->onTick(function() use($promise) {
                $this->send($promise);
            });
            return;
        }

        $this->retry($promise);
    }

    /**
     * @param PromiseInterface $promise
     */
    private function retry(PromiseInterface $promise)
    {
        if ($this->counter >= $this->params['retriesLimit'])
        {
            $promise->reject(
                new ThrowableProxy(new TimeoutException('No response was received during specified timeout.'))
            );
        }
        else if ($this->params['retriesInterval'] > 0)
        {
            $this->counter++;
            $this->channel->getLoop()->addTimer($this->params['retriesInterval'], function() use($promise) {
                $this->send($promise);
            });
        }
        else
        {
            $this->counter++;
            $this->channel->getLoop()->onTick(function() use($promise) {
                $this->send($promise);
            });
        }
    }
}


1		<?php
2
3		namespace Dazzle\Channel\Extra;
4
5		use Dazzle\Channel\Protocol\ProtocolInterface;
6		use Dazzle\Channel\Channel;
7		use Dazzle\Channel\ChannelInterface;
8		use Dazzle\Promise\Promise;
9		use Dazzle\Promise\PromiseInterface;
10		use Dazzle\Util\Support\TimeSupport;
11		use Dazzle\Throwable\Exception\Runtime\TimeoutException;
12		use Dazzle\Throwable\Exception\System\TaskIncompleteException;
13		use Dazzle\Throwable\ThrowableProxy;
14		use Error;
15		use Exception;
16
17		class Request
18		{
19		/**
20		* @var ChannelInterface
21		*/
22		protected $channel;
23
24		/**
25		* @var string
26		*/
27		protected $name;
28
29		/**
30		* @var ProtocolInterface\|string
31		*/
32		protected $message;
33
34		/**
35		* @var float
36		*/
37		protected $params;
38
39		/**
40		* @var int
41		*/
42		protected $counter;
43
44		/**
45		* @param ChannelInterface $channel
46		* @param string $name
47		* @param string\|ProtocolInterface $message
48		* @param mixed[] $params
49		*/
50	17	public function __construct($channel, $name, $message, $params = [])
51		{
52	17	$this->channel = $channel;
53	17	$this->name = $name;
54	17	$this->message = ($message instanceof ProtocolInterface) ? $message : $this->channel->createProtocol($message);
55	17	$this->params = [
		0 ignored issues – show Documentation Bug introduced 2017-06-25 00:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `array('timeout' => isset...triesInterval'] : 0.25)` of type `array<string,,{"timeout..."retriesInterval":""}>` is incompatible with the declared type `double` of property `$params`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
56	17	'timeout' => isset($params['timeout']) ? $params['timeout'] : 2.0,
57	17	'retriesLimit' => isset($params['retriesLimit']) ? $params['retriesLimit'] : 10,
58	17	'retriesInterval' => isset($params['retriesInterval']) ? $params['retriesInterval'] : 0.25
59		];
60	17	$this->counter = 1;
61	17	$this->message->setTimestamp(
62	17	TimeSupport::now() + ($this->params['retriesInterval'] + $this->params['timeout']) * 1e3 * $this->params['retriesLimit'],
63	17	true
64		);
65	17	}
66
67		/**
68		*
69		*/
70	6	public function __destruct()
71		{
72	6	unset($this->channel);
73	6	unset($this->name);
74	6	unset($this->message);
75	6	unset($this->params);
76	6	unset($this->counter);
77	6	}
78
79		/**
80		* Send the prepared request.
81		*
82		* @return PromiseInterface
83		* @resolves mixed
84		* @rejects Error\|Exception\|string\|null
85		* @cancels Error\|Exception\|string\|null
86		*/
87	1	public function __invoke()
88		{
89	1	return $this->send(new Promise());
90		}
91
92		/**
93		* Send the prepared request.
94		*
95		* @return PromiseInterface
96		* @resolves mixed
97		* @rejects Error\|Exception\|string\|null
98		* @cancels Error\|Exception\|string\|null
99		*/
100	1	public function call()
101		{
102	1	return $this->send(new Promise());
103		}
104
105		/**
106		* Send the request using passed Promise.
107		*
108		* @param PromiseInterface $promise
109		* @return PromiseInterface
110		*/
111	5	protected function send(PromiseInterface $promise)
112		{
113	5	if (!$promise->isPending())
114		{
115	1	return $promise;
116		}
117
118	4	$this->channel->send(
119	4	$this->name,
120	4	$this->message,
121	4	Channel::MODE_STANDARD,
122		function($value) use($promise) {
123	1	$promise->resolve($value);
124	4	},
125		function($ex) use($promise) {
126	1	$promise->reject($ex);
127	4	},
128		function($ex) use($promise) {
129	1	$this->retryOrReset($promise, $ex);
130	4	},
131	4	$this->params['timeout']
132		);
133
134	4	return $promise;
135		}
136
137		/**
138		* @param PromiseInterface $promise
139		* @param Error\|Exception\|ThrowableProxy $ex
140		*/
141	4	protected function retryOrReset(PromiseInterface $promise, $ex)
142		{
143	4	if ($ex instanceof TaskIncompleteException)
144		{
145	1	$this->counter = 1;
146		$this->channel->getLoop()->onTick(function() use($promise) {
147	1	$this->send($promise);
148	1	});
149	1	return;
150		}
151
152	3	$this->retry($promise);
153	3	}
154
155		/**
156		* @param PromiseInterface $promise
157		*/
158	3	private function retry(PromiseInterface $promise)
159		{
160	3	if ($this->counter >= $this->params['retriesLimit'])
161		{
162	1	$promise->reject(
163	1	new ThrowableProxy(new TimeoutException('No response was received during specified timeout.'))
164		);
165		}
166	2	else if ($this->params['retriesInterval'] > 0)
167		{
168	1	$this->counter++;
169		$this->channel->getLoop()->addTimer($this->params['retriesInterval'], function() use($promise) {
170	1	$this->send($promise);
171	1	});
172		}
173		else
174		{
175	1	$this->counter++;
176	1	$this->channel->getLoop()->onTick(function() use($promise) {
177	1	$this->send($promise);
178	1	});
179		}
180	3	}
181		}
182

dazzle-php / channel

Issues (41)

Security Analysis no request data

src/Channel/Extra/Request.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like