Issues in ConnectionPool.php (master) - Issues in master - dazzle-php/channel-socket - Measure and Improve Code Quality continuously with Scrutinizer

Issues (30)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Channel-Socket/Connection/ConnectionPool.php (2 issues)

Labels

Documentation 2

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Dazzle\ChannelSocket\Connection;

/**
 * @codeCoverageIgnore
 */
class ConnectionPool
{
    /**
     * @var callable
     */
    protected $now;

    /**
     * @var mixed[]
     */
    protected $connectionPool;

    /**
     * @var float
     */
    protected $keepaliveOffset;

    /**
     * @var float
     */
    protected $heartbeatOffset;

    /**
     * @param float $offset
     */
    public function __construct($offset = 3600000.0, $heartbeat = 200.0)
    {
        $this->connectionPool = [];
        $this->keepaliveOffset = $offset;
        $this->heartbeatOffset = $heartbeat;
        $this->resetNow();
    }

    /**
     *
     */
    public function __destruct()
    {
        $this->connectionPool = [];
        unset($this->now);
    }

    /**
     *
     */
    public function erase()
    {
        $this->connectionPool = [];
    }

    /**
     * @return string[]
     */
    public function getConnected()
    {
        $conns = [];

        // there is no need for timestamp validation since messages to inactive clients are lost either way
        foreach ($this->connectionPool as $connID=>$conn)
        {
            $conns[] = $connID;
        }

        return $conns;
    }

    /**
     * @param Connection $conn
     * @return bool
     */
    public function setConnection(Connection $conn)
    {
        $id = $conn->id;

        if ($this->existsConnection($id))
        {
            $this->connectionPool[$id] = $this->register($conn, $this->connectionPool[$id]);
            return false;
        }
        else
        {
            $this->connectionPool[$id] = $this->register($conn);
            return true;
        }
    }

    /**
     * @param string $id
     * @return bool
     */
    public function removeConnection($id)
    {
        if ($this->existsConnection($id))
        {
            unset($this->connectionPool[$id]);
            return true;
        }

        return false;
    }

    /**
     * @param string $id
     * @return Connection
     */
    public function getConnection($id)
    {
        return $this->connectionPool[$id]['conn'];
    }

    /**
     * @param string $id
     * @return mixed[]
     */
    public function getData($id)
    {
        return $this->connectionPool[$id];
    }

    /**
     * @param string $id
     * @return bool
     */
    public function existsConnection($id)
    {
        return isset($this->connectionPool[$id]);
    }

    /**
     * @param string $id
     * @return bool
     */
    public function validateConnection($id)
    {
        if (!$this->existsConnection($id))
        {
            return false;
        }

        return $this->validateIn($this->generateValidationConst(), $this->getData($id));
    }

    /**
     * @return string[]
     */
    public function removeInvalid()
    {
        $toDel = [];
        $const = $this->generateValidationConst();

        foreach ($this->connectionPool as $cid=>$cdata)
        {
            if (!$this->validateIn($const, $cdata))
            {
                $toDel[] = $cid;
            }
        }

        foreach ($toDel as $cid)
        {
            unset($this->connectionPool[$cid]);
        }

        return $toDel;
    }

    /**
     * @param string $id
     * @param string $property
     * @param mixed $value
     */
    public function setConnectionProperty($id, $property, $value)
    {
        if (!$this->existsConnection($id))
        {
            $this->setConnection($id);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        $this->connectionPool[$id][$property] = $value;
    }

    /**
     * @param string $id
     * @return bool
     */
    public function isHeartbeatNeeded($id)
    {
        if (!$this->existsConnection($id))
        {
            return true;
        }

        return $this->validateOut($this->generateValidationConst(), $this->getData($id));
    }

    /**
     * @param $id
     * @return bool
     */
    public function registerHeartbeat($id)
    {
        if (!$this->existsConnection($id))
        {
            return false;
        }

        $this->connectionPool[$id]['timestampOut'] = $this->getNow() + $this->heartbeatOffset;

        return true;
    }

    /**
     * @return float
     */
    public function getNow()
    {
        $callback = $this->now;
        return $callback();
    }

    /**
     * @param callable $callback
     */
    public function setNow(callable $callback)
    {
        $this->now = $callback;
    }

    /**
     *
     */
    public function resetNow()
    {
        $this->now = function() {
            return round(microtime(true)*1000);
        };
    }

    /**
     * @param array $current
     * @return mixed[]
     */
    protected function register(Connection $conn, $current = [])
    {
        return [
            'conn'         => $conn,
            'timestampIn'  => $this->getNow() + $this->keepaliveOffset,
            'timestampOut' => isset($current['timestampOut']) ? $current['timestampOut'] : 0
        ];
    }

    /**
     * @param mixed[] $const
     * @param mixed[] $data
     * @return bool
     */
    protected function validateIn($const, $data)
    {
        return $data['timestampIn'] === 0 || ($const['timestampIn'] - $data['timestampIn']) <= 0;
    }

    /**
     * @param mixed[] $const
     * @param mixed[] $data
     * @return bool
     */
    protected function validateOut($const, $data)
    {
        return $data['timestampOut'] === 0 || ($const['timestampOut'] - $data['timestampOut']) > 0;
    }

    /**
     * @return mixed[]

     */
    protected function generateValidationConst()
    {
        $now = $this->getNow();

        return [
            'timestampIn'  => $now,
            'timestampOut' => $now
        ];
    }
}


1			<?php
2
3			namespace Dazzle\ChannelSocket\Connection;
4
5			/**
6			* @codeCoverageIgnore
7			*/
8			class ConnectionPool
9			{
10			/**
11			* @var callable
12			*/
13			protected $now;
14
15			/**
16			* @var mixed[]
17			*/
18			protected $connectionPool;
19
20			/**
21			* @var float
22			*/
23			protected $keepaliveOffset;
24
25			/**
26			* @var float
27			*/
28			protected $heartbeatOffset;
29
30			/**
31			* @param float $offset
32			*/
33			public function __construct($offset = 3600000.0, $heartbeat = 200.0)
34			{
35			$this->connectionPool = [];
36			$this->keepaliveOffset = $offset;
37			$this->heartbeatOffset = $heartbeat;
38			$this->resetNow();
39			}
40
41			/**
42			*
43			*/
44			public function __destruct()
45			{
46			$this->connectionPool = [];
47			unset($this->now);
48			}
49
50			/**
51			*
52			*/
53			public function erase()
54			{
55			$this->connectionPool = [];
56			}
57
58			/**
59			* @return string[]
60			*/
61			public function getConnected()
62			{
63			$conns = [];
64
65			// there is no need for timestamp validation since messages to inactive clients are lost either way
66			foreach ($this->connectionPool as $connID=>$conn)
67			{
68			$conns[] = $connID;
69			}
70
71			return $conns;
72			}
73
74			/**
75			* @param Connection $conn
76			* @return bool
77			*/
78			public function setConnection(Connection $conn)
79			{
80			$id = $conn->id;
81
82			if ($this->existsConnection($id))
83			{
84			$this->connectionPool[$id] = $this->register($conn, $this->connectionPool[$id]);
85			return false;
86			}
87			else
88			{
89			$this->connectionPool[$id] = $this->register($conn);
90			return true;
91			}
92			}
93
94			/**
95			* @param string $id
96			* @return bool
97			*/
98			public function removeConnection($id)
99			{
100			if ($this->existsConnection($id))
101			{
102			unset($this->connectionPool[$id]);
103			return true;
104			}
105
106			return false;
107			}
108
109			/**
110			* @param string $id
111			* @return Connection
112			*/
113			public function getConnection($id)
114			{
115			return $this->connectionPool[$id]['conn'];
116			}
117
118			/**
119			* @param string $id
120			* @return mixed[]
121			*/
122			public function getData($id)
123			{
124			return $this->connectionPool[$id];
125			}
126
127			/**
128			* @param string $id
129			* @return bool
130			*/
131			public function existsConnection($id)
132			{
133			return isset($this->connectionPool[$id]);
134			}
135
136			/**
137			* @param string $id
138			* @return bool
139			*/
140			public function validateConnection($id)
141			{
142			if (!$this->existsConnection($id))
143			{
144			return false;
145			}
146
147			return $this->validateIn($this->generateValidationConst(), $this->getData($id));
148			}
149
150			/**
151			* @return string[]
152			*/
153			public function removeInvalid()
154			{
155			$toDel = [];
156			$const = $this->generateValidationConst();
157
158			foreach ($this->connectionPool as $cid=>$cdata)
159			{
160			if (!$this->validateIn($const, $cdata))
161			{
162			$toDel[] = $cid;
163			}
164			}
165
166			foreach ($toDel as $cid)
167			{
168			unset($this->connectionPool[$cid]);
169			}
170
171			return $toDel;
172			}
173
174			/**
175			* @param string $id
176			* @param string $property
177			* @param mixed $value
178			*/
179			public function setConnectionProperty($id, $property, $value)
180			{
181			if (!$this->existsConnection($id))
182			{
183			$this->setConnection($id);
			0 ignored issues – show Documentation introduced 2017-06-25 08:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$id` is of type `string`, but the function expects a `object<Dazzle\ChannelSoc...\Connection\Connection>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
184			}
185
186			$this->connectionPool[$id][$property] = $value;
187			}
188
189			/**
190			* @param string $id
191			* @return bool
192			*/
193			public function isHeartbeatNeeded($id)
194			{
195			if (!$this->existsConnection($id))
196			{
197			return true;
198			}
199
200			return $this->validateOut($this->generateValidationConst(), $this->getData($id));
201			}
202
203			/**
204			* @param $id
205			* @return bool
206			*/
207			public function registerHeartbeat($id)
208			{
209			if (!$this->existsConnection($id))
210			{
211			return false;
212			}
213
214			$this->connectionPool[$id]['timestampOut'] = $this->getNow() + $this->heartbeatOffset;
215
216			return true;
217			}
218
219			/**
220			* @return float
221			*/
222			public function getNow()
223			{
224			$callback = $this->now;
225			return $callback();
226			}
227
228			/**
229			* @param callable $callback
230			*/
231			public function setNow(callable $callback)
232			{
233			$this->now = $callback;
234			}
235
236			/**
237			*
238			*/
239			public function resetNow()
240			{
241			$this->now = function() {
242			return round(microtime(true)*1000);
243			};
244			}
245
246			/**
247			* @param array $current
248			* @return mixed[]
249			*/
250			protected function register(Connection $conn, $current = [])
251			{
252			return [
253			'conn' => $conn,
254			'timestampIn' => $this->getNow() + $this->keepaliveOffset,
255			'timestampOut' => isset($current['timestampOut']) ? $current['timestampOut'] : 0
256			];
257			}
258
259			/**
260			* @param mixed[] $const
261			* @param mixed[] $data
262			* @return bool
263			*/
264			protected function validateIn($const, $data)
265			{
266			return $data['timestampIn'] === 0 \|\| ($const['timestampIn'] - $data['timestampIn']) <= 0;
267			}
268
269			/**
270			* @param mixed[] $const
271			* @param mixed[] $data
272			* @return bool
273			*/
274			protected function validateOut($const, $data)
275			{
276			return $data['timestampOut'] === 0 \|\| ($const['timestampOut'] - $data['timestampOut']) > 0;
277			}
278
279			/**
280			* @return mixed[]
			0 ignored issues – show Documentation introduced 2017-06-25 08:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `array<string,double>`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
281			*/
282			protected function generateValidationConst()
283			{
284			$now = $this->getNow();
285
286			return [
287			'timestampIn' => $now,
288			'timestampOut' => $now
289			];
290			}
291			}
292

dazzle-php / channel-socket

Issues (30)

Security Analysis no request data

src/Channel-Socket/Connection/ConnectionPool.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like