Issues in Author.php - All Issues - Inspection of "Merge pull request #4 from davispeixoto/BC-4" - davispeixoto/blog-core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d32758...1d7877 )

by Davis

created 2017-07-29 16:30 UTC

src/BlogCore/Entity/Author.php (2 issues)

Showing only issues like (Show All)

Check that parameter names are not overwritten

Coding Style Informational

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Created by PhpStorm.
 * User: davis
 * Date: 7/23/17
 * Time: 3:05 AM
 */

namespace DavisPeixoto\BlogCore\Entity;


use DateTime;
use Ramsey\Uuid\UuidInterface;
use stdClass;

/**
 * Class Author
 * @package DavisPeixoto\BlogCore\Entity
 */
class Author extends stdClass
{
    /**
     * @var UuidInterface
     */
    private $authorId;

    /**
     * @var string
     */
    private $name;

    /**
     * @var string
     */
    private $email;

    /**
     * @var string
     */
    private $bio;

    /**
     * @var DateTime|null
     */
    private $birthdate;

    /**
     * Author constructor.
     * @param UuidInterface $authorId
     * @param string $name
     * @param string $email
     * @param string $bio
     * @param DateTime|null $birthdate
     */
    public function __construct(UuidInterface $authorId, $name, $email, $bio, DateTime $birthdate = null)
    {
        $this->authorId = $authorId;
        $this->name = $name;
        $this->email = $email;
        $this->bio = $bio;
        $this->birthdate = $birthdate;
    }

    /**
     * @codeCoverageIgnore
     * @return UuidInterface
     */
    public function getAuthorId(): UuidInterface
    {
        return $this->authorId;
    }

    /**
     * @codeCoverageIgnore
     * @param UuidInterface $authorId
     */
    public function setAuthorId(UuidInterface $authorId)
    {
        $this->authorId = $authorId;
    }

    /**
     * @codeCoverageIgnore
     * @return string
     */
    public function getName(): string
    {
        return $this->name;
    }

    /**
     * @codeCoverageIgnore
     * @param string $name
     */
    public function setName(string $name)
    {
        $this->name = $name;
    }

    /**
     * @codeCoverageIgnore
     * @return string
     */
    public function getEmail(): string
    {
        return $this->email;
    }

    /**
     * @param string $email
     */
    public function setEmail(string $email)
    {
        $email = filter_var($email, FILTER_SANITIZE_EMAIL);

        $email = filter_var($email, FILTER_VALIDATE_EMAIL);

        if ($email !== false) {
            $this->email = $email;
        }
    }

    /**
     * @codeCoverageIgnore
     * @return string
     */
    public function getBio(): string
    {
        return $this->bio;
    }

    /**
     * @codeCoverageIgnore
     * @param string $bio
     */
    public function setBio(string $bio)
    {
        $this->bio = $bio;
    }

    /**
     * @codeCoverageIgnore
     * @return DateTime|null
     */
    public function getBirthdate()
    {
        return $this->birthdate;
    }

    /**
     * @codeCoverageIgnore
     * @param DateTime|null $birthdate
     */
    public function setBirthdate(DateTime $birthdate = null)
    {
        $this->birthdate = $birthdate;
    }
}


1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: davis
5		* Date: 7/23/17
6		* Time: 3:05 AM
7		*/
8
9		namespace DavisPeixoto\BlogCore\Entity;
10
11
12		use DateTime;
13		use Ramsey\Uuid\UuidInterface;
14		use stdClass;
15
16		/**
17		* Class Author
18		* @package DavisPeixoto\BlogCore\Entity
19		*/
20		class Author extends stdClass
21		{
22		/**
23		* @var UuidInterface
24		*/
25		private $authorId;
26
27		/**
28		* @var string
29		*/
30		private $name;
31
32		/**
33		* @var string
34		*/
35		private $email;
36
37		/**
38		* @var string
39		*/
40		private $bio;
41
42		/**
43		* @var DateTime\|null
44		*/
45		private $birthdate;
46
47		/**
48		* Author constructor.
49		* @param UuidInterface $authorId
50		* @param string $name
51		* @param string $email
52		* @param string $bio
53		* @param DateTime\|null $birthdate
54		*/
55	34	public function __construct(UuidInterface $authorId, $name, $email, $bio, DateTime $birthdate = null)
56		{
57	34	$this->authorId = $authorId;
58	34	$this->name = $name;
59	34	$this->email = $email;
60	34	$this->bio = $bio;
61	34	$this->birthdate = $birthdate;
62	34	}
63
64		/**
65		* @codeCoverageIgnore
66		* @return UuidInterface
67		*/
68		public function getAuthorId(): UuidInterface
69		{
70		return $this->authorId;
71		}
72
73		/**
74		* @codeCoverageIgnore
75		* @param UuidInterface $authorId
76		*/
77		public function setAuthorId(UuidInterface $authorId)
78		{
79		$this->authorId = $authorId;
80		}
81
82		/**
83		* @codeCoverageIgnore
84		* @return string
85		*/
86		public function getName(): string
87		{
88		return $this->name;
89		}
90
91		/**
92		* @codeCoverageIgnore
93		* @param string $name
94		*/
95		public function setName(string $name)
96		{
97		$this->name = $name;
98		}
99
100		/**
101		* @codeCoverageIgnore
102		* @return string
103		*/
104		public function getEmail(): string
105		{
106		return $this->email;
107		}
108
109		/**
110		* @param string $email
111		*/
112	3	public function setEmail(string $email)
113		{
114	3	$email = filter_var($email, FILTER_SANITIZE_EMAIL);
		0 ignored issues – show Coding Style introduced 2017-07-24 02:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different name than the parameter `$email`. This often makes code more readable. Loading history...
115	3	$email = filter_var($email, FILTER_VALIDATE_EMAIL);
		0 ignored issues – show Coding Style introduced 2017-07-24 02:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different name than the parameter `$email`. This often makes code more readable. Loading history...
116	3	if ($email !== false) {
117	1	$this->email = $email;
118		}
119	3	}
120
121		/**
122		* @codeCoverageIgnore
123		* @return string
124		*/
125		public function getBio(): string
126		{
127		return $this->bio;
128		}
129
130		/**
131		* @codeCoverageIgnore
132		* @param string $bio
133		*/
134		public function setBio(string $bio)
135		{
136		$this->bio = $bio;
137		}
138
139		/**
140		* @codeCoverageIgnore
141		* @return DateTime\|null
142		*/
143		public function getBirthdate()
144		{
145		return $this->birthdate;
146		}
147
148		/**
149		* @codeCoverageIgnore
150		* @param DateTime\|null $birthdate
151		*/
152		public function setBirthdate(DateTime $birthdate = null)
153		{
154		$this->birthdate = $birthdate;
155		}
156		}
157

davispeixoto / blog-core

Push — master ( d32758...1d7877 )

src/BlogCore/Entity/Author.php (2 issues)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like