AbstractListService::run() - Code Metrics - Inspection of "BC-9 - Refactor services design and its tests to u..." - davispeixoto/blog-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#9)

by Davis

created 2017-07-30 23:37 UTC

AbstractListService::run() A

↳ Parent: AbstractListService

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	10
Ratio	100 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	10
loc	10
ccs	5
cts	5
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	0
crap	2

<?php
/**
 * Created by PhpStorm.
 * User: davis
 * Date: 7/30/17
 * Time: 7:21 PM
 */

namespace DavisPeixoto\BlogCore\Service;


use DavisPeixoto\BlogCore\Interfaces\RepositoryInterface;
use DavisPeixoto\BlogCore\Interfaces\ServiceInterface;
use Exception;
use Psr\Log\LoggerInterface;
use stdClass;

/**
 * Class AbstractListService
 * @package DavisPeixoto\BlogCore\Service
 */
abstract class AbstractListService implements ServiceInterface

{
    /**
     * @var RepositoryInterface
     */
    protected $repository;

    /**
     * @var array
     */
    protected $filters;

    /**
     * @var LoggerInterface
     */
    protected $logger;

    /**
     * AbstractListService constructor.
     * @param RepositoryInterface $repository
     * @param array $filters
     * @param LoggerInterface $logger
     */
    public function __construct(RepositoryInterface $repository, array $filters, LoggerInterface $logger)
    {
        $this->repository = $repository;
        $this->filters = $filters;
        $this->logger = $logger;
    }

    /**
     * @return stdClass[]
     */
    public function run(): array
    {
        try {
            return $this->repository->getList($this->filters);
        } catch (Exception $e) {
            $this->logger->error($e->getMessage());
        }

        return [];
    }
}


1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: davis
5			* Date: 7/30/17
6			* Time: 7:21 PM
7			*/
8
9			namespace DavisPeixoto\BlogCore\Service;
10
11
12			use DavisPeixoto\BlogCore\Interfaces\RepositoryInterface;
13			use DavisPeixoto\BlogCore\Interfaces\ServiceInterface;
14			use Exception;
15			use Psr\Log\LoggerInterface;
16			use stdClass;
17
18			/**
19			* Class AbstractListService
20			* @package DavisPeixoto\BlogCore\Service
21			*/
22		View Code Duplication	abstract class AbstractListService implements ServiceInterface
			1 ignored issue – show Duplication introduced 2017-07-30 23:39 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23			{
24			/**
25			* @var RepositoryInterface
26			*/
27			protected $repository;
28
29			/**
30			* @var array
31			*/
32			protected $filters;
33
34			/**
35			* @var LoggerInterface
36			*/
37			protected $logger;
38
39			/**
40			* AbstractListService constructor.
41			* @param RepositoryInterface $repository
42			* @param array $filters
43			* @param LoggerInterface $logger
44			*/
45	8		public function __construct(RepositoryInterface $repository, array $filters, LoggerInterface $logger)
46			{
47	8		$this->repository = $repository;
48	8		$this->filters = $filters;
49	8		$this->logger = $logger;
50	8		}
51
52			/**
53			* @return stdClass[]
54			*/
55	8		public function run(): array
56			{
57			try {
58	8		return $this->repository->getList($this->filters);
59	4		} catch (Exception $e) {
60	4		$this->logger->error($e->getMessage());
61			}
62
63	4		return [];
64			}
65			}
66

davispeixoto / blog-core

Pull Request — master (#9)

AbstractListService::run() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like