ConstantWriter::writeElements() - Code Metrics - davidfuhr/php-plantumlwriter - Measure and Improve Code Quality continuously with Scrutinizer

ConstantWriter::writeElements() A
last analyzed 2016-03-28 17:18 UTC

↳ Parent: ConstantWriter

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	2

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	14
ccs	9
cts	9
cp	1
rs	9.4285
cc	2
eloc	7
nc	2
nop	1
crap	2

<?php

namespace Flagbit\Plantuml\TokenReflection;

use TokenReflection\IReflectionConstant;

class ConstantWriter extends WriterAbstract
{
    /**
     * @param IReflectionConstant $constant
     *
     * @return string
     */
    public function writeElement(IReflectionConstant $constant)
    {
        return $this->formatLine('+{static}' . $constant->getName() . ' = ' . $this->formatValue($constant->getValue()));
    }

    /**
     * @param IReflectionConstant[] $constants
     *
     * @return string
     */
    public function writeElements(array $constants)
    {
        // see https://bugs.php.net/bug.php?id=50688
        @usort($constants, function(IReflectionConstant $a, IReflectionConstant $b) {
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            return strnatcasecmp($a->getName(), $b->getName());
        });

        $constantsString = '';
        foreach ($constants as $constant) {
            /** @var $property IReflectionConstant */
            $constantsString .= $this->writeElement($constant);
        }
        return $constantsString;
    }
}


1		<?php
2
3		namespace Flagbit\Plantuml\TokenReflection;
4
5		use TokenReflection\IReflectionConstant;
6
7		class ConstantWriter extends WriterAbstract
8		{
9		/**
10		* @param IReflectionConstant $constant
11		*
12		* @return string
13		*/
14	4	public function writeElement(IReflectionConstant $constant)
15		{
16	4	return $this->formatLine('+{static}' . $constant->getName() . ' = ' . $this->formatValue($constant->getValue()));
17		}
18
19		/**
20		* @param IReflectionConstant[] $constants
21		*
22		* @return string
23		*/
24	11	public function writeElements(array $constants)
25		{
26		// see https://bugs.php.net/bug.php?id=50688
27	11	@usort($constants, function(IReflectionConstant $a, IReflectionConstant $b) {
		0 ignored issues – show Security Best Practice introduced 2016-03-28 17:18 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
28	3	return strnatcasecmp($a->getName(), $b->getName());
29	11	});
30
31	11	$constantsString = '';
32	11	foreach ($constants as $constant) {
33		/** @var $property IReflectionConstant */
34	3	$constantsString .= $this->writeElement($constant);
35	11	}
36	11	return $constantsString;
37		}
38		}
39

davidfuhr / php-plantumlwriter

ConstantWriter::writeElements() A last analyzed 2016-03-28 17:18 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ConstantWriter::writeElements() A
last analyzed 2016-03-28 17:18 UTC