davide-casiraghi / php-responsive-random-quote

src/QuoteFactory.php

<?php

namespace DavideCasiraghi\PhpResponsiveRandomQuote;

use DavideCasiraghi\PhpResponsiveRandomQuote\Models\Quote;

class QuoteFactory
{
    /***************************************************************************/

    /**
     * Return a random quote.
     *
     * @return \DavideCasiraghi\PhpResponsiveRandomQuote\Models\Quote
     */
    public function getRandomQuote()
    {
        return Quote::inRandomOrder()->first();
    }

    /***************************************************************************/

    /**
     * Return the quote of the day.
     *
     * @return \DavideCasiraghi\PhpResponsiveRandomQuote\Models\Quote
     */
    public function getQuoteOfTheDay()
    {
        $numberOfQuotesInDB = Quote::count();
        $quoteOfTheDayNumber = rand(1, $numberOfQuotesInDB);

It seems like $numberOfQuotesInDB can also be of type Illuminate\Database\Eloquent\Builder; however, parameter $max of rand() does only seem to accept integer, maybe add an additional type check?

        $quotes = Quote::all();

        return  $quotes[$quoteOfTheDayNumber];
    }

    public function setCookie(Request $request)

The parameter $request is not used and could be removed.

The type DavideCasiraghi\PhpResponsiveRandomQuote\Request was not found. Did you mean Request? If so, make sure to prefix the type with \.

    {
        $minutes = 60;
        $response = new Response('Set Cookie');

The type DavideCasiraghi\PhpResponsiveRandomQuote\Response was not found. Did you mean Response? If so, make sure to prefix the type with \.

        $response->withCookie(cookie('quoteOfTheDayId', 'MyValue', $minutes));

        return $response;
    }

    public function getCookie(Request $request)
    {
        $value = $request->cookie('quoteOfTheDayId');
        echo $value;
    }
}