App\Services\EventService::getMonthlySelectOptions()

Complexity

Conditions	3
Paths	4

Size

Total Lines	72
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	37
CRAP Score	3.0001

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function getMonthlySelectOptions(string $date): string
    {
        $monthlySelectOptions = [];
        $date = implode('-', array_reverse(explode('/', $date)));  // Our YYYY-MM-DD date string
        $unixTimestamp = strtotime($date);  // Convert the date string into a unix timestamp.
        $dayOfWeekString = date('l', $unixTimestamp); // Monday | Tuesday | Wednesday | ..

        // Add option: Same day number.
        // eg. "the 28th day of the month"
        $dateArray = explode('-', $date);
        $dayNumber = ltrim($dateArray[2], '0'); // remove the 0 in front of a day number eg. 02/10/2018

        $format = __('ordinalDays.the_' . ($dayNumber) . '_x_of_the_month');
        $repeatText = sprintf($format, 'day');

It seems like $format can also be of type array and array; however, parameter $format of sprintf() does only seem to accept string, maybe add an additional type check?

        array_push($monthlySelectOptions, [
            'value' => '0|' . $dayNumber,
            'text' => $repeatText,
        ]);

        // Add option: Same weekday/week of the month.
        // eg. the "1st Monday" 1|1|1 (first week, monday)
        $dayOfWeekValue = date('N', $unixTimestamp); // 1 (for Monday) through 7 (for Sunday)
        $weekOfTheMonth = DateHelpers::monthWeekNumber($date, $dayOfWeekValue); // 1 | 2 | 3 | 4 | 5

        $format = __('ordinalDays.the_' . ($weekOfTheMonth) . '_x_of_the_month');
        $repeatText = sprintf($format, $dayOfWeekString);

        array_push($monthlySelectOptions, [
            'value' => '1|' . $weekOfTheMonth . '|' . $dayOfWeekValue,
            'text' => $repeatText,
        ]);

        // Add option: Same day of the month (from the end).
        // eg. "the 3rd to last day of the month" (0 if last day, 1 if 2nd to last day, , 2 if 3rd to last day)
        $dayOfMonthFromTheEnd = DateHelpers::dayOfMonthFromTheEnd($unixTimestamp); // 1 | 2 | 3 | 4 | 5

        $format = __('ordinalDays.the_'.($dayOfMonthFromTheEnd + 1).'_to_last_x_of_the_month');
        $repeatText = sprintf($format, 'day');

        array_push($monthlySelectOptions, [
            'value' => '2|'.$dayOfMonthFromTheEnd,
            'text' => $repeatText,
        ]);

        // Add option: Same weekday/week of the month (from the end).
        // eg. the last Friday - (0 if last Friday, 1 if the 2nd to last Friday, 2 if the 3nd to last Friday)
        $monthWeekNumberFromTheEnd = DateHelpers::monthWeekNumberFromTheEnd($unixTimestamp); // 1 | 2 | 3 | 4 | 5

        if ($monthWeekNumberFromTheEnd == 1) {
            $weekValue = 0;
        } else {
            $weekValue = $monthWeekNumberFromTheEnd - 1;
        }

        $format = __('ordinalDays.the_' . ($monthWeekNumberFromTheEnd) . '_to_last_x_of_the_month');
        $repeatText = sprintf($format, $dayOfWeekString);

        array_push($monthlySelectOptions, [
            'value' => '3|' . $weekValue . '|' . $dayOfWeekValue,
            'text' => $repeatText,
        ]);

        // GENERATE the HTML to return
        $selectTitle = __('general.select_repeat_monthly_kind');
        $onMonthlyKindSelect = "<select name='on_monthly_kind' id='on_monthly_kind' class='selectpicker' title='".$selectTitle."'>";

Are you sure $selectTitle of type array|string can be used in concatenation?

        foreach ($monthlySelectOptions as $key => $monthlySelectOption) {
            $onMonthlyKindSelect .= "<option value='".$monthlySelectOption['value']."'>".$monthlySelectOption['text'].'</option>';
        }
        $onMonthlyKindSelect .= '</select>';

        return $onMonthlyKindSelect;
    }