DavideCasiraghi\LaravelQuickMenus\Http\Middleware\Admin

Complexity

Total Complexity

4

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Test Coverage

Coverage

71.43%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	handle()	0	17	4

<?php

namespace DavideCasiraghi\LaravelQuickMenus\Http\Middleware;

use Closure;

class Admin
{
    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Closure  $next
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        $user = \Auth::user();

        // If user is not logged
        if (! $user) {
            return redirect('/')->with('message', 'You have not admin access');
        }

        // If user is logged and admin/superadmin
        //if (($user->isAdmin() || $user->isSuperAdmin()) == 1) {
        if (($user->group == 2) || ($user->group == 1)) {

Accessing group on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            return $next($request);
        }

        // Return to homepage if user il logged but not admin
        return redirect('/')->with('message', 'You have not admin access');
    }
}