Continent::getContinents() - Code Metrics - Inspection of "restored original funcion getCountries" - davide-casiraghi/laravel-events-calendar - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fe1366...05ac62 )

by Davide

created 2019-10-07 08:53 UTC

Continent::getContinents() A

↳ Parent: Continent

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2.0116

Importance

Changes

Metric	Value
eloc	7
dl	0
loc	17
ccs	6
cts	7
cp	0.8571
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2.0116

<?php

namespace DavideCasiraghi\LaravelEventsCalendar\Models;

use Illuminate\Support\Facades\Cache;
use Illuminate\Database\Eloquent\Model;

class Continent extends Model
{
    /***************************************************************************/
    /**
     * The table associated with the model.
     *
     * @var string
     */
    protected $table = 'continents';

    /***************************************************************************/

    protected $fillable = [
        'name', 'code',
    ];

    /***************************************************************************/

    /**
     * Return all the continents ordered by name.
     *
     * @return \DavideCasiraghi\LaravelEventsCalendar\Models\Continent
     */
    public static function getContinents($country_id)
    {
        // All the contients
        if ($country_id == null){
            $minutes = 15;
            $ret = Cache::remember('continents_list', $minutes, function () {
                return self::orderBy('name')->pluck('name', 'id');
            });
        }
        // The contient of a specified country
        else {
            $ret = self::firstWhere('id', $country_id);
                        //where('id', $country_id)->first();
                        //->pluck('name', 'id');
        }
            
        return $ret;
    }
}


1		<?php
2
3		namespace DavideCasiraghi\LaravelEventsCalendar\Models;
4
5		use Illuminate\Support\Facades\Cache;
6		use Illuminate\Database\Eloquent\Model;
7
8		class Continent extends Model
9		{
10		/***************************************************************************/
11		/**
12		* The table associated with the model.
13		*
14		* @var string
15		*/
16		protected $table = 'continents';
17
18		/***************************************************************************/
19
20		protected $fillable = [
21		'name', 'code',
22		];
23
24		/***************************************************************************/
25
26		/**
27		* Return all the continents ordered by name.
28		*
29		* @return \DavideCasiraghi\LaravelEventsCalendar\Models\Continent
30		*/
31	4	public static function getContinents($country_id)
32		{
33		// All the contients
34	4	if ($country_id == null){
35	4	$minutes = 15;
36		$ret = Cache::remember('continents_list', $minutes, function () {
37	4	return self::orderBy('name')->pluck('name', 'id');
38	4	});
39		}
40		// The contient of a specified country
41		else {
42		$ret = self::firstWhere('id', $country_id);
43		//where('id', $country_id)->first();
44		//->pluck('name', 'id');
45		}
46
47	4	return $ret;
48		}
49		}
50

davide-casiraghi / laravel-events-calendar

Push — master ( fe1366...05ac62 )

Continent::getContinents() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like