DavideCasiraghi\LaravelEventsCalendar\Models\User

Complexity

Total Complexity

14

Size/Duplication

Total Lines	121
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	loggedAsSuperAdmin()	0	9	3
A	isAdmin()	0	6	2
A	loggedAsAdmin()	0	9	3
A	getUserGroupString()	0	17	4
A	isSuperAdmin()	0	6	2

<?php

namespace DavideCasiraghi\LaravelEventsCalendar\Models;

use Illuminate\Support\Facades\Auth;
use Illuminate\Notifications\Notifiable;
use Illuminate\Foundation\Auth\User as Authenticatable;

class User extends Authenticatable
{
    /***************************************************************************/
    /**
     * The table associated with the model.
     *
     * @var string
     */
    protected $table = 'users';

    /***************************************************************************/

    use Notifiable;

The trait Illuminate\Notifications\Notifiable requires some properties which are not provided by DavideCasiraghi\LaravelEventsCalendar\Models\User: $email, $phone_number

    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = [
        'name', 'email', 'password', 'group', 'country_id', 'description', 'status', 'activation_code', 'accept_terms',
    ];

    /**
     * The attributes that should be hidden for arrays.
     *
     * @var array
     */
    protected $hidden = [
        'password', 'remember_token',
    ];

    /*
        To recognize admin - https://laracasts.com/discuss/channels/laravel/user-admin-authentication
    */
    protected $casts = [
        'group' => 'int',
    ];

    public function isSuperAdmin()
    {
        if ($this->group == 1) {

The property group does not seem to exist on DavideCasiraghi\LaravelEventsCalendar\Models\User. Are you sure there is no database migration missing?

            return true;
        } else {
            return false;
        }
    }

    public function isAdmin()
    {
        if ($this->group == 2) {

The property group does not seem to exist on DavideCasiraghi\LaravelEventsCalendar\Models\User. Are you sure there is no database migration missing?

            return true;
        } else {
            return false;
        }
    }

    /***************************************************************************/

    /**
     * Return the user group string.
     *
     * @param  \App\User  $post

The type App\User was not found. Maybe you did not declare it correctly or list all dependencies?

     * @return string $ret - the user role description string
     */
    public static function getUserGroupString($group_id)
    {
        switch ($group_id) {
             case null:
                 $ret = 'Manager';
                 break;

             case 2:
                 $ret = 'Administrator';
                 break;

             case 1:
                 $ret = 'Super Administrator';
                 break;
         }

        return $ret;

The variable $ret does not seem to be defined for all execution paths leading up to this point.

    }

    /***************************************************************************/

    /**
     * Return true if the user is logged as super admin.
     *
     * @param  none
     * @return string $ret - true if the user is super admin
     */
    public static function loggedAsSuperAdmin()
    {
        $user = Auth::user();
        if (! $user) {
            return false;
        } elseif ($user->group == 1) {

Accessing group on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            return true;
        } else {
            return false;
        }
    }

    /***************************************************************************/

    /**
     * Return true if the user is logged as admin.
     *
     * @param  none
     * @return string $ret - true if the user is admin
     */
    public static function loggedAsAdmin()
    {
        $user = Auth::user();
        if (! $user) {
            return false;
        } elseif ($user->group == 2) {

Accessing group on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            return true;
        } else {
            return false;
        }
    }
}