DavideCasiraghi\LaravelEventsCalendar\Models\Teacher

Complexity

Total Complexity

7

Size/Duplication

Total Lines	103
Duplicated Lines	0 %

Test Coverage

Coverage

72.97%

Importance

Changes	5
Bugs	2	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	events()	0	3	1
A	eventsByTeacher()	0	13	1
A	user()	0	3	1
A	preSave()	0	35	4

<?php

namespace DavideCasiraghi\LaravelEventsCalendar\Models;

use DavideCasiraghi\LaravelEventsCalendar\Facades\LaravelEventsCalendar;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Http\Request; // to remove
use Illuminate\Support\Str;

class Teacher extends Model
{
    /***************************************************************************/
    /**
     * The table associated with the model.
     *
     * @var string
     */
    protected $table = 'teachers';

    /***************************************************************************/

    protected $fillable = [
        'name', 'bio', 'country_id', 'year_starting_practice', 'year_starting_teach', 'significant_teachers', 'profile_picture', 'website', 'facebook', 'created_by', 'slug',
    ];

    /***************************************************************************/

    /**
     * Get the user that owns the event. eg. $teacher->user.
     */
    public function user()
    {
        return $this->belongsTo('\Illuminate\Foundation\Auth\User', 'created_by');
    }

    /***************************************************************************/

    /**
     * Get the events for the teacher.
     */
    public function events()
    {
        return $this->belongsToMany('DavideCasiraghi\LaravelEventsCalendar\Models\Event', 'event_has_teachers', 'teacher_id', 'event_id');
    }

    /***************************************************************************/

    /**
     * Get the events where this teacher is going to teach to.
     *
     * @param  \DavideCasiraghi\LaravelEventsCalendar\Models\Teacher  $teacher
     * @return \Illuminate\Http\Response
     */
    public static function eventsByTeacher($teacher, $lastestEventsRepetitionsQuery)
    {
        $ret = $teacher->events()
                         ->select('events.title', 'events.category_id', 'events.slug', 'event_venues.name AS venue_name', 'countries.name AS country', 'event_venues.city AS city', 'events.sc_teachers_names', 'event_repetitions.start_repeat', 'event_repetitions.end_repeat')
                         ->join('event_venues', 'event_venues.id', '=', 'events.venue_id')
                         ->join('countries', 'countries.id', '=', 'event_venues.country_id')
                         ->joinSub($lastestEventsRepetitionsQuery, 'event_repetitions', function ($join) {
                             $join->on('events.id', '=', 'event_repetitions.event_id');
                         })
                         ->orderBy('event_repetitions.start_repeat', 'asc')
                         ->get();

        return $ret;
    }

    /***************************************************************************/

    /**
     * Prepare the record to be saved on DB.
     *
     * @param  array  $requestArray
     * @param  \Illuminate\Http\UploadedFile  $profilePicture
     * @return void
     */
    public function preSave(array $requestArray, $profilePicture): void
    {
        $requestArray['website'];
        
        $this->name = $requestArray['name'];
        $this->bio = clean($requestArray['bio']);
        $this->country_id = $requestArray['country_id'];
        $this->year_starting_practice = $requestArray['year_starting_practice'];;
        $this->year_starting_teach = $requestArray['year_starting_teach'];;
        $this->significant_teachers = $requestArray['significant_teachers'];;

        // Teacher profile picture upload
        if (! empty($profilePicture)) {
            $imageFile = $profilePicture;
            $imageName = $imageFile->hashName();
            $imageSubdir = 'teachers_profile';
            $imageWidth = 968;
            $thumbWidth = 300;

            LaravelEventsCalendar::uploadImageOnServer($imageFile, $imageName, $imageSubdir, $imageWidth, $thumbWidth);

The method uploadImageOnServer() does not exist on DavideCasiraghi\LaravelEventsCalendar\Facades\LaravelEventsCalendar. Since you implemented __callStatic, consider adding a @method annotation.

            $this->profile_picture = $imageName;
        } else {
            if (array_key_exists('profile_picture', $requestArray)) {
                $this->profile_picture = $requestArray['profile_picture'];
            }
        }

        $this->website = $requestArray['website'];  
        $this->facebook = $requestArray['facebook'];;

        //$this->created_by = Auth::id();$requestArray['created_by'];
        $this->created_by = $requestArray['created_by'];

        if (! $this->slug) {
            $this->slug = Str::slug($this->name, '-').'-'.rand(10000, 100000);
        }
    }

    /***************************************************************************/
}