DavideCasiraghi\LaravelEventsCalendar\Console\RetrieveAllGpsCoordinates

Complexity

Total Complexity

4

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Test Coverage

Coverage

17.65%

Importance

Changes	4
Bugs	1	Features	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	handle()	0	25	3

<?php

namespace DavideCasiraghi\LaravelEventsCalendar\Console;

use DavideCasiraghi\LaravelEventsCalendar\Facades\LaravelEventsCalendar;
use DavideCasiraghi\LaravelEventsCalendar\Models\Country;
use DavideCasiraghi\LaravelEventsCalendar\Models\EventVenue;
use Illuminate\Console\Command;

class RetrieveAllGpsCoordinates extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'retrieve-all-gps-coordinates';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Assign to all the venues the corresponding GPS coordinates';

    /**
     * Create a new command instance.
     *
     * @return void
     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @param
     * @return mixed
     */

The doc comment @return at position 0 could not be parsed: Unknown type name '@return' at position 0 in @return.

    public function handle()
    {
        $eventVenues = EventVenue::all();
        $eventVenuesNumber = count($eventVenues);

        foreach ($eventVenues as $key => $eventVenue) {

            // Get GPS coordinates
            $address = Country::getCountryName($eventVenue->country_id).', '.$eventVenue->city.', '.$eventVenue->address.', '.$eventVenue->zip_code;
            $gpsCoordinates = LaravelEventsCalendar::getVenueGpsCoordinates($address);

The method getVenueGpsCoordinates() does not exist on DavideCasiraghi\LaravelEventsCalendar\Facades\LaravelEventsCalendar. Since you implemented __callStatic, consider adding a @method annotation.

            // Print info in console
            // if there are problems the geocode system assign this coordinates 39.78373 -100.445882
            if ($gpsCoordinates['lng'] != '-100.445882') {
                $this->info($key.' of '.$eventVenuesNumber.' - '.$address);
                $this->info($gpsCoordinates['lat'].' '.$gpsCoordinates['lng']);
            } else {
                $this->error($key.' of '.$eventVenuesNumber.' - '.$address);
                $this->error($gpsCoordinates['lat'].' '.$gpsCoordinates['lng']);
            }

            // Save the data
            $eventVenue->lat = $gpsCoordinates['lat'];
            $eventVenue->lng = $gpsCoordinates['lng'];
            $eventVenue->save();
        }
    }
}