EventVenueController::saveOnDb() - Code Metrics - Inspection of "Adds some return type to functions" - davide-casiraghi/laravel-events-calendar - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( d17f27...9f17bc )

by Davide
created 2020-03-18 06:19 UTC
EventVenueController::saveOnDb() A

↳ Parent: EventVenueController
Complexity

Conditions	2
Paths	2
Size

Total Lines	31
Code Lines	19
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	20
CRAP Score	2
Importance

Changes
Metric	Value
eloc	19
c	0
b	0
f	0
dl	0
loc	31
ccs	20
cts	20
cp	1
rs	9.6333
cc	2
nc	2
nop	2
crap	2
<?php

namespace DavideCasiraghi\LaravelEventsCalendar\Http\Controllers;

use DavideCasiraghi\LaravelEventsCalendar\Facades\LaravelEventsCalendar;
use DavideCasiraghi\LaravelEventsCalendar\Models\Country;
use DavideCasiraghi\LaravelEventsCalendar\Models\EventVenue;
use DavideCasiraghi\LaravelEventsCalendar\Models\Region;
use Illuminate\Foundation\Auth\User;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Cache;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Str;
use Validator;

class EventVenueController extends Controller
{
    /* Restrict the access to this resource just to logged in users except show view */
    public function __construct()
    {
        $this->middleware('auth', ['except' => ['show']]);
    }

    /***************************************************************************/

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\View\View
     */
    public function index(Request $request)
    {
        $countries = Country::getCountries();
        $regions = Region::listsTranslations('name')->pluck('name', 'id');

        $searchKeywords = $request->input('keywords');
        $searchCountry = $request->input('country_id');

        // To show just the veues created by the the user - If admin or super admin is set to null show all the venues
        $authorUserId = ($this->getLoggedAuthorId()) ? $this->getLoggedAuthorId() : null;

        if ($searchKeywords || $searchCountry) {
            $eventVenues = DB::table('event_venues')
                ->when($authorUserId, function ($query, $authorUserId) {
                    return $query->where('created_by', $authorUserId);
                })
                ->when($searchKeywords, function ($query, $searchKeywords) {
                    return $query->where('name', $searchKeywords)->orWhere('name', 'like', '%'.$searchKeywords.'%');
                })
                ->when($searchCountry, function ($query, $searchCountry) {
                    return $query->where('country_id', '=', $searchCountry);
                })
                ->orderBy('name')
                ->paginate(20);
        } else {
            $eventVenues = EventVenue::
                when($authorUserId, function ($query, $authorUserId) {
                    return $query->where('created_by', $authorUserId);
                })
                ->orderBy('name')
                ->paginate(20);
        }
        //dd(DB::getQueryLog());

        return view('laravel-events-calendar::eventVenues.index', compact('eventVenues'))
                ->with('i', (request()->input('page', 1) - 1) * 20)
                ->with('countries', $countries)
                ->with('regions', $regions)
                ->with('searchKeywords', $searchKeywords)
                ->with('searchCountry', $searchCountry);
    }

    /***************************************************************************/

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\View\View
     */
    public function create()
    {
        $authorUserId = $this->getLoggedAuthorId();
        $users = User::pluck('name', 'id');
        $countries = Country::getCountries();
        $regions = [];

        return view('laravel-events-calendar::eventVenues.create')
                ->with('countries', $countries)
                ->with('regions', $regions)
                ->with('users', $users)
                ->with('authorUserId', $authorUserId);
    }

    /***************************************************************************/

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store(Request $request)
    {
        // Validate form datas
        $validator = $this->eventsVenueValidator($request);
        if ($validator->fails()) {
            return back()->withErrors($validator)->withInput();
        }

        $eventVenue = new EventVenue();
        $this->saveOnDb($request, $eventVenue);

        return redirect()->route('eventVenues.index')
                        ->with('success', __('laravel-events-calendar::messages.venue_added_successfully'));
    }

    /***************************************************************************/

    /**
     * Display the specified resource.
     *
     * @param  \DavideCasiraghi\LaravelEventsCalendar\Models\EventVenue  $eventVenue
     * @return \Illuminate\View\View
     */
    public function show(EventVenue $eventVenue)
    {
        $country = DB::table('countries')
                ->select('id', 'name', 'continent_id')
                ->where('id', $eventVenue->country_id)
                ->first();

        return view('laravel-events-calendar::eventVenues.show', compact('eventVenue'))->with('country', $country);
    }

    /***************************************************************************/

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \DavideCasiraghi\LaravelEventsCalendar\Models\EventVenue  $eventVenue
     * @return \Illuminate\Http\RedirectResponse | \Illuminate\View\View
     */
    public function edit(EventVenue $eventVenue)
    {
        //if (Auth::user()->id == $eventVenue->created_by || Auth::user()->isSuperAdmin() || Auth::user()->isAdmin()) {
        //if (Auth::user()->id == $eventVenue->created_by) {
        if (Auth::user()->id == $eventVenue->created_by || Auth::user()->group == 1 || Auth::user()->group == 2) {

            $authorUserId = $this->getLoggedAuthorId();
            $users = User::pluck('name', 'id');
            $countries = Country::getCountries();
            $regions = Region::getRegionsByCountry($eventVenue->country_id);

            // Invalidate cache tags for events map - This is not needed in event create() because the marker is created when an event gets creted.
            Cache::forget('active_events_map_markers_json');
            Cache::forget('active_events_map_markers_db_data');

            return view('laravel-events-calendar::eventVenues.edit', compact('eventVenue'))
                ->with('countries', $countries)
                ->with('regions', $regions)
                ->with('users', $users)
                ->with('authorUserId', $authorUserId);
        } else {
            return redirect()->route('home')->with('message', __('auth.not_allowed_to_access'));
        }
    }

    /***************************************************************************/

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \DavideCasiraghi\LaravelEventsCalendar\Models\EventVenue  $eventVenue
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update(Request $request, EventVenue $eventVenue)
    {
        // Validate form datas
        $validator = $this->eventsVenueValidator($request);
        if ($validator->fails()) {
            return back()->withErrors($validator)->withInput();
        }

        //$eventVenue->update($request->all());
        $this->saveOnDb($request, $eventVenue);

        return redirect()->route('eventVenues.index')
                        ->with('success', __('laravel-events-calendar::messages.venue_updated_successfully'));
    }

    /***************************************************************************/

    /**
     * Remove the specified resource from storage.
     *
     * @param  \DavideCasiraghi\LaravelEventsCalendar\Models\EventVenue  $eventVenue
     * @return \Illuminate\Http\RedirectResponse
     */
    public function destroy(EventVenue $eventVenue)
    {
        if (EventVenue::venueContainsEvents($eventVenue->id)) {
            return redirect()->route('eventVenues.index')
                            ->with('success', __('laravel-events-calendar::messages.venue_not_deleted'));
        } else {
            $eventVenue->delete();

            return redirect()->route('eventVenues.index')
                            ->with('success', __('laravel-events-calendar::messages.venue_deleted_successfully'));
        }
    }

    /***************************************************************************/

    /**
     * Save the record on DB.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \DavideCasiraghi\LaravelEventsCalendar\Models\EventVenue  $eventVenue
     * @return \Illuminate\Http\Response
     */
    public function saveOnDb(Request $request, EventVenue $eventVenue)
    {
        $eventVenue->name = $request->get('name');
        //$eventVenue->description = $request->get('description');
        $eventVenue->description = clean($request->get('description'));
        $eventVenue->continent_id = Country::where('id', $request->get('country_id'))->pluck('continent_id')->first();
        $eventVenue->country_id = $request->get('country_id');
        $eventVenue->region_id = $request->get('region_id');
        $eventVenue->city = $request->get('city');
        //$eventVenue->state_province = $request->get('state_province');
        $eventVenue->address = $request->get('address');
        $eventVenue->zip_code = $request->get('zip_code');
        $eventVenue->extra_info = $request->get('extra_info');
        $eventVenue->website = $request->get('website');

        // Get GPS coordinates
        $address = Country::getCountryName($eventVenue->country_id).', '.$eventVenue->city.', '.$eventVenue->address;
        $gpsCoordinates = LaravelEventsCalendar::getVenueGpsCoordinates($address);
        $gpsCoordinates = LaravelEventsCalendar::getVenueGpsCoordinates($address);
        $eventVenue->lat = $gpsCoordinates['lat'];
        $eventVenue->lng = $gpsCoordinates['lng'];

        if (! $eventVenue->slug) {
            $eventVenue->slug = Str::slug($eventVenue->name, '-').rand(10000, 100000);
        }

        //$eventVenue->created_by = Auth::id();
        $eventVenue->created_by = $request->get('created_by');

        $eventVenue->save();

        return $eventVenue->id;
    }

    /***************************************************************************/

    /**
     * Open a modal in the event view when 'create new venue' button is clicked.
     *
     * @return \Illuminate\View\View
     */
    public function modal()
    {
        $countries = Country::getCountries();
        $regions = [];
        $users = User::pluck('name', 'id');

        return view('laravel-events-calendar::eventVenues.modal')
                    ->with('countries', $countries)
                    ->with('regions', $regions)
                    ->with('users', $users);
    }

    /***************************************************************************/

    /**
     * Store a newly created VENUE from the create event view modal in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function storeFromModal(Request $request)
    {
        $eventVenue = new EventVenue();

        $eventVenueId = $this->saveOnDb($request, $eventVenue);
        $eventVenue = EventVenue::find($eventVenueId);

        return response()->json([
            'eventVenueId' => $eventVenueId,
            'eventVenueName' => $eventVenue->name,
        ]);
    }

    /***************************************************************************/

    /**
     * Return the Venue validator with all the defined constraint.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Contracts\Validation\Validator
     */
    public function eventsVenueValidator(Request $request)
    {
        $rules = [
            'name' => 'required',
            'city' => 'required',
            'country_id' => 'required',
            'website' => 'nullable|url',
        ];
        $messages = [];

        $validator = Validator::make($request->all(), $rules, $messages);

        return $validator;
    }
}

davide-casiraghi / laravel-events-calendar

Push — master ( d17f27...9f17bc )

EventVenueController::saveOnDb() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like
