DavideCasiraghi\LaravelEventsCalendar\Http\Middleware\Admin::handle()

Complexity

Conditions	4
Paths	3

Size

Total Lines	17
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	4.0466

Importance

Changes

0

<?php
    public function handle($request, Closure $next)
    {
        $user = \Auth::user();

        // If user is not logged
        if (! $user) {
            return redirect('/')->with('message', 'You have not admin access');
        }

        // If user is logged and admin/superadmin
        //if (($user->isAdmin() || $user->isSuperAdmin()) == 1) {
        if (($user->group == 2) || ($user->group == 1)) {

Accessing group on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            return $next($request);
        }

        // Return to homepage if user il logged but not admin
        return redirect('/')->with('message', 'You have not admin access');
    }