Context::get() - Code Metrics - daviddeutsch/saltwater - Measure and Improve Code Quality continuously with Scrutinizer

Context::get() A
last analyzed 2017-02-28 09:47 UTC

↳ Parent: Context

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
c	0
b	0
f	0
rs	9.4285
cc	3
eloc	8
nc	3
nop	2

<?php

namespace Saltwater\Root\Provider;

use Saltwater\Server as S;
use Saltwater\Utils as U;
use Saltwater\Salt\Provider;
use Saltwater\Salt\Context as SwContext;
use Saltwater\Salt\Module;

class Context extends Provider
{
    /**
     * @param string         $name
     * @param SwContext|null $parent
     *
     * @return SwContext|null
     */
    public function get($name, $parent = null)
    {
        $module = S::$n->getContextModule($name);

        if (empty($module)) {
            return null;
        }

        $class = U::className($module::getNamespace(), 'context', $name);

        if (!class_exists($class)) {
            return null;
        }

        return $this->newContext($class, $parent, $module);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * @param string         $class
     * @param SwContext|null $parent
     * @param Module         $module
     *
     * @return SwContext
     */
    private function newContext($class, $parent, $module)
    {
        return new $class($parent, $module);
    }
}


1			<?php
2
3			namespace Saltwater\Root\Provider;
4
5			use Saltwater\Server as S;
6			use Saltwater\Utils as U;
7			use Saltwater\Salt\Provider;
8			use Saltwater\Salt\Context as SwContext;
9			use Saltwater\Salt\Module;
10
11			class Context extends Provider
12			{
13			/**
14			* @param string $name
15			* @param SwContext\|null $parent
16			*
17			* @return SwContext\|null
18			*/
19			public function get($name, $parent = null)
20			{
21			$module = S::$n->getContextModule($name);
22
23			if (empty($module)) {
24			return null;
25			}
26
27			$class = U::className($module::getNamespace(), 'context', $name);
28
29			if (!class_exists($class)) {
30			return null;
31			}
32
33			return $this->newContext($class, $parent, $module);
			0 ignored issues – show Bug introduced 2017-02-28 09:47 UTC by Report Bug Copy Issue Report It seems like `$module` defined by `\Saltwater\Server::$n->getContextModule($name)` on line `21` can also be of type `string`; however, `Saltwater\Root\Provider\Context::newContext()` does only seem to accept `object<Saltwater\Salt\Module>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
34			}
35
36			/**
37			* @param string $class
38			* @param SwContext\|null $parent
39			* @param Module $module
40			*
41			* @return SwContext
42			*/
43			private function newContext($class, $parent, $module)
44			{
45			return new $class($parent, $module);
46			}
47			}
48

daviddeutsch / saltwater

GitHub Access Token became invalid

Context::get() A last analyzed 2017-02-28 09:47 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Context::get() A
last analyzed 2017-02-28 09:47 UTC