Saltwater\RedBean\Service\Rest

Complexity

Total Complexity

8

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	isCallable()	0	10	2
A	call()	0	8	2
A	restCall()	0	10	2
A	callPath()	0	6	1
A	restHandler()	0	4	1

<?php

namespace Saltwater\RedBean\Service;

use Saltwater\Server as S;
use Saltwater\Utils as U;
use Saltwater\Salt\Service;

class Rest extends Service
{
    public function isCallable($method)
    {
        if (parent::isCallable($method)) {
            return true;
        }

        $class = U::explodeClass($this);

        return strpos($method, array_pop($class)) !== false;
    }

    /**
     * @param object $call
     * @param mixed  $data
     *
     * @return array|int|\RedBean_OODBBean
     */
    public function call($call, $data = null)
    {
        if (parent::isCallable($call->function)) {

It seems like you call parent on a different method (isCallable() instead of call()). Are you sure this is correct? If so, you might want to change this to $this->isCallable().

            return parent::call($call, $data);
        }

        return $this->restCall($call, $data);

The expression $this->restCall($call, $data); of type array|RedBean_OODBBean|null|integer|string adds the type string to the return on line 34 which is incompatible with the return type documented by Saltwater\RedBean\Service\Rest::call of type array|integer|RedBean_OODBBean.

    }

    /**
     * @param object $call
     * @param mixed  $data
     *
     * @return array|int|\RedBean_OODBBean
     */
    protected function restCall($call, $data = null)
    {
        $path = $call->method;

        if (is_numeric($call->path)) {
            $path .= '/' . $call->path;
        }

        return $this->callPath($call->http, $path, $data);
    }

    /**
     * @param string $http
     * @param string $path
     * @param mixed  $data
     */
    protected function callPath($http, $path, $data = null)
    {
        $rest = $this->restHandler();

        return $rest->handleRESTRequest($http, $path, $data);
    }

    protected function restHandler()
    {
        return new \RedBean_Plugin_BeanCan(S::$n->db($this->module));
    }
}