daveross / functional-programming-utils

src/Monads/Monad.php

<?php

namespace DaveRoss\FunctionalProgrammingUtils;

/**
 * Class Monad
 * Base class for Monads. Implements basic Monad functionality
 * @package DaveRoss\FunctionalProgrammingUtils
 */
abstract class Monad

Monad does not seem to conform to the naming convention (^Abstract|Factory$).

{

    protected $value;

    /**
     * Allow Monad::map() to be called like a method
     *
     * @param callable $f
     *
     * @return mixed

Consider making the return type a bit more specific; maybe use Monad.

     */
    public function __invoke($f)

Avoid variables with short names like $f. Configured minimum length is 3.

    {
        return $this->map($f);
    }

    /**
     * @param mixed $a
     */
    private function __construct($a)

Something seems to be off here. Are you sure you want to declare the constructor as private, and the class as abstract?

Avoid variables with short names like $a. Configured minimum length is 3.

    {
        $this->value = $a;
    }

    /**
     * Instantiate a new Monad wrapping a given value
     *
     * @param mixed $a
     *
     * @return Monad
     */
    public static function of($a)

Avoid variables with short names like $a. Configured minimum length is 3.

This method's name is shorter than the configured minimum length of 3 characters.

    {
        return new static( $a );
    }

    /**
     * Apply a function to this Monad's value
     *
     * @param callable $f
     *
     * @return Monad
     */
    public function map(callable $f)

Avoid variables with short names like $f. Configured minimum length is 3.

    {
        $class_name = get_called_class();

$class_name does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        return new $class_name( $f( $this->value ) );

$class_name does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    }

    /**
     * Get this Monad's value without wrapping it.
     * @return mixed
     */
    public function value()
    {
        return $this->value;
    }
}