DataslangApi::validate() - Code Metrics - Inspection of "Edit DataslangApi" - dataslang/dataslang-php - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( d6601c...d6d4d5 )

by Daniele

created 2016-05-16 09:41 UTC

DataslangApi::validate() B

↳ Parent: DataslangApi

Complexity

Conditions	2
Paths	3

Size

Total Lines	30
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	30
rs	8.8571
cc	2
eloc	9
nc	3
nop	2

<?php

use GuzzleHttp\Client;

class DataslangApi {
namespace YourVendor;

class YourClass { }
	
	const BASE_URI = 'http://api.dataslang.com';
	
	private $client = null;
	private $settings = array();
	private $timeout = 2.0;
  
	public function __construct(){
		$this->initSettings();
		$this->client = new Client($this->settings);
	}

	public function validate($xml, $xsd){

		$result = null;
		
		try {
		

			//     	$response = $this->client->request('POST', '/validate', [

			//         	'form_params' => [

			//             	'field_name' => 'abc',

			//             	'other_field' => '123',

			//             	'nested_field' => [

			//                 	'nested' => 'hello'

			//             	]
			//         	]
			//     	]);
			
			$response = $this->client->request('POST', '/validate', [
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
				'form_params' => [
					'parametro' => 'prova'
				]
			]);
			
			$result = $res->getBody();

			
		} catch (\Exception $e) {

			
		}
		
		return $result;
  	}
  
  	private function initSettings(){
  		$this->settings['base_uri'] = $this->getBaseUri();
  		$this->settings['timeout'] = $this->getTimeout();
  	}
  
	public function setTimeout($timeout){
		$this->timeout = $timeout;
	}
	
	public function getTimeout(){
		return $this->timeout;
	}
	
	public function getBaseUri(){
		return self::BASE_URI;
	}

}


1			<?php
2
3			use GuzzleHttp\Client;
4
5			class DataslangApi {
			0 ignored issues – show Coding Style Compatibility introduced 2016-05-16 09:32 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
6
7			const BASE_URI = 'http://api.dataslang.com';
8
9			private $client = null;
10			private $settings = array();
11			private $timeout = 2.0;
12
13			public function __construct(){
14			$this->initSettings();
15			$this->client = new Client($this->settings);
16			}
17
18			public function validate($xml, $xsd){
			0 ignored issues – show Unused Code introduced 2016-05-16 09:32 UTC by Report Bug Copy Issue Report The parameter `$xml` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-05-16 09:32 UTC by Report Bug Copy Issue Report The parameter `$xsd` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
19			$result = null;
20
21			try {
22
23
24			// $response = $this->client->request('POST', '/validate', [
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-16 09:32 UTC by Report Bug Copy Issue Report `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
25			// 'form_params' => [
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-16 09:32 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
26			// 'field_name' => 'abc',
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-16 09:32 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
27			// 'other_field' => '123',
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-16 09:32 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
28			// 'nested_field' => [
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-16 09:32 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
29			// 'nested' => 'hello'
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-16 09:32 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
30			// ]
31			// ]
32			// ]);
33
34			$response = $this->client->request('POST', '/validate', [
			0 ignored issues – show Unused Code introduced 2016-05-16 09:32 UTC by Report Bug Copy Issue Report `$response` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
35			'form_params' => [
36			'parametro' => 'prova'
37			]
38			]);
39
40			$result = $res->getBody();
			0 ignored issues – show Bug introduced 2016-05-16 09:32 UTC by Report Bug Copy Issue Report The variable `$res` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
41
42			} catch (\Exception $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-05-16 09:32 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
43
44			}
45
46			return $result;
47			}
48
49			private function initSettings(){
50			$this->settings['base_uri'] = $this->getBaseUri();
51			$this->settings['timeout'] = $this->getTimeout();
52			}
53
54			public function setTimeout($timeout){
55			$this->timeout = $timeout;
56			}
57
58			public function getTimeout(){
59			return $this->timeout;
60			}
61
62			public function getBaseUri(){
63			return self::BASE_URI;
64			}
65
66			}
67

dataslang / dataslang-php

Push — master ( d6601c...d6d4d5 )

DataslangApi::validate() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like