datasift / storyplayer

src/php/Prose/UsingPDODB.php

Doc Comments +4 added lines

@@ -62,6 +62,10 @@
  */
 class UsingPDODB extends Prose
 {
+    /**
+     * @param \DataSift\Storyplayer\PlayerLib\StoryTeller $st
+     * @param PDO[] $args
+     */
     public function __construct($st, $args)
     {
         // call our parent first

Braces +10 added lines, -20 removed lines

@@ -81,8 +81,7 @@ 
         // what are we doing?
         $log = usingLog()->startAction(["run SQL query:", $sql, "/ with params:", $params, "and driver params:", $driverParams]);
 
-        try
-        {
+        try {
             // create a prepared statement
             //
             // we do this so that we can inject the $params into the SQL statement
@@ -95,8 +94,7 @@ 
             $log->endAction();
             return $stmt;
         }
-        catch (Exception $e)
-        {
+        catch (Exception $e) {
             throw new E5xx_ActionFailed(__METHOD__, $e->getMessage());
         }
     }
@@ -106,8 +104,7 @@ 
         // what are we doing?
         $log = usingLog()->startAction(["run raw SQL query:", $sql, "with driver params: ", $driverParams]);
 
-        try
-        {
+        try {
             // execute the prepared statement
             //
             // we do this directly so that you can (hopefully) attempt
@@ -118,8 +115,7 @@ 
             $log->endAction();
             return $stmt;
         }
-        catch (Exception $e)
-        {
+        catch (Exception $e) {
             throw new E5xx_ActionFailed(__METHOD__, $e->getMessage());
         }
     }
@@ -129,15 +125,13 @@ 
         // what are we doing?
         $log = usingLog()->startAction("begin PDO database transaction");
 
-        try
-        {
+        try {
             $this->args[0]->beginTransaction();
 
             // all done
             $log->endAction();
         }
-        catch (Exception $e)
-        {
+        catch (Exception $e) {
             throw new E5xx_ActionFailed(__METHOD__, $e->getMessage());
         }
     }
@@ -147,15 +141,13 @@ 
         // what are we doing?
         $log = usingLog()->startAction("commit PDO database transaction");
 
-        try
-        {
+        try {
             $this->args[0]->commit();
 
             // all done
             $log->endAction();
         }
-        catch (Exception $e)
-        {
+        catch (Exception $e) {
             throw new E5xx_ActionFailed(__METHOD__, $e->getMessage());
         }
     }
@@ -165,15 +157,13 @@ 
         // what are we doing?
         $log = usingLog()->startAction("rollback PDO database transaction");
 
-        try
-        {
+        try {
             $this->args[0]->rollBack();
 
             // all done
             $log->endAction();
         }
-        catch (Exception $e)
-        {
+        catch (Exception $e) {
             throw new E5xx_ActionFailed(__METHOD__, $e->getMessage());
         }
     }

src/php/Storyplayer/TestEnvironments/Vagrant/VirtualboxHostAdapter.php

Doc Comments +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
 	 *         the group that we belong to
 	 * @param  string $hostId
 	 *         the alias for this host
-	 * @return object
+	 * @return Vagrant_VirtualboxHostDefinition
 	 *         a host definition to populate
 	 */
 	public function newHostDefinition(TestEnvironment_GroupDefinition $groupDef, $hostId)

Indentation +14 added lines, -14 removed lines

@@ -62,18 +62,18 @@
 
 class Vagrant_VirtualboxHostAdapter extends Vagrant_HostAdapter
 {
-	/**
-	 * create an empty host definition for this kind of host
-	 *
-	 * @param  TestEnvironment_GroupDefinition $groupDef
-	 *         the group that we belong to
-	 * @param  string $hostId
-	 *         the alias for this host
-	 * @return object
-	 *         a host definition to populate
-	 */
-	public function newHostDefinition(TestEnvironment_GroupDefinition $groupDef, $hostId)
-	{
-		return new Vagrant_VirtualboxHostDefinition($groupDef, $hostId, $this);
-	}
+    /**
+     * create an empty host definition for this kind of host
+     *
+     * @param  TestEnvironment_GroupDefinition $groupDef
+     *         the group that we belong to
+     * @param  string $hostId
+     *         the alias for this host
+     * @return object
+     *         a host definition to populate
+     */
+    public function newHostDefinition(TestEnvironment_GroupDefinition $groupDef, $hostId)
+    {
+        return new Vagrant_VirtualboxHostDefinition($groupDef, $hostId, $this);
+    }
 }
\ No newline at end of file

src/php/DataSift/Storyplayer/Cli/BuildTestEnvironment/Command.php

Indentation +1 added lines, -1 removed lines

@@ -302,7 +302,7 @@
         // do we skip destroying the test environment?
         if ($this->st->getPersistTestEnvironment()) {
             echo PHP_EOL . "* Warning: NOT destroying test environment" . PHP_EOL
-                 .         "           --reuse-target flag is set" . PHP_EOL;
+                    .         "           --reuse-target flag is set" . PHP_EOL;
         }
 
         // cleanup

Braces +1 added lines, -2 removed lines

@@ -218,8 +218,7 @@
         // $this->playerList contains one or more things to play
         //
         // let's play each of them in order
-        foreach ($this->playerList as $player)
-        {
+        foreach ($this->playerList as $player) {
             // execute each player in turn
             //
             // they may also have their own list of nested players

Spacing +1 added lines, -1 removed lines

@@ -231,7 +231,7 @@
 
         // setup signal handling
         pcntl_signal(SIGTERM, array($this, 'sigtermHandler'));
-        pcntl_signal(SIGINT , array($this, 'sigtermHandler'));
+        pcntl_signal(SIGINT, array($this, 'sigtermHandler'));
     }
 
     /**

src/php/DataSift/Storyplayer/Cli/E4xx/NoSystemUnderTestSpecified.php

Indentation +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
     public function __construct()
     {
         $msg = "You need to use -s to specify which system to test." . PHP_EOL . PHP_EOL
-             . "Use 'storyplayer --list-systems' to see the list of known systems under test.";
+                . "Use 'storyplayer --list-systems' to see the list of known systems under test.";
         parent::__construct(400, $msg, $msg);
     }
 }
\ No newline at end of file

src/php/DataSift/Storyplayer/Cli/Feature/ColorSupport.php

Indentation +12 added lines, -12 removed lines

@@ -78,20 +78,20 @@
 
     public function initBeforeModulesAvailable(CliEngine $engine, CliCommand $command, Injectables $injectables)
     {
-    	// which colour mode are we in?
-    	switch ($engine->options->color) {
-    		case Feature_ColorSwitch::NO_COLOR:
-    			$injectables->output->disableColourSupport();
-    			break;
+        // which colour mode are we in?
+        switch ($engine->options->color) {
+            case Feature_ColorSwitch::NO_COLOR:
+                $injectables->output->disableColourSupport();
+                break;
 
-    		case Feature_ColorSwitch::ALWAYS_COLOR:
-    			$injectables->output->enforceColourSupport();
-    			break;
+            case Feature_ColorSwitch::ALWAYS_COLOR:
+                $injectables->output->enforceColourSupport();
+                break;
 
-    		case Feature_ColorSwitch::AUTO_COLOR:
-    			$injectables->output->enableColourSupport();
-    			break;
-    	}
+            case Feature_ColorSwitch::AUTO_COLOR:
+                $injectables->output->enableColourSupport();
+                break;
+        }
     }
 
     public function initAfterModulesAvailable(StoryTeller $st, CliEngine $engine, Injectables $injectables)

src/php/DataSift/Storyplayer/Cli/Feature/DefineSwitch.php

Braces +1 added lines, -2 removed lines

@@ -94,8 +94,7 @@
             $engine->options->defines = new stdClass;
         }
 
-        foreach ($params as $param)
-        {
+        foreach ($params as $param) {
             // split up the setting
             $parts = explode('=', $param);
             $key   = array_shift($parts);

src/php/DataSift/Storyplayer/Cli/Feature/PersistDeviceSupport.php

Indentation +4 added lines, -4 removed lines

@@ -70,14 +70,14 @@
 {
     public function addSwitches(CliCommand $command, $injectables)
     {
-    	$command->addSwitches([
-    		new Feature_PersistDeviceSwitch,
-    	]);
+        $command->addSwitches([
+            new Feature_PersistDeviceSwitch,
+        ]);
     }
 
     public function initBeforeModulesAvailable(CliEngine $engine, CliCommand $command, Injectables $injectables)
     {
-    	// no-op
+        // no-op
     }
 
     public function initAfterModulesAvailable(StoryTeller $st, CliEngine $engine, Injectables $injectables)

src/php/DataSift/Storyplayer/Cli/Feature/PersistProcessesSupport.php

Indentation +4 added lines, -4 removed lines

@@ -70,14 +70,14 @@
 {
     public function addSwitches(CliCommand $command, $injectables)
     {
-    	$command->addSwitches([
-    		new Feature_PersistProcessesSwitch,
-    	]);
+        $command->addSwitches([
+            new Feature_PersistProcessesSwitch,
+        ]);
     }
 
     public function initBeforeModulesAvailable(CliEngine $engine, CliCommand $command, Injectables $injectables)
     {
-    	// no-op
+        // no-op
     }
 
     public function initAfterModulesAvailable(StoryTeller $st, CliEngine $engine, Injectables $injectables)

src/php/DataSift/Storyplayer/Cli/Feature/PersistReuseTargetSupport.php

Indentation +7 added lines, -7 removed lines

@@ -70,21 +70,21 @@
 {
     public function addSwitches(CliCommand $command, $injectables)
     {
-    	$command->addSwitches([
-    		new Feature_PersistTargetSwitch,
-    		new Feature_ReuseTargetSwitch
-    	]);
+        $command->addSwitches([
+            new Feature_PersistTargetSwitch,
+            new Feature_ReuseTargetSwitch
+        ]);
     }
 
     public function initBeforeModulesAvailable(CliEngine $engine, CliCommand $command, Injectables $injectables)
     {
-    	// no-op
+        // no-op
     }
 
     public function initAfterModulesAvailable(StoryTeller $st, CliEngine $engine, Injectables $injectables)
     {
-    	// shorthand
-    	$output = $injectables->output;
+        // shorthand
+        $output = $injectables->output;
 
         // are we keeping the test environment hanging around afterwards?
         if (isset($engine->options->persistTarget) && $engine->options->persistTarget)

Braces +3 added lines, -6 removed lines

@@ -87,8 +87,7 @@ 
     	$output = $injectables->output;
 
         // are we keeping the test environment hanging around afterwards?
-        if (isset($engine->options->persistTarget) && $engine->options->persistTarget)
-        {
+        if (isset($engine->options->persistTarget) && $engine->options->persistTarget) {
             $injectables->activeConfig->setData('storyplayer.phases.testEnvShutdown.TestEnvironmentDestruction', false);
             $injectables->activeConfig->unsetData('storyplayer.phases.userAbort.TestEnvironmentDestruction');
             $st->setPersistTestEnvironment();
@@ -96,8 +95,7 @@ 
 
         // are we trying to use a test environment that has previously
         // been persisted?
-        if (isset($engine->options->reuseTarget) && $engine->options->reuseTarget)
-        {
+        if (isset($engine->options->reuseTarget) && $engine->options->reuseTarget) {
             // does the target exist to be reused?
             $output->setSilentMode();
             $hasTarget = $st->fromTargetsTable()->hasCurrentTestEnvironment();
@@ -128,8 +126,7 @@ 
             // if we get here, then we do not need to create the test environment
             $injectables->activeConfig->setData('storyplayer.phases.testEnvStartup.TestEnvironmentConstruction', false);
         }
-        else
-        {
+        else {
             // do we already have this target?
             //
             // this can happen when the test environment was previously