datasift / storyplayer

storyplayer/test-environments/vagrant-vbox-ubuntu-15.04-server/main.php

Indentation +3 added lines, -3 removed lines

@@ -9,14 +9,14 @@
 
 $group1 = $testEnv->newGroup('vagrant', new Vagrant_GroupAdapter);
 $group1->newHost('default', new Vagrant_VirtualboxHostAdapter)
-       ->setOperatingSystem(new Ubuntu_1504_HostAdapter)
-       ->setRoles([
+        ->setOperatingSystem(new Ubuntu_1504_HostAdapter)
+        ->setRoles([
             "host_target",
             "upload_target",
             "ssl_target",
             "zmq_target",
         ])
-       ->setStorySettings((object)[
+        ->setStorySettings((object)[
             "host" => (object)[
                 "expected" => "successfully retrieved this storySetting :)",
             ],

src/php/Prose/BaseCleanup.php

Doc Comments +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
      * __construct
      *
      * @param StoryTeller $st The StoryTeller object
-     * @param array $args Any arguments to be used in this Prose module
+     * @param string[] $args Any arguments to be used in this Prose module
      *
      * @return parent::__construct
      */

src/php/DataSift/Storyplayer/Cli/KillProcesses/Switch.php

Spacing +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
         $this->setLongDescription(
             "Use this command to get a list of all of the machines (physical or VM)"
             . " that are currently listed in Storyplayer's hoststable."
-            .PHP_EOL .PHP_EOL
+            .PHP_EOL . PHP_EOL
             ."This can help you to identify VMs that have been left running after "
             ."a test has completed."
             .PHP_EOL

src/php/DataSift/Storyplayer/Console/DefaultConsole.php

Indentation +2 added lines, -2 removed lines

@@ -270,8 +270,8 @@
     public function logCliErrorWithException($msg, $e)
     {
         $this->write("*** error: $msg" . PHP_EOL . PHP_EOL
-             . "This was caused by an unexpected exception " . get_class($e) . PHP_EOL . PHP_EOL
-             . $e->getTraceAsString() . PHP_EOL);
+                . "This was caused by an unexpected exception " . get_class($e) . PHP_EOL . PHP_EOL
+                . $e->getTraceAsString() . PHP_EOL);
     }
 
     /**

src/php/DataSift/Storyplayer/Console/E5xx/MissingFailedPhase.php

Braces +2 added lines, -1 removed lines

@@ -57,7 +57,8 @@
  */
 class E4xx_StoryShouldFail extends Exxx_Exception
 {
-    public function __construct() {
+    public function __construct()
+    {
         $msg = "Story should fail";
         parent::__construct(400, $msg, $msg);
     }

src/php/DataSift/Storyplayer/DeviceLib/E5xx/CannotStartDevice.php

Braces +2 added lines, -1 removed lines

@@ -57,7 +57,8 @@
  */
 class E4xx_StoryShouldFail extends Exxx_Exception
 {
-    public function __construct() {
+    public function __construct()
+    {
         $msg = "Story should fail";
         parent::__construct(400, $msg, $msg);
     }

src/php/DataSift/Storyplayer/DeviceLib/E5xx/NoHttpBasicAuthSupport.php

Braces +2 added lines, -1 removed lines

@@ -57,7 +57,8 @@
  */
 class E4xx_StoryShouldFail extends Exxx_Exception
 {
-    public function __construct() {
+    public function __construct()
+    {
         $msg = "Story should fail";
         parent::__construct(400, $msg, $msg);
     }

src/php/DataSift/Storyplayer/DeviceLib/LocalWebDriverAdapter.php

Braces +2 added lines, -4 removed lines

@@ -104,15 +104,13 @@
     public function stop()
     {
         // stop the web browser
-        if (is_object($this->browserSession))
-        {
+        if (is_object($this->browserSession)) {
             $this->browserSession->close();
             $this->browserSession = null;
         }
 
         // now stop the proxy
-        if (is_object($this->proxySession))
-        {
+        if (is_object($this->proxySession)) {
             try {
                 $this->proxySession->close();
             }

src/php/DataSift/Storyplayer/HostLib/Blackboxes.php

Spacing +2 added lines, -2 removed lines

@@ -99,7 +99,7 @@ 
         if (empty($groupDef->details->machines)) {
             throw new E5xx_ActionFailed(__METHOD__, "groupDef->details->machines cannot be empty");
         }
-        foreach($groupDef->details->machines as $hostId => $machine) {
+        foreach ($groupDef->details->machines as $hostId => $machine) {
             // TODO: it would be great to autodetect this one day
             if (!isset($machine->roles)) {
                 throw new E5xx_ActionFailed(__METHOD__, "missing groupDef->details->machines['$hostId']->roles");
@@ -123,7 +123,7 @@ 
         // if it is not, that is NOT our responsibility
 
         // store the details
-        foreach($groupDef->details->machines as $hostId => $machine)
+        foreach ($groupDef->details->machines as $hostId => $machine)
         {
             // we want all the details from the config file
             $vmDetails = clone $machine;

Braces +2 added lines, -4 removed lines

@@ -123,8 +123,7 @@ 
         // if it is not, that is NOT our responsibility
 
         // store the details
-        foreach($groupDef->details->machines as $hostId => $machine)
-        {
+        foreach($groupDef->details->machines as $hostId => $machine) {
             // we want all the details from the config file
             $vmDetails = clone $machine;
 
@@ -205,8 +204,7 @@ 
         $log = usingLog()->startAction("de-register blackbox(es)");
 
         // de-register all the hosts
-        foreach ($groupDef->details->machines as $hostId => $machine)
-        {
+        foreach ($groupDef->details->machines as $hostId => $machine) {
             foreach ($machine->roles as $role) {
                 usingRolesTable()->removeHostFromAllRoles($hostId);
             }