@@ -60,7 +60,7 @@ |
||
60 | 60 | */ |
61 | 61 | class UsingZmq extends Prose |
62 | 62 | { |
63 | - protected $socketMap = array ( |
|
63 | + protected $socketMap = array( |
|
64 | 64 | ZMQ::SOCKET_PUB => "ZMQ::SOCKET_PUB", |
65 | 65 | ZMQ::SOCKET_SUB => "ZMQ::SOCKET_SUB", |
66 | 66 | ZMQ::SOCKET_REQ => "ZMQ::SOCKET_REQ", |
@@ -96,7 +96,7 @@ discard block |
||
96 | 96 | // where are we unbinding from? |
97 | 97 | $endpoints = fromZmqSocket($this->args[0])->getEndpoints(); |
98 | 98 | |
99 | - foreach($endpoints['bind'] as $address) { |
|
99 | + foreach ($endpoints['bind'] as $address) { |
|
100 | 100 | usingLog()->writeToLog("unbinding from {$address}"); |
101 | 101 | $this->args[0]->unbind($address); |
102 | 102 | } |
@@ -156,7 +156,7 @@ discard block |
||
156 | 156 | // where are we disconnecting from? |
157 | 157 | $endpoints = fromZmqSocket($this->args[0])->getEndpoints(); |
158 | 158 | |
159 | - foreach($endpoints['connect'] as $address) { |
|
159 | + foreach ($endpoints['connect'] as $address) { |
|
160 | 160 | usingLog()->writeToLog("disconnecting from {$address}"); |
161 | 161 | $this->args[0]->disconnect($address); |
162 | 162 | } |
@@ -62,7 +62,7 @@ discard block |
||
62 | 62 | protected $host; |
63 | 63 | protected $zk; |
64 | 64 | |
65 | - protected $default_acl = array( array( |
|
65 | + protected $default_acl = array(array( |
|
66 | 66 | "perms" => Zookeeper::PERM_ALL, |
67 | 67 | "scheme" => "world", |
68 | 68 | "id" => "anyone" |
@@ -117,10 +117,10 @@ discard block |
||
117 | 117 | } |
118 | 118 | |
119 | 119 | // drop the last part, as that is the key itself |
120 | - unset($parts[count($parts) -1]); |
|
120 | + unset($parts[count($parts) - 1]); |
|
121 | 121 | |
122 | 122 | // start with an empty path |
123 | - $path = ''; |
|
123 | + $path = ''; |
|
124 | 124 | |
125 | 125 | // work through the parts, building up the path to create from |
126 | 126 | // the root of the directory |
@@ -124,16 +124,14 @@ discard block |
||
124 | 124 | |
125 | 125 | // work through the parts, building up the path to create from |
126 | 126 | // the root of the directory |
127 | - foreach ($parts as $part) |
|
128 | - { |
|
127 | + foreach ($parts as $part) { |
|
129 | 128 | // expand our path to the next part |
130 | 129 | $path .= '/' . $part; |
131 | 130 | |
132 | 131 | // does this path exist? |
133 | 132 | if (!$this->zk->exists($path)) { |
134 | 133 | // no - create it |
135 | - if (!$this->zk->create($path, 1, $this->default_acl)) |
|
136 | - { |
|
134 | + if (!$this->zk->create($path, 1, $this->default_acl)) { |
|
137 | 135 | // failed to create the entry |
138 | 136 | throw new E5xx_ActionFailed(__METHOD__); |
139 | 137 | } |
@@ -151,8 +149,9 @@ discard block |
||
151 | 149 | |
152 | 150 | // now we can safely set the key itself |
153 | 151 | if (!$this->zk->exists($key)) { |
154 | - if (!$this->zk->create($key, $value, $this->default_acl)) |
|
155 | - throw new E5xx_ActionFailed(__METHOD__); |
|
152 | + if (!$this->zk->create($key, $value, $this->default_acl)) { |
|
153 | + throw new E5xx_ActionFailed(__METHOD__); |
|
154 | + } |
|
156 | 155 | } |
157 | 156 | else if (!$this->zk->set($key, $value)) { |
158 | 157 | throw new E5xx_ActionFailed(__METHOD__); |
@@ -1088,7 +1088,7 @@ |
||
1088 | 1088 | */ |
1089 | 1089 | function fromSupervisor($hostId) |
1090 | 1090 | { |
1091 | - return new FromSupervisor(StoryTeller::instance(),[$hostId]); |
|
1091 | + return new FromSupervisor(StoryTeller::instance(), [$hostId]); |
|
1092 | 1092 | } |
1093 | 1093 | |
1094 | 1094 | /** |
@@ -61,75 +61,75 @@ |
||
61 | 61 | |
62 | 62 | class Dsbuild_Adapter implements ProvisioningAdapter |
63 | 63 | { |
64 | - public function __construct() |
|
65 | - { |
|
66 | - $this->setExecutePath(getcwd() . DIRECTORY_SEPARATOR . "dsbuild.sh"); |
|
67 | - } |
|
68 | - |
|
69 | - // ================================================================== |
|
70 | - // |
|
71 | - // Support for executing the script |
|
72 | - // |
|
73 | - // ------------------------------------------------------------------ |
|
74 | - |
|
75 | - /** |
|
76 | - * where is the script that we are going to execute? |
|
77 | - * |
|
78 | - * @var string |
|
79 | - */ |
|
80 | - protected $executePath; |
|
81 | - |
|
82 | - /** |
|
83 | - * which folder are we executing things in? |
|
84 | - * |
|
85 | - * @return string |
|
86 | - */ |
|
87 | - public function getExecuteDir() |
|
88 | - { |
|
89 | - return dirname($this->executePath); |
|
90 | - } |
|
91 | - |
|
92 | - /** |
|
93 | - * where is the script that we are going to execute? |
|
94 | - * |
|
95 | - * @return string |
|
96 | - */ |
|
97 | - public function getExecutePath() |
|
98 | - { |
|
99 | - return $this->executePath; |
|
100 | - } |
|
101 | - |
|
102 | - /** |
|
103 | - * tell me which script to execute |
|
104 | - * |
|
105 | - * @param string $path |
|
106 | - * path to the dsbuild script |
|
107 | - */ |
|
108 | - public function setExecutePath($path) |
|
109 | - { |
|
110 | - $this->executePath = $path; |
|
111 | - |
|
112 | - return $this; |
|
113 | - } |
|
114 | - |
|
115 | - // ================================================================== |
|
116 | - // |
|
117 | - // SPv2.0-style config support |
|
118 | - // |
|
119 | - // ------------------------------------------------------------------ |
|
120 | - |
|
121 | - public function getAsConfig() |
|
122 | - { |
|
123 | - // our return value |
|
124 | - $retval = new BaseObject; |
|
125 | - |
|
126 | - // this is who we are |
|
127 | - $retval->engine = "dsbuild"; |
|
128 | - |
|
129 | - // this is what needs running |
|
130 | - $retval->execute = $this->getExecutePath(); |
|
131 | - |
|
132 | - // all done |
|
133 | - return $retval; |
|
134 | - } |
|
64 | + public function __construct() |
|
65 | + { |
|
66 | + $this->setExecutePath(getcwd() . DIRECTORY_SEPARATOR . "dsbuild.sh"); |
|
67 | + } |
|
68 | + |
|
69 | + // ================================================================== |
|
70 | + // |
|
71 | + // Support for executing the script |
|
72 | + // |
|
73 | + // ------------------------------------------------------------------ |
|
74 | + |
|
75 | + /** |
|
76 | + * where is the script that we are going to execute? |
|
77 | + * |
|
78 | + * @var string |
|
79 | + */ |
|
80 | + protected $executePath; |
|
81 | + |
|
82 | + /** |
|
83 | + * which folder are we executing things in? |
|
84 | + * |
|
85 | + * @return string |
|
86 | + */ |
|
87 | + public function getExecuteDir() |
|
88 | + { |
|
89 | + return dirname($this->executePath); |
|
90 | + } |
|
91 | + |
|
92 | + /** |
|
93 | + * where is the script that we are going to execute? |
|
94 | + * |
|
95 | + * @return string |
|
96 | + */ |
|
97 | + public function getExecutePath() |
|
98 | + { |
|
99 | + return $this->executePath; |
|
100 | + } |
|
101 | + |
|
102 | + /** |
|
103 | + * tell me which script to execute |
|
104 | + * |
|
105 | + * @param string $path |
|
106 | + * path to the dsbuild script |
|
107 | + */ |
|
108 | + public function setExecutePath($path) |
|
109 | + { |
|
110 | + $this->executePath = $path; |
|
111 | + |
|
112 | + return $this; |
|
113 | + } |
|
114 | + |
|
115 | + // ================================================================== |
|
116 | + // |
|
117 | + // SPv2.0-style config support |
|
118 | + // |
|
119 | + // ------------------------------------------------------------------ |
|
120 | + |
|
121 | + public function getAsConfig() |
|
122 | + { |
|
123 | + // our return value |
|
124 | + $retval = new BaseObject; |
|
125 | + |
|
126 | + // this is who we are |
|
127 | + $retval->engine = "dsbuild"; |
|
128 | + |
|
129 | + // this is what needs running |
|
130 | + $retval->execute = $this->getExecutePath(); |
|
131 | + |
|
132 | + // all done |
|
133 | + return $retval; |
|
134 | + } |
|
135 | 135 | } |
136 | 136 | \ No newline at end of file |
@@ -67,12 +67,12 @@ discard block |
||
67 | 67 | */ |
68 | 68 | public function getBaseFolder(); |
69 | 69 | |
70 | - /** |
|
71 | - * how do we validate any host adapters used by hosts in this group? |
|
72 | - * |
|
73 | - * @return HostAdapterValidator |
|
74 | - */ |
|
75 | - public function getHostAdapterValidator(); |
|
70 | + /** |
|
71 | + * how do we validate any host adapters used by hosts in this group? |
|
72 | + * |
|
73 | + * @return HostAdapterValidator |
|
74 | + */ |
|
75 | + public function getHostAdapterValidator(); |
|
76 | 76 | |
77 | 77 | /** |
78 | 78 | * what type of group are we? |
@@ -82,5 +82,5 @@ discard block |
||
82 | 82 | * |
83 | 83 | * @return string |
84 | 84 | */ |
85 | - public function getType(); |
|
85 | + public function getType(); |
|
86 | 86 | } |
87 | 87 | \ No newline at end of file |
@@ -61,15 +61,15 @@ |
||
61 | 61 | |
62 | 62 | interface HostAdapter |
63 | 63 | { |
64 | - /** |
|
65 | - * create an empty host definition for this kind of host |
|
66 | - * |
|
67 | - * @param TestEnvironment_GroupDefinition $groupDef |
|
68 | - * the group that we belong to |
|
69 | - * @param string $hostId |
|
70 | - * the alias for this host |
|
71 | - * @return object |
|
72 | - * a host definition to populate |
|
73 | - */ |
|
74 | - public function newHostDefinition(TestEnvironment_GroupDefinition $groupDef, $hostId); |
|
64 | + /** |
|
65 | + * create an empty host definition for this kind of host |
|
66 | + * |
|
67 | + * @param TestEnvironment_GroupDefinition $groupDef |
|
68 | + * the group that we belong to |
|
69 | + * @param string $hostId |
|
70 | + * the alias for this host |
|
71 | + * @return object |
|
72 | + * a host definition to populate |
|
73 | + */ |
|
74 | + public function newHostDefinition(TestEnvironment_GroupDefinition $groupDef, $hostId); |
|
75 | 75 | } |
76 | 76 | \ No newline at end of file |
@@ -59,13 +59,13 @@ |
||
59 | 59 | |
60 | 60 | interface HostAdapterValidator |
61 | 61 | { |
62 | - /** |
|
63 | - * check to make sure that a host adapter plugin is compatible with |
|
64 | - * the group adapter |
|
65 | - * |
|
66 | - * @param HostAdapter $hostAdapter |
|
67 | - * the adapter to validate |
|
68 | - * @return void |
|
69 | - */ |
|
70 | - public function validate(HostAdapter $hostAdapter); |
|
62 | + /** |
|
63 | + * check to make sure that a host adapter plugin is compatible with |
|
64 | + * the group adapter |
|
65 | + * |
|
66 | + * @param HostAdapter $hostAdapter |
|
67 | + * the adapter to validate |
|
68 | + * @return void |
|
69 | + */ |
|
70 | + public function validate(HostAdapter $hostAdapter); |
|
71 | 71 | } |
72 | 72 | \ No newline at end of file |
@@ -60,11 +60,11 @@ |
||
60 | 60 | interface OsAdapter |
61 | 61 | { |
62 | 62 | |
63 | - // ================================================================== |
|
64 | - // |
|
65 | - // Temporary features which will be removed in SP2.4 go here |
|
66 | - // |
|
67 | - // ------------------------------------------------------------------ |
|
63 | + // ================================================================== |
|
64 | + // |
|
65 | + // Temporary features which will be removed in SP2.4 go here |
|
66 | + // |
|
67 | + // ------------------------------------------------------------------ |
|
68 | 68 | |
69 | 69 | /** |
70 | 70 | * what is our operating system name? |