datasift / storyplayer

src/php/Storyplayer/SPv2/Modules/Asserts.php

Doc Comments +6 added lines, -6 removed lines

@@ -73,7 +73,7 @@ 
      *
      * @param  array $actual
      *         the array to be tested
-     * @return \Prose\AssertsArray
+     * @return AssertsArray
      */
     public static function assertsArray($actual)
     {
@@ -85,7 +85,7 @@ 
      *
      * @param  boolean $actual
      *         the data to be tested
-     * @return \Prose\AssertsBoolean
+     * @return AssertsBoolean
      */
     public static function assertsBoolean($actual)
     {
@@ -97,7 +97,7 @@ 
      *
      * @param  double $actual
      *         the data to be tested
-     * @return \Prose\AssertsDouble
+     * @return AssertsDouble
      */
     public static function assertsDouble($actual)
     {
@@ -109,7 +109,7 @@ 
      *
      * @param  int $actual
      *         the data to be tested
-     * @return \Prose\AssertsInteger
+     * @return AssertsInteger
      */
     public static function assertsInteger($actual)
     {
@@ -121,7 +121,7 @@ 
      *
      * @param  object $actual
      *         the data to be tested
-     * @return \Prose\AssertsObject
+     * @return AssertsObject
      */
     public static function assertsObject($actual)
     {
@@ -133,7 +133,7 @@ 
      *
      * @param  string $actual
      *         the data to be tested
-     * @return \Prose\AssertsString
+     * @return AssertsString
      */
     public static function assertsString($actual)
     {

src/php/Storyplayer/SPv2/Stories/BuildStory.php

Doc Comments -1 removed lines

@@ -50,7 +50,6 @@
     /**
      * Create a new story object
      *
-     * @param  string $category the category that the story belongs to
      * @return Story            the new story object to use
      */
     public static function newStory()

src/php/Storyplayer/SPv2/Modules/Browser/UsingBrowser.php

Doc Comments +8 added lines, -5 removed lines

@@ -72,7 +72,7 @@ 
     /**
      * tick a checkbox or radio button if it has not yet been checked
      *
-     * @return \DataSift\Storyplayer\BrowserLib\SingleElementAction
+     * @return SingleElementAction
      */
     public function check()
     {
@@ -101,7 +101,7 @@ 
      * remove any content from an input box, or untick a checkbox or
      * radio button
      *
-     * @return \DataSift\Storyplayer\BrowserLib\SingleElementAction
+     * @return SingleElementAction
      */
     public function clear()
     {
@@ -132,7 +132,7 @@ 
     /**
      * Send a 'click' to the selected element
      *
-     * @return \DataSift\Storyplayer\BrowserLib\SingleElementAction
+     * @return SingleElementAction
      */
     public function click()
     {
@@ -154,7 +154,7 @@ 
      *
      * @param  string $label
      *         the human-readable text of the option to select
-     * @return \DataSift\Storyplayer\BrowserLib\SingleElementAction
+     * @return SingleElementAction
      */
     public function select($label)
     {
@@ -185,7 +185,7 @@ 
      *
      * @param  string $text
      *         the text to type
-     * @return \DataSift\Storyplayer\BrowserLib\SingleElementAction
+     * @return SingleElementAction
      */
     public function type($text)
     {
@@ -214,6 +214,9 @@ 
     //
     // ------------------------------------------------------------------
 
+    /**
+     * @param string $url
+     */
     public function gotoPage($url)
     {
         // some shorthand to make things easier to read

Spacing +1 added lines, -1 removed lines

@@ -159,7 +159,7 @@
      */
     public function select($label)
     {
-        $action = function ($element, $elementName, $elementDesc) use ($label) {
+        $action = function($element, $elementName, $elementDesc) use ($label) {
 
             // what are we doing?
             $log = usingLog()->startAction("choose option '$label' from $elementDesc '$elementName'");

Braces +1 added lines, -2 removed lines

@@ -77,8 +77,7 @@
 
             return $return;
         }
-        catch (Exception $e)
-        {
+        catch (Exception $e) {
             throw new E5xx_ActionFailed(__METHOD__, $e->getMessage());
         }
     }

src/php/Storyplayer/SPv2/Modules/Browser/BaseElementAction.php

Spacing +5 added lines, -5 removed lines

@@ -121,11 +121,11 @@ 
 
     protected $tagTypes = array(
         'button'        => array('input', 'button'),
-        'buttons'       => array('input','button'),
+        'buttons'       => array('input', 'button'),
         'cell'          => 'td',
         'cells'         => 'td',
-        'heading'       => array('h1', 'h2', 'h3', 'h4', 'h5','h6'),
-        'headings'      => array('h1', 'h2', 'h3', 'h4', 'h5','h6'),
+        'heading'       => array('h1', 'h2', 'h3', 'h4', 'h5', 'h6'),
+        'headings'      => array('h1', 'h2', 'h3', 'h4', 'h5', 'h6'),
         'link'          => 'a',
         'links'         => 'a',
         'orderedlist'   => 'ol',
@@ -154,7 +154,7 @@ 
         'unorderedlist' => self::SINGLE_TARGET
     );
 
-    protected $searchTypes = array (
+    protected $searchTypes = array(
         'id'            => 'ById',
         'label'         => 'ByLabel',
         'labelled'      => 'ByLabel',
@@ -296,7 +296,7 @@ 
     {
         // we need to know which element they want
         $words = $this->convertMethodNameToWords($methodName);
-        $indexType  = $this->determineIndexType($words);
+        $indexType = $this->determineIndexType($words);
 
         // get all the elements that match
         $elements = $this->retrieveElements($methodName, $methodArgs);

Braces +2 added lines, -1 removed lines

@@ -323,7 +323,8 @@
         $searchTerm = $methodArgs[0];
 
         $searchType = $this->determineSearchType($words);
-        if ($searchType === null) {             // we do not understand how to find the target field
+        if ($searchType === null) {
+// we do not understand how to find the target field
             throw new E5xx_ActionFailed(__CLASS__ . '::' . $methodName, "could not work out how to find the target to action upon");
         }
 

src/php/Storyplayer/SPv2/Modules/Browser/DomElementSearch.php

Braces +2 added lines, -4 removed lines

@@ -245,8 +245,7 @@ 
 
         // search all of the label elements to find an associated input
         // element that we can safely use
-        foreach ($labelElements as $labelElement)
-        {
+        foreach ($labelElements as $labelElement) {
             try {
                 // add each element that matches this label
                 $retval[] = $this->getElementAssociatedWithLabelElement($labelElement, $labelText);
@@ -289,8 +288,7 @@ 
         }
 
         // what do we do next?
-        if ($inputElementId !== null)
-        {
+        if ($inputElementId !== null) {
             // where does the 'for' attribute go?
             try {
                 $inputElement = $log->addStep("find the input element with the id '{$inputElementId}'", function() use($topElement, $inputElementId) {

src/php/Storyplayer/SPv2/Modules/Browser/ExpectsBrowser.php

Spacing +1 added lines, -1 removed lines

@@ -121,7 +121,7 @@
             $log = usingLog()->startAction("$elementDesc '$elementName' must exist");
 
             $actualCount = count($elements);
-            switch($requiredCount) {
+            switch ($requiredCount) {
                 // this satisfies something like:
                 //
                 // expectsBrowser()->has()->fieldWithId('XX');

src/php/Storyplayer/SPv2/Modules/Browser/FromBrowser.php

Spacing +1 added lines, -1 removed lines

@@ -272,7 +272,7 @@
             $log = usingLog()->startAction("retrieve the value of the $elementDesc '$elementName'");
 
             // is this a select box?
-            switch($element->name()) {
+            switch ($element->name()) {
                 case 'select':
                     // get the option that is selected
                     try {

Braces +2 added lines, -4 removed lines

@@ -350,8 +350,7 @@ 
             // all done
             return $credentials;
         }
-        catch (Exception $e)
-        {
+        catch (Exception $e) {
             return null;
         }
     }
@@ -370,8 +369,7 @@ 
             // get the details
             return $adapter->hasHttpBasicAuthForHost($hostname);
         }
-        catch (Exception $e)
-        {
+        catch (Exception $e) {
             return false;
         }
     }

src/php/Storyplayer/SPv2/Modules/Browser/MultiElementAction.php

Spacing +1 added lines, -1 removed lines

@@ -87,7 +87,7 @@
         $words = $this->convertMethodNameToWords($methodName);
 
         // how many elements are we searching for?
-        $countType  = $this->determineCountType($words);
+        $countType = $this->determineCountType($words);
 
         // get the elements we need
         $elements = $this->retrieveElements($methodName, $methodArgs);

src/php/Storyplayer/SPv2/Modules/Browser/FromForm.php

Spacing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
         }
 
         // yes, it really is a form
-        $this->formId      = $formId;
+        $this->formId = $formId;
         $this->setTopElement($formElement);
     }