datasift / storyplayer

src/php/Prose/UsingProvisioningDefinition.php

Spacing +4 added lines, -4 removed lines

@@ -67,7 +67,7 @@ 
         parent::__construct($st, $args);
 
         // $args[0] should be our provisioning block
-        if (!isset($args[0]) || ! $args[0] instanceof ProvisioningDefinition) {
+        if (!isset($args[0]) || !$args[0] instanceof ProvisioningDefinition) {
             throw new E5xx_ActionFailed(__METHOD__, "Param #0 must be a ProvisioningDefinition object");
         }
     }
@@ -111,7 +111,7 @@ 
         };
 
         // build our return object
-        $return = new DelayedProvisioningDefinitionAction (
+        $return = new DelayedProvisioningDefinitionAction(
             $this->args[0],
             $action
         );
@@ -144,7 +144,7 @@ 
         };
 
         // build our return object
-        $return = new DelayedProvisioningDefinitionAction (
+        $return = new DelayedProvisioningDefinitionAction(
             $this->args[0],
             $action
         );
@@ -173,7 +173,7 @@ 
         };
 
         // build our return object
-        $return = new DelayedProvisioningDefinitionAction (
+        $return = new DelayedProvisioningDefinitionAction(
             $this->args[0],
             $action
         );

src/php/Prose/UsingRedisConn.php

Braces +1 added lines, -2 removed lines

@@ -77,8 +77,7 @@
 
             return $return;
         }
-        catch (Exception $e)
-        {
+        catch (Exception $e) {
             throw new E5xx_ActionFailed(__METHOD__, $e->getMessage());
         }
     }

src/php/Prose/UsingVagrant.php

Spacing +1 added lines, -1 removed lines

@@ -84,7 +84,7 @@
             "-o UserKnownHostsFile=/dev/null",
             "-o LogLevel=quiet",
         ];
-        $vmDetails->scpOptions  = [
+        $vmDetails->scpOptions = [
             "-i '" . $vmDetails->sshKeyFile . "'",
             "-o StrictHostKeyChecking=no",
         ];

Braces +1 added lines, -2 removed lines

@@ -115,8 +115,7 @@
             getenv("HOME") . "/.vagrant.d/insecure_private_key"
         ];
 
-        foreach ($keyFilenames as $keyFilename)
-        {
+        foreach ($keyFilenames as $keyFilename) {
             usingLog()->writeToLog("checking if {$keyFilename} exists");
             if (file_exists($keyFilename)) {
                 $log->endAction($keyFilename);

src/php/Prose/UsingZookeeper.php

Spacing +3 added lines, -3 removed lines

@@ -62,7 +62,7 @@ 
     protected $host;
     protected $zk;
 
-    protected $default_acl = array( array(
+    protected $default_acl = array(array(
         "perms"  => Zookeeper::PERM_ALL,
         "scheme" => "world",
         "id"     => "anyone"
@@ -117,10 +117,10 @@ 
         }
 
         // drop the last part, as that is the key itself
-        unset($parts[count($parts) -1]);
+        unset($parts[count($parts) - 1]);
 
         // start with an empty path
-        $path  = '';
+        $path = '';
 
         // work through the parts, building up the path to create from
         // the root of the directory

Braces +5 added lines, -6 removed lines

@@ -124,16 +124,14 @@ 
 
         // work through the parts, building up the path to create from
         // the root of the directory
-        foreach ($parts as $part)
-        {
+        foreach ($parts as $part) {
             // expand our path to the next part
             $path .= '/' . $part;
 
             // does this path exist?
             if (!$this->zk->exists($path)) {
                 // no - create it
-                if (!$this->zk->create($path, 1, $this->default_acl))
-                {
+                if (!$this->zk->create($path, 1, $this->default_acl)) {
                     // failed to create the entry
                     throw Exceptions::newActionFailedException(__METHOD__);
                 }
@@ -151,8 +149,9 @@ 
 
         // now we can safely set the key itself
         if (!$this->zk->exists($key)) {
-            if (!$this->zk->create($key, $value, $this->default_acl))
-                throw Exceptions::newActionFailedException(__METHOD__);
+            if (!$this->zk->create($key, $value, $this->default_acl)) {
+                            throw Exceptions::newActionFailedException(__METHOD__);
+            }
         }
         else if (!$this->zk->set($key, $value)) {
             throw Exceptions::newActionFailedException(__METHOD__);

src/php/Storyplayer/TestEnvironments/Dsbuild/Adapter.php

Indentation +71 added lines, -71 removed lines

@@ -61,75 +61,75 @@
 
 class Dsbuild_Adapter implements ProvisioningAdapter
 {
-	public function __construct()
-	{
-		$this->setExecutePath(getcwd() . DIRECTORY_SEPARATOR . "dsbuild.sh");
-	}
-
-	// ==================================================================
-	//
-	// Support for executing the script
-	//
-	// ------------------------------------------------------------------
-
-	/**
-	 * where is the script that we are going to execute?
-	 *
-	 * @var string
-	 */
-	protected $executePath;
-
-	/**
-	 * which folder are we executing things in?
-	 *
-	 * @return string
-	 */
-	public function getExecuteDir()
-	{
-		return dirname($this->executePath);
-	}
-
-	/**
-	 * where is the script that we are going to execute?
-	 *
-	 * @return string
-	 */
-	public function getExecutePath()
-	{
-		return $this->executePath;
-	}
-
-	/**
-	 * tell me which script to execute
-	 *
-	 * @param string $path
-	 *        path to the dsbuild script
-	 */
-	public function setExecutePath($path)
-	{
-		$this->executePath = $path;
-
-		return $this;
-	}
-
-	// ==================================================================
-	//
-	// SPv2.0-style config support
-	//
-	// ------------------------------------------------------------------
-
-	public function getAsConfig()
-	{
-		// our return value
-		$retval = new BaseObject;
-
-		// this is who we are
-		$retval->engine = "dsbuild";
-
-		// this is what needs running
-		$retval->execute = $this->getExecutePath();
-
-		// all done
-		return $retval;
-	}
+    public function __construct()
+    {
+        $this->setExecutePath(getcwd() . DIRECTORY_SEPARATOR . "dsbuild.sh");
+    }
+
+    // ==================================================================
+    //
+    // Support for executing the script
+    //
+    // ------------------------------------------------------------------
+
+    /**
+     * where is the script that we are going to execute?
+     *
+     * @var string
+     */
+    protected $executePath;
+
+    /**
+     * which folder are we executing things in?
+     *
+     * @return string
+     */
+    public function getExecuteDir()
+    {
+        return dirname($this->executePath);
+    }
+
+    /**
+     * where is the script that we are going to execute?
+     *
+     * @return string
+     */
+    public function getExecutePath()
+    {
+        return $this->executePath;
+    }
+
+    /**
+     * tell me which script to execute
+     *
+     * @param string $path
+     *        path to the dsbuild script
+     */
+    public function setExecutePath($path)
+    {
+        $this->executePath = $path;
+
+        return $this;
+    }
+
+    // ==================================================================
+    //
+    // SPv2.0-style config support
+    //
+    // ------------------------------------------------------------------
+
+    public function getAsConfig()
+    {
+        // our return value
+        $retval = new BaseObject;
+
+        // this is who we are
+        $retval->engine = "dsbuild";
+
+        // this is what needs running
+        $retval->execute = $this->getExecutePath();
+
+        // all done
+        return $retval;
+    }
 }
\ No newline at end of file

src/php/Storyplayer/TestEnvironments/GroupAdapter.php

Indentation +7 added lines, -7 removed lines

@@ -67,12 +67,12 @@ 
      */
     public function getBaseFolder();
 
-	/**
-	 * how do we validate any host adapters used by hosts in this group?
-	 *
-	 * @return HostAdapterValidator
-	 */
-	public function getHostAdapterValidator();
+    /**
+     * how do we validate any host adapters used by hosts in this group?
+     *
+     * @return HostAdapterValidator
+     */
+    public function getHostAdapterValidator();
 
     /**
      * what type of group are we?
@@ -82,5 +82,5 @@ 
      *
      * @return string
      */
-	public function getType();
+    public function getType();
 }
\ No newline at end of file

src/php/Storyplayer/TestEnvironments/HostAdapter.php

Indentation +11 added lines, -11 removed lines

@@ -61,15 +61,15 @@
 
 interface HostAdapter
 {
-	/**
-	 * create an empty host definition for this kind of host
-	 *
-	 * @param  TestEnvironment_GroupDefinition $groupDef
-	 *         the group that we belong to
-	 * @param  string $hostId
-	 *         the alias for this host
-	 * @return object
-	 *         a host definition to populate
-	 */
-	public function newHostDefinition(TestEnvironment_GroupDefinition $groupDef, $hostId);
+    /**
+     * create an empty host definition for this kind of host
+     *
+     * @param  TestEnvironment_GroupDefinition $groupDef
+     *         the group that we belong to
+     * @param  string $hostId
+     *         the alias for this host
+     * @return object
+     *         a host definition to populate
+     */
+    public function newHostDefinition(TestEnvironment_GroupDefinition $groupDef, $hostId);
 }
\ No newline at end of file

src/php/Storyplayer/TestEnvironments/HostAdapterValidator.php

Indentation +9 added lines, -9 removed lines

@@ -59,13 +59,13 @@
 
 interface HostAdapterValidator
 {
-	/**
-	 * check to make sure that a host adapter plugin is compatible with
-	 * the group adapter
-	 *
-	 * @param  HostAdapter $hostAdapter
-	 *         the adapter to validate
-	 * @return void
-	 */
-	public function validate(HostAdapter $hostAdapter);
+    /**
+     * check to make sure that a host adapter plugin is compatible with
+     * the group adapter
+     *
+     * @param  HostAdapter $hostAdapter
+     *         the adapter to validate
+     * @return void
+     */
+    public function validate(HostAdapter $hostAdapter);
 }
\ No newline at end of file

src/php/Storyplayer/TestEnvironments/OsAdapter.php

Indentation +5 added lines, -5 removed lines

@@ -60,11 +60,11 @@
 interface OsAdapter
 {
 
-	// ==================================================================
-	//
-	// Temporary features which will be removed in SP2.4 go here
-	//
-	// ------------------------------------------------------------------
+    // ==================================================================
+    //
+    // Temporary features which will be removed in SP2.4 go here
+    //
+    // ------------------------------------------------------------------
 
     /**
      * what is our operating system name?