datasift / storyplayer

src/php/Prose/UsingRedisConn.php

Braces +1 added lines, -2 removed lines

@@ -77,8 +77,7 @@
 
             return $return;
         }
-        catch (Exception $e)
-        {
+        catch (Exception $e) {
             throw new E5xx_ActionFailed(__METHOD__, $e->getMessage());
         }
     }

src/php/Prose/UsingRuntimeTable.php

Spacing +4 added lines, -4 removed lines

@@ -74,14 +74,14 @@ 
         $tables = $this->getAllTables();
 
         // make sure it exists
-        if (!isset($tables->$tableName)){
+        if (!isset($tables->$tableName)) {
             $log->addStep("{$tableName} does not exist in the runtime config. creating empty table", function() use ($tables, $tableName){
                 $tables->$tableName = new BaseObject();
             });
         }
 
         // make sure we don't have a duplicate entry
-        if (isset($tables->$tableName->$key)){
+        if (isset($tables->$tableName->$key)) {
             $msg = "Table already contains an entry for '{$key}'";
             $log->endAction($msg);
             throw new E5xx_ActionFailed(__METHOD__, $msg);
@@ -171,7 +171,7 @@ 
         $tables = $this->getAllTables();
 
         // make sure it exists
-        if (!isset($tables->$tableName)){
+        if (!isset($tables->$tableName)) {
             $tables->$tableName = new BaseObject();
         }
         if (!isset($tables->$tableName->$group)) {
@@ -179,7 +179,7 @@ 
         }
 
         // make sure we don't have a duplicate entry
-        if (isset($tables->$tableName->$group->$key)){
+        if (isset($tables->$tableName->$group->$key)) {
             $msg = "table already contains an entry for '{$group}->{$key}'";
             $log->endAction($msg);
             throw new E5xx_ActionFailed(__METHOD__, $msg);

Braces +7 added lines, -7 removed lines

@@ -74,14 +74,14 @@ 
         $tables = $this->getAllTables();
 
         // make sure it exists
-        if (!isset($tables->$tableName)){
-            $log->addStep("{$tableName} does not exist in the runtime config. creating empty table", function() use ($tables, $tableName){
+        if (!isset($tables->$tableName)) {
+            $log->addStep("{$tableName} does not exist in the runtime config. creating empty table", function() use ($tables, $tableName) {
                 $tables->$tableName = new BaseObject();
             });
         }
 
         // make sure we don't have a duplicate entry
-        if (isset($tables->$tableName->$key)){
+        if (isset($tables->$tableName->$key)) {
             $msg = "Table already contains an entry for '{$key}'";
             $log->endAction($msg);
             throw new E5xx_ActionFailed(__METHOD__, $msg);
@@ -211,7 +211,7 @@ 
         $tables = $this->getAllTables();
 
         // make sure it exists
-        if (!isset($tables->$tableName)){
+        if (!isset($tables->$tableName)) {
             $tables->$tableName = new BaseObject();
         }
         if (!isset($tables->$tableName->$group)) {
@@ -219,7 +219,7 @@ 
         }
 
         // make sure we don't have a duplicate entry
-        if (isset($tables->$tableName->$group->$key)){
+        if (isset($tables->$tableName->$group->$key)) {
             $msg = "table already contains an entry for '{$group}->{$key}'";
             $log->endAction($msg);
             throw new E5xx_ActionFailed(__METHOD__, $msg);
@@ -285,7 +285,7 @@ 
 
         // remove the table if it's empty
         if (!count(get_object_vars($tables->$tableName->$group))) {
-            $log->addStep("table group '{$tableName}->{$group}' is empty, removing from runtime config", function() use ($tables, $tableName, $group){
+            $log->addStep("table group '{$tableName}->{$group}' is empty, removing from runtime config", function() use ($tables, $tableName, $group) {
                 unset($tables->$tableName->$group);
             });
         }
@@ -335,7 +335,7 @@ 
 
                 // remove the table if it's empty
                 if (!count(get_object_vars($tables->$tableName->$group))) {
-                    $log->addStep("table group '{$tableName}->{$group}' is empty, removing from runtime config", function() use ($tables, $tableName, $group){
+                    $log->addStep("table group '{$tableName}->{$group}' is empty, removing from runtime config", function() use ($tables, $tableName, $group) {
                         unset($tables->$tableName->$group);
                     });
                 }

src/php/Prose/UsingVagrant.php

Spacing +1 added lines, -1 removed lines

@@ -84,7 +84,7 @@
             "-o UserKnownHostsFile=/dev/null",
             "-o LogLevel=quiet",
         ];
-        $vmDetails->scpOptions  = [
+        $vmDetails->scpOptions = [
             "-i '" . $vmDetails->sshKeyFile . "'",
             "-o StrictHostKeyChecking=no",
         ];

Braces +1 added lines, -2 removed lines

@@ -115,8 +115,7 @@
             getenv("HOME") . "/.vagrant.d/insecure_private_key"
         ];
 
-        foreach ($keyFilenames as $keyFilename)
-        {
+        foreach ($keyFilenames as $keyFilename) {
             usingLog()->writeToLog("checking if {$keyFilename} exists");
             if (file_exists($keyFilename)) {
                 $log->endAction($keyFilename);

src/php/Prose/UsingZmq.php

Spacing +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
  */
 class UsingZmq extends Prose
 {
-    protected $socketMap = array (
+    protected $socketMap = array(
         ZMQ::SOCKET_PUB => "ZMQ::SOCKET_PUB",
         ZMQ::SOCKET_SUB => "ZMQ::SOCKET_SUB",
         ZMQ::SOCKET_REQ => "ZMQ::SOCKET_REQ",

src/php/Prose/UsingZmqSocket.php

Spacing +2 added lines, -2 removed lines

@@ -96,7 +96,7 @@ 
         // where are we unbinding from?
         $endpoints = fromZmqSocket($this->args[0])->getEndpoints();
 
-        foreach($endpoints['bind'] as $address) {
+        foreach ($endpoints['bind'] as $address) {
             usingLog()->writeToLog("unbinding from {$address}");
             $this->args[0]->unbind($address);
         }
@@ -156,7 +156,7 @@ 
         // where are we disconnecting from?
         $endpoints = fromZmqSocket($this->args[0])->getEndpoints();
 
-        foreach($endpoints['connect'] as $address) {
+        foreach ($endpoints['connect'] as $address) {
             usingLog()->writeToLog("disconnecting from {$address}");
             $this->args[0]->disconnect($address);
         }

src/php/Prose/UsingZookeeper.php

Spacing +3 added lines, -3 removed lines

@@ -62,7 +62,7 @@ 
     protected $host;
     protected $zk;
 
-    protected $default_acl = array( array(
+    protected $default_acl = array(array(
         "perms"  => Zookeeper::PERM_ALL,
         "scheme" => "world",
         "id"     => "anyone"
@@ -117,10 +117,10 @@ 
         }
 
         // drop the last part, as that is the key itself
-        unset($parts[count($parts) -1]);
+        unset($parts[count($parts) - 1]);
 
         // start with an empty path
-        $path  = '';
+        $path = '';
 
         // work through the parts, building up the path to create from
         // the root of the directory

Braces +5 added lines, -6 removed lines

@@ -124,16 +124,14 @@ 
 
         // work through the parts, building up the path to create from
         // the root of the directory
-        foreach ($parts as $part)
-        {
+        foreach ($parts as $part) {
             // expand our path to the next part
             $path .= '/' . $part;
 
             // does this path exist?
             if (!$this->zk->exists($path)) {
                 // no - create it
-                if (!$this->zk->create($path, 1, $this->default_acl))
-                {
+                if (!$this->zk->create($path, 1, $this->default_acl)) {
                     // failed to create the entry
                     throw new E5xx_ActionFailed(__METHOD__);
                 }
@@ -151,8 +149,9 @@ 
 
         // now we can safely set the key itself
         if (!$this->zk->exists($key)) {
-            if (!$this->zk->create($key, $value, $this->default_acl))
-                throw new E5xx_ActionFailed(__METHOD__);
+            if (!$this->zk->create($key, $value, $this->default_acl)) {
+                            throw new E5xx_ActionFailed(__METHOD__);
+            }
         }
         else if (!$this->zk->set($key, $value)) {
             throw new E5xx_ActionFailed(__METHOD__);

src/php/Prose/functions.php

Spacing +1 added lines, -1 removed lines

@@ -1088,7 +1088,7 @@
  */
 function fromSupervisor($hostId)
 {
-    return new FromSupervisor(StoryTeller::instance(),[$hostId]);
+    return new FromSupervisor(StoryTeller::instance(), [$hostId]);
 }
 
 /**

src/php/Storyplayer/TestEnvironments/Dsbuild/Adapter.php

Indentation +71 added lines, -71 removed lines

@@ -61,75 +61,75 @@
 
 class Dsbuild_Adapter implements ProvisioningAdapter
 {
-	public function __construct()
-	{
-		$this->setExecutePath(getcwd() . DIRECTORY_SEPARATOR . "dsbuild.sh");
-	}
-
-	// ==================================================================
-	//
-	// Support for executing the script
-	//
-	// ------------------------------------------------------------------
-
-	/**
-	 * where is the script that we are going to execute?
-	 *
-	 * @var string
-	 */
-	protected $executePath;
-
-	/**
-	 * which folder are we executing things in?
-	 *
-	 * @return string
-	 */
-	public function getExecuteDir()
-	{
-		return dirname($this->executePath);
-	}
-
-	/**
-	 * where is the script that we are going to execute?
-	 *
-	 * @return string
-	 */
-	public function getExecutePath()
-	{
-		return $this->executePath;
-	}
-
-	/**
-	 * tell me which script to execute
-	 *
-	 * @param string $path
-	 *        path to the dsbuild script
-	 */
-	public function setExecutePath($path)
-	{
-		$this->executePath = $path;
-
-		return $this;
-	}
-
-	// ==================================================================
-	//
-	// SPv2.0-style config support
-	//
-	// ------------------------------------------------------------------
-
-	public function getAsConfig()
-	{
-		// our return value
-		$retval = new BaseObject;
-
-		// this is who we are
-		$retval->engine = "dsbuild";
-
-		// this is what needs running
-		$retval->execute = $this->getExecutePath();
-
-		// all done
-		return $retval;
-	}
+    public function __construct()
+    {
+        $this->setExecutePath(getcwd() . DIRECTORY_SEPARATOR . "dsbuild.sh");
+    }
+
+    // ==================================================================
+    //
+    // Support for executing the script
+    //
+    // ------------------------------------------------------------------
+
+    /**
+     * where is the script that we are going to execute?
+     *
+     * @var string
+     */
+    protected $executePath;
+
+    /**
+     * which folder are we executing things in?
+     *
+     * @return string
+     */
+    public function getExecuteDir()
+    {
+        return dirname($this->executePath);
+    }
+
+    /**
+     * where is the script that we are going to execute?
+     *
+     * @return string
+     */
+    public function getExecutePath()
+    {
+        return $this->executePath;
+    }
+
+    /**
+     * tell me which script to execute
+     *
+     * @param string $path
+     *        path to the dsbuild script
+     */
+    public function setExecutePath($path)
+    {
+        $this->executePath = $path;
+
+        return $this;
+    }
+
+    // ==================================================================
+    //
+    // SPv2.0-style config support
+    //
+    // ------------------------------------------------------------------
+
+    public function getAsConfig()
+    {
+        // our return value
+        $retval = new BaseObject;
+
+        // this is who we are
+        $retval->engine = "dsbuild";
+
+        // this is what needs running
+        $retval->execute = $this->getExecutePath();
+
+        // all done
+        return $retval;
+    }
 }
\ No newline at end of file

src/php/Storyplayer/TestEnvironments/GroupAdapter.php

Indentation +7 added lines, -7 removed lines

@@ -67,12 +67,12 @@ 
      */
     public function getBaseFolder();
 
-	/**
-	 * how do we validate any host adapters used by hosts in this group?
-	 *
-	 * @return HostAdapterValidator
-	 */
-	public function getHostAdapterValidator();
+    /**
+     * how do we validate any host adapters used by hosts in this group?
+     *
+     * @return HostAdapterValidator
+     */
+    public function getHostAdapterValidator();
 
     /**
      * what type of group are we?
@@ -82,5 +82,5 @@ 
      *
      * @return string
      */
-	public function getType();
+    public function getType();
 }
\ No newline at end of file