datasift / storyplayer

src/php/DataSift/Storyplayer/Injectables/E4xx/NoSuchTestEnvironment.php

Indentation +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
     public function __construct($envName)
     {
         $msg = "Unknown test environment '{$envName}'; we have no config for it" . PHP_EOL . PHP_EOL
-             . "Use 'storyplayer list-test-environments' to see the list of known test environments";
+                . "Use 'storyplayer list-test-environments' to see the list of known test environments";
         parent::__construct(400, $msg, $msg);
     }
 }
\ No newline at end of file

src/php/DataSift/Storyplayer/OsLib/Base/Unix.php

Spacing +1 added lines, -1 removed lines

@@ -221,7 +221,7 @@
 
         // SSH in and have a look
         $command = "ps -ef | grep '{$pid}'";
-        $result    = $this->runCommand($hostDetails, $command);
+        $result = $this->runCommand($hostDetails, $command);
 
         // what did we find?
         if ($result->didCommandFail() || empty($result->output)) {

Braces +1 added lines, -2 removed lines

@@ -76,8 +76,7 @@
         // how do we do this?
         if (isset($hostDetails->hostname)) {
             $ipAddress = gethostbyname($hostDetails->hostname);
-            if ($ipAddress != $hostDetails->hostname)
-            {
+            if ($ipAddress != $hostDetails->hostname) {
                 $log->endAction(["IP address is", $ipAddress]);
                 return $ipAddress;
             }

src/php/DataSift/Storyplayer/OsLib/OsBase.php

Spacing +1 added lines, -1 removed lines

@@ -128,7 +128,7 @@
             //
             // most of the world uses 127.0.0.1
             // ubuntu uses 127.0.1.1 (no idea why)
-            $validIps = [ '127.0.0.1', '127.0.1.1' ];
+            $validIps = ['127.0.0.1', '127.0.1.1'];
             if (!in_array($hostDetails->ipAddress, $validIps)) {
                 // this hostname is *not* safe
                 //

src/php/DataSift/Storyplayer/Output.php

Spacing +7 added lines, -7 removed lines

@@ -258,10 +258,10 @@ 
     public function startStoryplayer($version, $url, $copyright, $license)
     {
         // enforce our inputs
-        Contract::RequiresValue($version,   is_string($version));
-        Contract::RequiresValue($url,       is_string($url));
+        Contract::RequiresValue($version, is_string($version));
+        Contract::RequiresValue($url, is_string($url));
         Contract::RequiresValue($copyright, is_string($copyright));
-        Contract::RequiresValue($license,   is_string($license));
+        Contract::RequiresValue($license, is_string($license));
 
         // call all of our plugins
         foreach ($this->plugins as $plugin)
@@ -298,7 +298,7 @@ 
     {
         // ensure our inputs!
         Contract::RequiresValue($activity, is_string($activity));
-        Contract::RequiresValue($name,     is_string($name));
+        Contract::RequiresValue($name, is_string($name));
 
         // call our plugins
         foreach ($this->plugins as $plugin)
@@ -364,7 +364,7 @@ 
 
         // inject the captured activity into the phase
         $phaseResult->activityLog = $this->activityLog;
-        $this->activityLog=[];
+        $this->activityLog = [];
 
         // pass the phase on
         foreach ($this->plugins as $plugin)
@@ -447,7 +447,7 @@ 
     {
         // enforce our inputs
         Contract::RequiresValue($phaseName, is_string($phaseName));
-        Contract::RequiresValue($msg,       is_string($msg));
+        Contract::RequiresValue($msg, is_string($msg));
 
         // keep track of what was attempted, in case we need to show
         // the user what was attempted
@@ -477,7 +477,7 @@ 
     {
         // enforce our inputs
         Contract::RequiresValue($phaseName, is_string($phaseName));
-        Contract::RequiresValue($msg,       is_string($msg));
+        Contract::RequiresValue($msg, is_string($msg));
 
         // keep track of what was attempted, in case we need to show
         // the user what was attempted

Braces +22 added lines, -44 removed lines

@@ -179,8 +179,7 @@ 
      */
     public function resetSilentMode()
     {
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->resetSilentMode();
         }
     }
@@ -196,8 +195,7 @@ 
      */
     public function setSilentMode()
     {
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->setSilentMode();
         }
     }
@@ -213,8 +211,7 @@ 
      */
     public function setIsVerbose($isVerbose)
     {
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->setIsVerbose($isVerbose);
         }
     }
@@ -226,8 +223,7 @@ 
      */
     public function disableColourSupport()
     {
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->disableColourSupport();
         }
     }
@@ -239,8 +235,7 @@ 
      */
     public function enforceColourSupport()
     {
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->enforceColourSupport();
         }
     }
@@ -257,8 +252,7 @@ 
      */
     public function enableColourSupport()
     {
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->enableColourSupport();
         }
     }
@@ -281,8 +275,7 @@ 
         Contract::RequiresValue($license,   is_string($license));
 
         // call all of our plugins
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->startStoryplayer($version, $url, $copyright, $license);
         }
     }
@@ -296,8 +289,7 @@ 
      */
     public function endStoryplayer($duration)
     {
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->endStoryplayer($duration);
         }
     }
@@ -321,8 +313,7 @@ 
         Contract::RequiresValue($name,     is_string($name));
 
         // call our plugins
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->startPhaseGroup($activity, $name, $details);
         }
     }
@@ -343,8 +334,7 @@ 
         Contract::Requires($result instanceof PhaseGroup_Result);
 
         // call our plugins
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->endPhaseGroup($result);
         }
     }
@@ -361,8 +351,7 @@ 
         // enforce our input type
         Contract::Requires($phase instanceof Phase);
 
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->startPhase($phase);
         }
     }
@@ -387,8 +376,7 @@ 
         $this->activityLog=[];
 
         // pass the phase on
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->endPhase($phase, $phaseResult);
         }
     }
@@ -420,8 +408,7 @@ 
         ];
 
         // call all of our plugins
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->logPhaseActivity($msg, $codeLine);
         }
     }
@@ -448,8 +435,7 @@ 
         ];
 
         // call all of our plugins
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->logPhaseSubprocessOutput($msg);
         }
     }
@@ -478,8 +464,7 @@ 
         ];
 
         // call all of our plugins
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->logPhaseError($phaseName, $msg);
         }
     }
@@ -508,8 +493,7 @@ 
         ];
 
         // call all of our plugins
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->logPhaseSkipped($phaseName, $msg);
         }
     }
@@ -528,8 +512,7 @@ 
         Contract::RequiresValue($codeLine, is_array($codeLine));
 
         // pass it on to all of our plugins
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->logPhaseCodeLine($codeLine);
         }
     }
@@ -548,8 +531,7 @@ 
         Contract::RequiresValue($msg, is_string($msg));
 
         // pass it on to our plugins
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->logCliError($msg);
         }
     }
@@ -570,8 +552,7 @@ 
         Contract::RequiresValue($e, $e instanceof Exception);
 
         // pass this on to our plugins
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->logCliErrorWithException($msg, $e);
         }
     }
@@ -590,8 +571,7 @@ 
         Contract::RequiresValue($msg, is_string($msg));
 
         // pass this on to our plugins
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->logCliWarning($msg);
         }
     }
@@ -610,8 +590,7 @@ 
         Contract::RequiresValue($msg, is_string($msg));
 
         // pass this on to our plugins
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->logCliInfo($msg);
         }
     }
@@ -634,8 +613,7 @@ 
         // $var can be anything, so there is no contract to enforce
 
         // pass this on to our plugins
-        foreach ($this->plugins as $plugin)
-        {
+        foreach ($this->plugins as $plugin) {
             $plugin->logVardump($name, $var);
         }
     }

src/php/DataSift/Storyplayer/OutputLib/E4xx/OutputFilenameIsAReservedName.php

Braces +2 added lines, -1 removed lines

@@ -58,7 +58,8 @@
  */
 class E4xx_OutputFilenameIsAReservedName extends Exxx_Exception
 {
-    public function __construct($filename) {
+    public function __construct($filename)
+    {
         $msg = "'{$filename}' is reserved for internal use; please use a different filename";
         parent::__construct(400, $msg, $msg);
     }

src/php/DataSift/Storyplayer/OutputLib/OutputPlugin.php

Spacing +1 added lines, -1 removed lines

@@ -98,7 +98,7 @@
     public function addOutputToFile($filename)
     {
         // make sure $filename isn't a reserved name
-        switch($filename)
+        switch ($filename)
         {
             case 'stdout':
             case 'stderr':

Braces +1 added lines, -2 removed lines

@@ -98,8 +98,7 @@
     public function addOutputToFile($filename)
     {
         // make sure $filename isn't a reserved name
-        switch($filename)
-        {
+        switch($filename) {
             case 'stdout':
             case 'stderr':
             case 'null':

src/php/DataSift/Storyplayer/OutputLib/OutputWriter.php

Indentation +2 added lines, -2 removed lines

@@ -230,8 +230,8 @@
     {
         // if we get here, then yes we do
         return sprintf(ConsoleColor::ESCAPE_SEQUENCE, \implode(';', $style))
-               . $output
-               . sprintf(ConsoleColor::ESCAPE_SEQUENCE, ConsoleColor::NONE);
+                . $output
+                . sprintf(ConsoleColor::ESCAPE_SEQUENCE, ConsoleColor::NONE);
     }
 
     // ==================================================================

Spacing +1 added lines, -1 removed lines

@@ -82,7 +82,7 @@
     public $argumentsHeadingStyle = null;
     public $failedPhaseStyle = null;
 
-    protected $outputHandles  = [];
+    protected $outputHandles = [];
 
     public function __construct()
     {

Braces +2 added lines, -4 removed lines

@@ -171,8 +171,7 @@ 
 
     public function setColourMode($mode)
     {
-        switch ($mode)
-        {
+        switch ($mode) {
             case OutputPlugin::COLOUR_MODE_OFF:
                 foreach ($this->outputHandles as $index => $outputHandle) {
                     if ($outputHandle['colour']) {
@@ -183,8 +182,7 @@ 
 
             case OutputPlugin::COLOUR_MODE_ON:
                 foreach ($this->outputHandles as $index => $outputHandle) {
-                    switch ($index)
-                    {
+                    switch ($index) {
                         case 'stdout':
                         case 'stderr':
                             $this->outputHandles[$index]['colour'] = true;

Doc Comments +6 added lines

@@ -128,6 +128,9 @@ 
         ];
     }
 
+    /**
+     * @param string $filename
+     */
     public function addOutputToFile($filename)
     {
         // can we open the file?
@@ -169,6 +172,9 @@ 
     //
     // ------------------------------------------------------------------
 
+    /**
+     * @param integer $mode
+     */
     public function setColourMode($mode)
     {
         switch ($mode)

src/php/DataSift/Storyplayer/Phases/ActionPhase.php

Braces +1 added lines, -2 removed lines

@@ -73,8 +73,7 @@
         $phaseResult = $this->getNewPhaseResult();
 
         // do we have anything to do?
-        if (!$story->hasActions())
-        {
+        if (!$story->hasActions()) {
             $phaseResult->setContinuePlaying(
                 $phaseResult::HASNOACTIONS,
                 "story has no action instructions"

Spacing +1 added lines, -1 removed lines

@@ -89,7 +89,7 @@
             $callbacks = $story->getAction();
             foreach ($callbacks as $action) {
                 if (is_callable($action)) {
-                    call_user_func($action,$st);
+                    call_user_func($action, $st);
                 }
             }
 

src/php/DataSift/Storyplayer/Phases/Phase.php

Braces +2 added lines, -4 removed lines

@@ -113,8 +113,7 @@ 
         $story = $st->getStory();
 
         // do we have anything to do?
-        if (!$story->hasPerPhaseSetup())
-        {
+        if (!$story->hasPerPhaseSetup()) {
             return;
         }
 
@@ -136,8 +135,7 @@ 
         $story = $st->getStory();
 
         // do we have anything to do?
-        if ($story->hasPerPhaseTeardown())
-        {
+        if ($story->hasPerPhaseTeardown()) {
             // get the callback to call
             $callbacks = $story->getPerPhaseTeardown();