datasift / storyplayer

src/php/Prose/UsingFacebookGraphApi.php

Spacing +5 added lines, -5 removed lines

@@ -71,7 +71,7 @@ 
     {
         // what are we doing?
         $log = usingLog()->startAction("get posts from facebook for page {$id} via graph api");
-        $returnedData = $this->makeGraphApiRequest("/".$id."/posts");
+        $returnedData = $this->makeGraphApiRequest("/" . $id . "/posts");
         $log->endAction("got posts for page {$id}");
 
         return $returnedData;
@@ -86,7 +86,7 @@ 
      *
      * @return array First post from a page
      */
-    public function getLatestPostFromPage($id){
+    public function getLatestPostFromPage($id) {
         $posts = $this->getPostsFromPage($id);
         return reset($posts);
     }
@@ -105,14 +105,14 @@ 
         $access_token = fromConfig()->getModuleSetting('facebook.access_token');
 
         // GET $path/?access_token=$access_token
-        $resp = fromCurl()->get($this->base_path.$path.'?access_token='. $access_token);
+        $resp = fromCurl()->get($this->base_path . $path . '?access_token=' . $access_token);
 
         // Make sure it's well formed
         $log = usingLog()->startAction("make sure we have the 'data' key in the response");
-        if (!isset($resp->data)){
+        if (!isset($resp->data)) {
 
             // if it was an access token error, remove it from the runtime config
-            if (isset($resp->error->message) && strpos($resp->error->message, "Error validating access token") !== false){
+            if (isset($resp->error->message) && strpos($resp->error->message, "Error validating access token") !== false) {
                 // Remove the access token from the runtime config
                 $config = $this->st->getRuntimeConfig();
                 unset($config->facebookAccessToken);

Braces +4 added lines, -3 removed lines

@@ -86,7 +86,8 @@ 
      *
      * @return array First post from a page
      */
-    public function getLatestPostFromPage($id){
+    public function getLatestPostFromPage($id)
+    {
         $posts = $this->getPostsFromPage($id);
         return reset($posts);
     }
@@ -109,10 +110,10 @@ 
 
         // Make sure it's well formed
         $log = usingLog()->startAction("make sure we have the 'data' key in the response");
-        if (!isset($resp->data)){
+        if (!isset($resp->data)) {
 
             // if it was an access token error, remove it from the runtime config
-            if (isset($resp->error->message) && strpos($resp->error->message, "Error validating access token") !== false){
+            if (isset($resp->error->message) && strpos($resp->error->message, "Error validating access token") !== false) {
                 // Remove the access token from the runtime config
                 $config = $this->st->getRuntimeConfig();
                 unset($config->facebookAccessToken);

src/php/Prose/UsingHttp.php

Spacing +2 added lines, -2 removed lines

@@ -88,7 +88,7 @@ 
         }
 
         // what are we doing?
-        $logMsg = [ "HTTP " . strtoupper($verb) . " '${url}'" ];
+        $logMsg = ["HTTP " . strtoupper($verb) . " '${url}'"];
         if ($body != null) {
             $logMsg[] = $body;
         }
@@ -112,7 +112,7 @@ 
             foreach ($body as $key => $value) {
                 $request->addData($key, $value);
             }
-        }else{
+        } else {
             $request->setPayload($body);
         }
 

Braces +2 added lines, -1 removed lines

@@ -112,7 +112,8 @@
             foreach ($body as $key => $value) {
                 $request->addData($key, $value);
             }
-        }else{
+        }
+        else {
             $request->setPayload($body);
         }
 

src/php/Prose/UsingProvisioningDefinition.php

Spacing +4 added lines, -4 removed lines

@@ -67,7 +67,7 @@ 
         parent::__construct($st, $args);
 
         // $args[0] should be our provisioning block
-        if (!isset($args[0]) || ! $args[0] instanceof ProvisioningDefinition) {
+        if (!isset($args[0]) || !$args[0] instanceof ProvisioningDefinition) {
             throw new E5xx_ActionFailed(__METHOD__, "Param #0 must be a ProvisioningDefinition object");
         }
     }
@@ -111,7 +111,7 @@ 
         };
 
         // build our return object
-        $return = new DelayedProvisioningDefinitionAction (
+        $return = new DelayedProvisioningDefinitionAction(
             $this->args[0],
             $action
         );
@@ -144,7 +144,7 @@ 
         };
 
         // build our return object
-        $return = new DelayedProvisioningDefinitionAction (
+        $return = new DelayedProvisioningDefinitionAction(
             $this->args[0],
             $action
         );
@@ -173,7 +173,7 @@ 
         };
 
         // build our return object
-        $return = new DelayedProvisioningDefinitionAction (
+        $return = new DelayedProvisioningDefinitionAction(
             $this->args[0],
             $action
         );

src/php/Prose/UsingRedisConn.php

Braces +1 added lines, -2 removed lines

@@ -77,8 +77,7 @@
 
             return $return;
         }
-        catch (Exception $e)
-        {
+        catch (Exception $e) {
             throw new E5xx_ActionFailed(__METHOD__, $e->getMessage());
         }
     }

src/php/Prose/UsingRuntimeTable.php

Spacing +4 added lines, -4 removed lines

@@ -74,14 +74,14 @@ 
         $tables = $this->getAllTables();
 
         // make sure it exists
-        if (!isset($tables->$tableName)){
+        if (!isset($tables->$tableName)) {
             $log->addStep("{$tableName} does not exist in the runtime config. creating empty table", function() use ($tables, $tableName){
                 $tables->$tableName = new BaseObject();
             });
         }
 
         // make sure we don't have a duplicate entry
-        if (isset($tables->$tableName->$key)){
+        if (isset($tables->$tableName->$key)) {
             $msg = "Table already contains an entry for '{$key}'";
             $log->endAction($msg);
             throw new E5xx_ActionFailed(__METHOD__, $msg);
@@ -171,7 +171,7 @@ 
         $tables = $this->getAllTables();
 
         // make sure it exists
-        if (!isset($tables->$tableName)){
+        if (!isset($tables->$tableName)) {
             $tables->$tableName = new BaseObject();
         }
         if (!isset($tables->$tableName->$group)) {
@@ -179,7 +179,7 @@ 
         }
 
         // make sure we don't have a duplicate entry
-        if (isset($tables->$tableName->$group->$key)){
+        if (isset($tables->$tableName->$group->$key)) {
             $msg = "table already contains an entry for '{$group}->{$key}'";
             $log->endAction($msg);
             throw new E5xx_ActionFailed(__METHOD__, $msg);

Braces +7 added lines, -7 removed lines

@@ -74,14 +74,14 @@ 
         $tables = $this->getAllTables();
 
         // make sure it exists
-        if (!isset($tables->$tableName)){
-            $log->addStep("{$tableName} does not exist in the runtime config. creating empty table", function() use ($tables, $tableName){
+        if (!isset($tables->$tableName)) {
+            $log->addStep("{$tableName} does not exist in the runtime config. creating empty table", function() use ($tables, $tableName) {
                 $tables->$tableName = new BaseObject();
             });
         }
 
         // make sure we don't have a duplicate entry
-        if (isset($tables->$tableName->$key)){
+        if (isset($tables->$tableName->$key)) {
             $msg = "Table already contains an entry for '{$key}'";
             $log->endAction($msg);
             throw new E5xx_ActionFailed(__METHOD__, $msg);
@@ -211,7 +211,7 @@ 
         $tables = $this->getAllTables();
 
         // make sure it exists
-        if (!isset($tables->$tableName)){
+        if (!isset($tables->$tableName)) {
             $tables->$tableName = new BaseObject();
         }
         if (!isset($tables->$tableName->$group)) {
@@ -219,7 +219,7 @@ 
         }
 
         // make sure we don't have a duplicate entry
-        if (isset($tables->$tableName->$group->$key)){
+        if (isset($tables->$tableName->$group->$key)) {
             $msg = "table already contains an entry for '{$group}->{$key}'";
             $log->endAction($msg);
             throw new E5xx_ActionFailed(__METHOD__, $msg);
@@ -285,7 +285,7 @@ 
 
         // remove the table if it's empty
         if (!count(get_object_vars($tables->$tableName->$group))) {
-            $log->addStep("table group '{$tableName}->{$group}' is empty, removing from runtime config", function() use ($tables, $tableName, $group){
+            $log->addStep("table group '{$tableName}->{$group}' is empty, removing from runtime config", function() use ($tables, $tableName, $group) {
                 unset($tables->$tableName->$group);
             });
         }
@@ -335,7 +335,7 @@ 
 
                 // remove the table if it's empty
                 if (!count(get_object_vars($tables->$tableName->$group))) {
-                    $log->addStep("table group '{$tableName}->{$group}' is empty, removing from runtime config", function() use ($tables, $tableName, $group){
+                    $log->addStep("table group '{$tableName}->{$group}' is empty, removing from runtime config", function() use ($tables, $tableName, $group) {
                         unset($tables->$tableName->$group);
                     });
                 }

src/php/Prose/UsingVagrant.php

Spacing +1 added lines, -1 removed lines

@@ -84,7 +84,7 @@
             "-o UserKnownHostsFile=/dev/null",
             "-o LogLevel=quiet",
         ];
-        $vmDetails->scpOptions  = [
+        $vmDetails->scpOptions = [
             "-i '" . $vmDetails->sshKeyFile . "'",
             "-o StrictHostKeyChecking=no",
         ];

Braces +1 added lines, -2 removed lines

@@ -115,8 +115,7 @@
             getenv("HOME") . "/.vagrant.d/insecure_private_key"
         ];
 
-        foreach ($keyFilenames as $keyFilename)
-        {
+        foreach ($keyFilenames as $keyFilename) {
             usingLog()->writeToLog("checking if {$keyFilename} exists");
             if (file_exists($keyFilename)) {
                 $log->endAction($keyFilename);

src/php/Prose/UsingZmq.php

Spacing +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
  */
 class UsingZmq extends Prose
 {
-    protected $socketMap = array (
+    protected $socketMap = array(
         ZMQ::SOCKET_PUB => "ZMQ::SOCKET_PUB",
         ZMQ::SOCKET_SUB => "ZMQ::SOCKET_SUB",
         ZMQ::SOCKET_REQ => "ZMQ::SOCKET_REQ",

src/php/Prose/UsingZmqSocket.php

Spacing +2 added lines, -2 removed lines

@@ -96,7 +96,7 @@ 
         // where are we unbinding from?
         $endpoints = fromZmqSocket($this->args[0])->getEndpoints();
 
-        foreach($endpoints['bind'] as $address) {
+        foreach ($endpoints['bind'] as $address) {
             usingLog()->writeToLog("unbinding from {$address}");
             $this->args[0]->unbind($address);
         }
@@ -156,7 +156,7 @@ 
         // where are we disconnecting from?
         $endpoints = fromZmqSocket($this->args[0])->getEndpoints();
 
-        foreach($endpoints['connect'] as $address) {
+        foreach ($endpoints['connect'] as $address) {
             usingLog()->writeToLog("disconnecting from {$address}");
             $this->args[0]->disconnect($address);
         }

src/php/Prose/UsingZookeeper.php

Spacing +3 added lines, -3 removed lines

@@ -62,7 +62,7 @@ 
     protected $host;
     protected $zk;
 
-    protected $default_acl = array( array(
+    protected $default_acl = array(array(
         "perms"  => Zookeeper::PERM_ALL,
         "scheme" => "world",
         "id"     => "anyone"
@@ -117,10 +117,10 @@ 
         }
 
         // drop the last part, as that is the key itself
-        unset($parts[count($parts) -1]);
+        unset($parts[count($parts) - 1]);
 
         // start with an empty path
-        $path  = '';
+        $path = '';
 
         // work through the parts, building up the path to create from
         // the root of the directory

Braces +5 added lines, -6 removed lines

@@ -124,16 +124,14 @@ 
 
         // work through the parts, building up the path to create from
         // the root of the directory
-        foreach ($parts as $part)
-        {
+        foreach ($parts as $part) {
             // expand our path to the next part
             $path .= '/' . $part;
 
             // does this path exist?
             if (!$this->zk->exists($path)) {
                 // no - create it
-                if (!$this->zk->create($path, 1, $this->default_acl))
-                {
+                if (!$this->zk->create($path, 1, $this->default_acl)) {
                     // failed to create the entry
                     throw Exceptions::newActionFailedException(__METHOD__);
                 }
@@ -151,8 +149,9 @@ 
 
         // now we can safely set the key itself
         if (!$this->zk->exists($key)) {
-            if (!$this->zk->create($key, $value, $this->default_acl))
-                throw Exceptions::newActionFailedException(__METHOD__);
+            if (!$this->zk->create($key, $value, $this->default_acl)) {
+                            throw Exceptions::newActionFailedException(__METHOD__);
+            }
         }
         else if (!$this->zk->set($key, $value)) {
             throw Exceptions::newActionFailedException(__METHOD__);