@@ -152,8 +152,8 @@ discard block |
||
152 | 152 | // build the full command |
153 | 153 | // |
154 | 154 | $fullCommand = 'cp ' |
155 | - . "'" . $sourceFilename . "' " |
|
156 | - . "'" . $destFilename . "'"; |
|
155 | + . "'" . $sourceFilename . "' " |
|
156 | + . "'" . $destFilename . "'"; |
|
157 | 157 | |
158 | 158 | // run the command |
159 | 159 | $commandRunner = $this->st->getNewCommandRunner(); |
@@ -182,8 +182,8 @@ discard block |
||
182 | 182 | // build the full command |
183 | 183 | // |
184 | 184 | $fullCommand = 'cp ' |
185 | - . "'" . $sourceFilename . "' " |
|
186 | - . "'" . $destFilename . "'"; |
|
185 | + . "'" . $sourceFilename . "' " |
|
186 | + . "'" . $destFilename . "'"; |
|
187 | 187 | |
188 | 188 | // run the command |
189 | 189 | $commandRunner = $this->st->getNewCommandRunner(); |
@@ -158,7 +158,7 @@ discard block |
||
158 | 158 | { |
159 | 159 | return [ |
160 | 160 | '-o StrictHostKeyChecking=no', // avoid prompting for accepting |
161 | - // a host key |
|
161 | + // a host key |
|
162 | 162 | ]; |
163 | 163 | } |
164 | 164 | |
@@ -166,9 +166,9 @@ discard block |
||
166 | 166 | { |
167 | 167 | return [ |
168 | 168 | '-o StrictHostKeyChecking=no', // avoid prompting for accepting |
169 | - // a host key |
|
169 | + // a host key |
|
170 | 170 | '-n' // attach stdin to /dev/null - req to run SSH when not |
171 | - // connected to a terminal |
|
171 | + // connected to a terminal |
|
172 | 172 | ]; |
173 | 173 | } |
174 | 174 | |
@@ -384,10 +384,10 @@ discard block |
||
384 | 384 | // the command to run on the remote/guest OS |
385 | 385 | // (assumes the command will be globbed by the remote shell) |
386 | 386 | $fullCommand = 'ssh ' |
387 | - . ' ' . $this->getSshKeyForUse() |
|
388 | - . ' ' . $this->getSshOptionsForUse() |
|
389 | - . ' ' . $this->getSshUsername() . '@' . $this->getIpAddress() |
|
390 | - . ' "' . str_replace('"', '\"', $command) . '"'; |
|
387 | + . ' ' . $this->getSshKeyForUse() |
|
388 | + . ' ' . $this->getSshOptionsForUse() |
|
389 | + . ' ' . $this->getSshUsername() . '@' . $this->getIpAddress() |
|
390 | + . ' "' . str_replace('"', '\"', $command) . '"'; |
|
391 | 391 | |
392 | 392 | // run the command |
393 | 393 | //$log->startStep("run command via SSH: {$fullCommand}"); |
@@ -435,11 +435,11 @@ discard block |
||
435 | 435 | // <additional SSH options> |
436 | 436 | // any other flags, such as -n to force non-interactive session |
437 | 437 | $fullCommand = 'scp ' |
438 | - . ' ' . $this->getSshKeyForUse() |
|
439 | - . ' ' . $this->getScpOptionsForUse() |
|
440 | - . ' "' . $this->getSshUsername() . '@' . $this->getIpAddress() |
|
441 | - . ':' . $sourceFilename . '"' |
|
442 | - . ' "' . $destFilename . '"'; |
|
438 | + . ' ' . $this->getSshKeyForUse() |
|
439 | + . ' ' . $this->getScpOptionsForUse() |
|
440 | + . ' "' . $this->getSshUsername() . '@' . $this->getIpAddress() |
|
441 | + . ':' . $sourceFilename . '"' |
|
442 | + . ' "' . $destFilename . '"'; |
|
443 | 443 | |
444 | 444 | // run the command |
445 | 445 | $commandRunner = $this->st->getNewCommandRunner(); |
@@ -486,11 +486,11 @@ discard block |
||
486 | 486 | // <additional SSH options> |
487 | 487 | // any other flags, such as -n to force non-interactive session |
488 | 488 | $fullCommand = 'scp ' |
489 | - . ' ' . $this->getSshKeyForUse() |
|
490 | - . ' ' . $this->getScpOptionsForUse() |
|
491 | - . ' "' . $sourceFilename . '" ' |
|
492 | - . ' "' . $this->getSshUsername() . '@' . $this->getIpAddress() |
|
493 | - . ':' . $destFilename . '"'; |
|
489 | + . ' ' . $this->getSshKeyForUse() |
|
490 | + . ' ' . $this->getScpOptionsForUse() |
|
491 | + . ' "' . $sourceFilename . '" ' |
|
492 | + . ' "' . $this->getSshUsername() . '@' . $this->getIpAddress() |
|
493 | + . ':' . $destFilename . '"'; |
|
494 | 494 | |
495 | 495 | // run the command |
496 | 496 | $commandRunner = $this->st->getNewCommandRunner(); |
@@ -61,11 +61,11 @@ |
||
61 | 61 | public function __construct() |
62 | 62 | { |
63 | 63 | parent::__construct( |
64 | - 'DataSift\Storyplayer\DeviceLib\DeviceConfig', |
|
65 | - [ |
|
66 | - "storyplayer/devices", |
|
67 | - ".storyplayer/devices", |
|
68 | - ] |
|
64 | + 'DataSift\Storyplayer\DeviceLib\DeviceConfig', |
|
65 | + [ |
|
66 | + "storyplayer/devices", |
|
67 | + ".storyplayer/devices", |
|
68 | + ] |
|
69 | 69 | ); |
70 | 70 | } |
71 | 71 | } |
@@ -55,10 +55,10 @@ discard block |
||
55 | 55 | */ |
56 | 56 | class HardCodedList |
57 | 57 | { |
58 | - /** |
|
59 | - * our list of configs |
|
60 | - * @var array<object> |
|
61 | - */ |
|
58 | + /** |
|
59 | + * our list of configs |
|
60 | + * @var array<object> |
|
61 | + */ |
|
62 | 62 | private $configs = []; |
63 | 63 | |
64 | 64 | /** |
@@ -76,7 +76,7 @@ discard block |
||
76 | 76 | */ |
77 | 77 | public function __construct($configType) |
78 | 78 | { |
79 | - $this->setConfigType($configType); |
|
79 | + $this->setConfigType($configType); |
|
80 | 80 | } |
81 | 81 | |
82 | 82 | /** |
@@ -86,7 +86,7 @@ discard block |
||
86 | 86 | */ |
87 | 87 | public function getConfigType() |
88 | 88 | { |
89 | - return $this->configType; |
|
89 | + return $this->configType; |
|
90 | 90 | } |
91 | 91 | |
92 | 92 | /** |
@@ -99,11 +99,11 @@ discard block |
||
99 | 99 | */ |
100 | 100 | public function setConfigType($configType) |
101 | 101 | { |
102 | - if (!class_exists($configType)) { |
|
103 | - throw new E4xx_NoSuchConfigClass($configType); |
|
104 | - } |
|
102 | + if (!class_exists($configType)) { |
|
103 | + throw new E4xx_NoSuchConfigClass($configType); |
|
104 | + } |
|
105 | 105 | |
106 | - $this->configType = $configType; |
|
106 | + $this->configType = $configType; |
|
107 | 107 | } |
108 | 108 | |
109 | 109 | /** |
@@ -118,15 +118,15 @@ discard block |
||
118 | 118 | */ |
119 | 119 | public function newConfig($name) |
120 | 120 | { |
121 | - // create our return object |
|
122 | - $classname = $this->configType; |
|
123 | - $obj = new $classname(); |
|
124 | - $obj->setName($name); |
|
121 | + // create our return object |
|
122 | + $classname = $this->configType; |
|
123 | + $obj = new $classname(); |
|
124 | + $obj->setName($name); |
|
125 | 125 | |
126 | - // add this to the list |
|
127 | - $this->addConfig($obj); |
|
126 | + // add this to the list |
|
127 | + $this->addConfig($obj); |
|
128 | 128 | |
129 | - return $obj; |
|
129 | + return $obj; |
|
130 | 130 | } |
131 | 131 | |
132 | 132 | /** |
@@ -137,13 +137,13 @@ discard block |
||
137 | 137 | */ |
138 | 138 | public function addConfig($config) |
139 | 139 | { |
140 | - // make sure the config is compatible first |
|
141 | - if (! $config instanceof $this->configType) { |
|
142 | - throw new E4xx_IncompatibleConfigClass($this->configType, get_class($config)); |
|
143 | - } |
|
140 | + // make sure the config is compatible first |
|
141 | + if (! $config instanceof $this->configType) { |
|
142 | + throw new E4xx_IncompatibleConfigClass($this->configType, get_class($config)); |
|
143 | + } |
|
144 | 144 | |
145 | - // if we get here, then we're good to go |
|
146 | - $name = $config->getName(); |
|
145 | + // if we get here, then we're good to go |
|
146 | + $name = $config->getName(); |
|
147 | 147 | $this->configs[$name] = $config; |
148 | 148 | |
149 | 149 | // keep the list sorted |
@@ -138,7 +138,7 @@ |
||
138 | 138 | public function addConfig($config) |
139 | 139 | { |
140 | 140 | // make sure the config is compatible first |
141 | - if (! $config instanceof $this->configType) { |
|
141 | + if (!$config instanceof $this->configType) { |
|
142 | 142 | throw new E4xx_IncompatibleConfigClass($this->configType, get_class($config)); |
143 | 143 | } |
144 | 144 |
@@ -82,7 +82,7 @@ |
||
82 | 82 | throw new E4xx_StoryplayerDefaultsSectionMustBeAnArray($this->getFilename()); |
83 | 83 | } |
84 | 84 | |
85 | - foreach($config->defaults as $defaultValue) { |
|
85 | + foreach ($config->defaults as $defaultValue) { |
|
86 | 86 | if (!is_string($defaultValue)) { |
87 | 87 | throw new E4xx_StoryplayerDefaultsMustBeStrings($this->getFilename()); |
88 | 88 | } |
@@ -61,11 +61,11 @@ |
||
61 | 61 | public function __construct() |
62 | 62 | { |
63 | 63 | parent::__construct( |
64 | - 'DataSift\Storyplayer\SystemsUnderTestLib\SystemUnderTestConfig', |
|
65 | - [ |
|
66 | - "storyplayer/systems-under-test", |
|
67 | - ".storyplayer/systems-under-test", |
|
68 | - ] |
|
64 | + 'DataSift\Storyplayer\SystemsUnderTestLib\SystemUnderTestConfig', |
|
65 | + [ |
|
66 | + "storyplayer/systems-under-test", |
|
67 | + ".storyplayer/systems-under-test", |
|
68 | + ] |
|
69 | 69 | ); |
70 | 70 | } |
71 | 71 | } |
@@ -58,11 +58,11 @@ |
||
58 | 58 | public function __construct($searchFolder = '.storyplayer/test-environments') |
59 | 59 | { |
60 | 60 | parent::__construct( |
61 | - 'DataSift\Storyplayer\TestEnvironmentsLib\TestEnvironmentConfig', |
|
62 | - [ |
|
63 | - "storyplayer/test-environments", |
|
64 | - ".storyplayer/test-environments" |
|
65 | - ] |
|
61 | + 'DataSift\Storyplayer\TestEnvironmentsLib\TestEnvironmentConfig', |
|
62 | + [ |
|
63 | + "storyplayer/test-environments", |
|
64 | + ".storyplayer/test-environments" |
|
65 | + ] |
|
66 | 66 | ); |
67 | 67 | } |
68 | 68 | } |
@@ -422,8 +422,8 @@ |
||
422 | 422 | if ($trace !== null) { |
423 | 423 | $this->write(PHP_EOL . "-----" . PHP_EOL, $this->writer->commentStyle); |
424 | 424 | $this->write("This is the stack trace for this failure:" |
425 | - . PHP_EOL . PHP_EOL |
|
426 | - . CodeFormatter::indentBySpaces($trace, 4) . PHP_EOL . PHP_EOL); |
|
425 | + . PHP_EOL . PHP_EOL |
|
426 | + . CodeFormatter::indentBySpaces($trace, 4) . PHP_EOL . PHP_EOL); |
|
427 | 427 | } |
428 | 428 | |
429 | 429 | // all done |
@@ -92,6 +92,7 @@ |
||
92 | 92 | /** |
93 | 93 | * called when Storyplayer exits |
94 | 94 | * |
95 | + * @param boolean $summary |
|
95 | 96 | * @return void |
96 | 97 | */ |
97 | 98 | public function writeFinalReport($duration, $summary) |
@@ -112,11 +112,9 @@ discard block |
||
112 | 112 | |
113 | 113 | // this is our opportunity to tell the user how our story(ies) |
114 | 114 | // went in detail |
115 | - foreach ($this->results as $result) |
|
116 | - { |
|
115 | + foreach ($this->results as $result) { |
|
117 | 116 | // so what happened? |
118 | - switch ($result->resultCode) |
|
119 | - { |
|
117 | + switch ($result->resultCode) { |
|
120 | 118 | case PhaseGroup_Result::OKAY: |
121 | 119 | // this is a good result |
122 | 120 | $succeededGroups[] = $result; |
@@ -303,8 +301,7 @@ discard block |
||
303 | 301 | |
304 | 302 | // does the phase have an exception? |
305 | 303 | $e = $phaseResult->getException(); |
306 | - if ($e) |
|
307 | - { |
|
304 | + if ($e) { |
|
308 | 305 | $stackTrace = $e->getTrace(); |
309 | 306 | $trace = $e->getTraceAsString(); |
310 | 307 | } |
@@ -270,8 +270,8 @@ |
||
270 | 270 | public function logCliErrorWithException($msg, $e) |
271 | 271 | { |
272 | 272 | $this->write("*** error: $msg" . PHP_EOL . PHP_EOL |
273 | - . "This was caused by an unexpected exception " . get_class($e) . PHP_EOL . PHP_EOL |
|
274 | - . $e->getTraceAsString() . PHP_EOL); |
|
273 | + . "This was caused by an unexpected exception " . get_class($e) . PHP_EOL . PHP_EOL |
|
274 | + . $e->getTraceAsString() . PHP_EOL); |
|
275 | 275 | } |
276 | 276 | |
277 | 277 | /** |
@@ -60,7 +60,7 @@ discard block |
||
60 | 60 | */ |
61 | 61 | class DevModeConsole extends Console |
62 | 62 | { |
63 | - protected $resultStrings = array(); |
|
63 | + protected $resultStrings = array(); |
|
64 | 64 | |
65 | 65 | public function __construct() |
66 | 66 | { |
@@ -124,7 +124,7 @@ discard block |
||
124 | 124 | //$this->write('-------------------------------------------------------------' . PHP_EOL, $this->writer->commentStyle); |
125 | 125 | $this->write('----' . PHP_EOL, $this->writer->commentStyle); |
126 | 126 | $this->write("Result: "); |
127 | - if ($result->getPhaseGroupSucceeded()){ |
|
127 | + if ($result->getPhaseGroupSucceeded()) { |
|
128 | 128 | $this->write($resultString, $this->writer->successStyle); |
129 | 129 | } |
130 | 130 | else if ($result->getPhaseGroupFailed()) { |
@@ -124,7 +124,7 @@ |
||
124 | 124 | //$this->write('-------------------------------------------------------------' . PHP_EOL, $this->writer->commentStyle); |
125 | 125 | $this->write('----' . PHP_EOL, $this->writer->commentStyle); |
126 | 126 | $this->write("Result: "); |
127 | - if ($result->getPhaseGroupSucceeded()){ |
|
127 | + if ($result->getPhaseGroupSucceeded()) { |
|
128 | 128 | $this->write($resultString, $this->writer->successStyle); |
129 | 129 | } |
130 | 130 | else if ($result->getPhaseGroupFailed()) { |