datasift /
storyplayer
| Conditions | 11 |
| Paths | 50 |
| Total Lines | 104 |
| Code Lines | 53 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 67 | public function doPhase($story) |
||
| 68 | { |
||
| 69 | // shorthand |
||
| 70 | $st = $this->st; |
||
| 71 | $storyResult = $story->getResult(); |
||
| 72 | |||
| 73 | // keep track of what happens with the action |
||
| 74 | $phaseResult = $this->getNewPhaseResult(); |
||
| 75 | |||
| 76 | // do we have anything to do? |
||
| 77 | if (!$story->hasTestCanRunCheck()) |
||
| 78 | { |
||
| 79 | $phaseResult->setContinuePlaying( |
||
| 80 | $phaseResult::COMPLETED, |
||
| 81 | "story can always run" |
||
| 82 | ); |
||
| 83 | return $phaseResult; |
||
| 84 | } |
||
| 85 | |||
| 86 | // get the callback to call |
||
| 87 | $callbacks = $story->getTestCanRunCheck(); |
||
| 88 | |||
| 89 | // make the call |
||
| 90 | try { |
||
| 91 | foreach ($callbacks as $callback) { |
||
| 92 | $canRun = call_user_func($callback, $st); |
||
| 93 | |||
| 94 | // what did the callback tell us? |
||
| 95 | // |
||
| 96 | // we treat TWO results as valid reports that the test |
||
| 97 | // should be skipped: |
||
| 98 | // |
||
| 99 | // 1: FALSE |
||
| 100 | // 2: an error message to write to the outputs |
||
| 101 | // |
||
| 102 | // ANYTHING else is treated as permission to continue |
||
| 103 | // and potentially run the rest of the story |
||
| 104 | if ($canRun === false || is_string($canRun)) { |
||
| 105 | $msg = "test reported that it cannot run"; |
||
| 106 | if (is_string($canRun)) { |
||
| 107 | $msg = $canRun; |
||
| 108 | } |
||
| 109 | $phaseResult->setSkipPlaying( |
||
| 110 | $phaseResult::CANNOTRUN, |
||
| 111 | $msg |
||
| 112 | ); |
||
| 113 | $storyResult->setStoryHasBeenSkipped($phaseResult); |
||
| 114 | return $phaseResult; |
||
| 115 | } |
||
| 116 | } |
||
| 117 | |||
| 118 | // if we get here, then all is well |
||
| 119 | $phaseResult->setContinuePlaying(); |
||
| 120 | } |
||
| 121 | // if an action fails, we treat that as a fault, and mark the |
||
| 122 | // story as failed |
||
| 123 | catch (ActionFailedException $e) { |
||
|
|
|||
| 124 | $phaseResult->setPlayingFailed( |
||
| 125 | $phaseResult::FAILED, |
||
| 126 | $e->getMessage(), |
||
| 127 | $e |
||
| 128 | ); |
||
| 129 | $storyResult->setStoryHasFailed($phaseResult); |
||
| 130 | } |
||
| 131 | // if an expect fails, we treat that as meaning that the story |
||
| 132 | // cannot run |
||
| 133 | catch (ExpectFailedException $e) { |
||
| 134 | $phaseResult->setSkipPlaying( |
||
| 135 | $phaseResult::CANNOTRUN, |
||
| 136 | $e->getMessage(), |
||
| 137 | $e |
||
| 138 | ); |
||
| 139 | $storyResult->setStoryHasBeenSkipped($phaseResult); |
||
| 140 | } |
||
| 141 | // if any of the modules used are incomplete, deal with that too |
||
| 142 | catch (NotImplementedException $e) { |
||
| 143 | $phaseResult->setPlayingFailed( |
||
| 144 | $phaseResult::INCOMPLETE, |
||
| 145 | $e->getMessage(), |
||
| 146 | $e |
||
| 147 | ); |
||
| 148 | $storyResult->setStoryIsIncomplete($phaseResult); |
||
| 149 | } |
||
| 150 | catch (StoryCannotRunException $e) { |
||
| 151 | $phaseResult->setSkipPlaying( |
||
| 152 | $phaseResult::CANNOTRUN, |
||
| 153 | $e->getMessage() |
||
| 154 | ); |
||
| 155 | $storyResult->setStoryHasBeenSkipped($phaseResult); |
||
| 156 | } |
||
| 157 | catch (Exception $e) |
||
| 158 | { |
||
| 159 | // something went wrong ... the test cannot continue |
||
| 160 | $phaseResult->setPlayingFailed( |
||
| 161 | $phaseResult::ERROR, |
||
| 162 | $e->getMessage(), |
||
| 163 | $e |
||
| 164 | ); |
||
| 165 | $storyResult->setStoryHasFailed($phaseResult); |
||
| 166 | } |
||
| 167 | |||
| 168 | // all done |
||
| 169 | return $phaseResult; |
||
| 170 | } |
||
| 171 | } |
||
| 172 |
Loading history...
Scrutinizer analyzes your
composer.json/composer.lockfile if available to determine the classes, and functions that are defined by your dependencies.It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis.