Issues in CrossTable.php (main) - Issues in main - datapp/tableau-cross-table - Measure and Improve Code Quality continuously with Scrutinizer

Issues (5)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/CrossTable.php (1 issue)

Labels

Bug 1

Severity

Critical 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace Datapp\TableauExport;

use Datapp\TableauExport\Sorter\SorterInterface;
use Datapp\TableauExport\Sorter\NullSorter;
use Datapp\TableauExport\CrossTableException;
use Generator;

class CrossTable
{

    const MEASURE_NAMES = 'Measure Names';
    const MEASURE_VALUES = 'Measure Values';

    private array $cache = [];

    private SorterInterface $sorter;

    /**
     * @param SorterInterface $sorter
     */
    public function __construct(SorterInterface $sorter = null)
    {
        $this->sorter = $sorter ?? new NullSorter();
    }

    /**
     * @param string $fileName
     * @return Generator<int, array <string, string>, mixed, void>
     * @throws CrossTableException
     */
    public function fromFile(string $fileName): Generator
    {
        $lineGenerator = $this->readLineByLine($fileName);
        if (!$lineGenerator->valid()) {
            throw CrossTableException::errorParsingCsvLine();
        }
        /** @var array <int, string> */
        $headers = $lineGenerator->current();
        $idColums = $this->getIdColums($headers, [self::MEASURE_NAMES, self::MEASURE_VALUES]);
        $lineGenerator->next();

        while ($lineGenerator->valid()) {
            /** @var array <int, string> */
            $line = $lineGenerator->current();
            $data = array_combine($headers, $line);
            if ($data === false) {
                throw CrossTableException::errorParsingCsvLine();
            }

            if (!$this->hasSameValuesInIdColumsAsRowBefore($data, $idColums, $this->cache)) {
                if (count($this->cache) > 0) {
                    yield $this->sorter->sort($this->cache);
                }
                $this->cache = $data;
                unset($this->cache[self::MEASURE_NAMES]);
                unset($this->cache[self::MEASURE_VALUES]);
            }
            $this->cache[(string) $data[self::MEASURE_NAMES]] = (string) $data[self::MEASURE_VALUES];
            $lineGenerator->next();
        }
        // don't forget last line
        yield $this->sorter->sort($this->cache);
    }

    /**
     * @param string $fileName
     * @return \Generator<int, array <int, string>, mixed, void>
     * @throws CrossTableException
     */
    private function readLineByLine(string $fileName): \Generator
    {
        if (!is_readable($fileName)) {
            throw CrossTableException::fileNotFoundOrNotReadable($fileName);
        }
        $fileHandle = fopen($fileName, 'r');
        if ($fileHandle === false) {
            // @codeCoverageIgnoreStart
            throw CrossTableException::fileNotFoundOrNotReadable($fileName);
            // @codeCoverageIgnoreEnd
        }
        while ($row = fgetcsv($fileHandle, 0, ';')) {
            yield $row;
        }
    }

    /**
     * @param array<int, string> $headers
     * @param array<int, string> $measureColums
     * @return array<int, string>
     * @throws CrossTableException
     */
    private function getIdColums(array $headers, array $measureColums): array
    {
        $idColums = array_diff($headers, $measureColums);
        if (count($idColums) + 2 !== count($headers)) {
            throw CrossTableException::errorParsingCsvLine();
        }
        return $idColums;
    }

    /**
     * @param array<string, string> $row
     * @param array<int, string> $idCols
     * @param array<string, string> $cache
     * @return bool
     */
    private function hasSameValuesInIdColumsAsRowBefore(array $row, array $idCols, array $cache): bool
    {
        // first line?
        if (count($cache) === 0) {
            return false;
        }
        // compare values in the id columns
        /** @var string $id */
        foreach ($idCols as $id) {
            if ($cache[$id] !== $row[$id]) {
                return false;
            }
        }
        return true;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Datapp\TableauExport;
6
7		use Datapp\TableauExport\Sorter\SorterInterface;
8		use Datapp\TableauExport\Sorter\NullSorter;
9		use Datapp\TableauExport\CrossTableException;
10		use Generator;
11
12		class CrossTable
13		{
14
15		const MEASURE_NAMES = 'Measure Names';
16		const MEASURE_VALUES = 'Measure Values';
17
18		private array $cache = [];
		0 ignored issues – show Bug introduced 2021-01-05 08:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_ARRAY, expecting T_FUNCTION or T_CONST Loading history...
19		private SorterInterface $sorter;
20
21		/**
22		* @param SorterInterface $sorter
23		*/
24	5	public function __construct(SorterInterface $sorter = null)
25		{
26	5	$this->sorter = $sorter ?? new NullSorter();
27	5	}
28
29		/**
30		* @param string $fileName
31		* @return Generator<int, array <string, string>, mixed, void>
32		* @throws CrossTableException
33		*/
34	5	public function fromFile(string $fileName): Generator
35		{
36	5	$lineGenerator = $this->readLineByLine($fileName);
37	5	if (!$lineGenerator->valid()) {
38		throw CrossTableException::errorParsingCsvLine();
39		}
40		/** @var array <int, string> */
41	4	$headers = $lineGenerator->current();
42	4	$idColums = $this->getIdColums($headers, [self::MEASURE_NAMES, self::MEASURE_VALUES]);
43	4	$lineGenerator->next();
44
45	4	while ($lineGenerator->valid()) {
46		/** @var array <int, string> */
47	4	$line = $lineGenerator->current();
48	4	$data = array_combine($headers, $line);
49	4	if ($data === false) {
50	1	throw CrossTableException::errorParsingCsvLine();
51		}
52
53	3	if (!$this->hasSameValuesInIdColumsAsRowBefore($data, $idColums, $this->cache)) {
54	3	if (count($this->cache) > 0) {
55	3	yield $this->sorter->sort($this->cache);
56		}
57	3	$this->cache = $data;
58	3	unset($this->cache[self::MEASURE_NAMES]);
59	3	unset($this->cache[self::MEASURE_VALUES]);
60		}
61	3	$this->cache[(string) $data[self::MEASURE_NAMES]] = (string) $data[self::MEASURE_VALUES];
62	3	$lineGenerator->next();
63		}
64		// don't forget last line
65	3	yield $this->sorter->sort($this->cache);
66	3	}
67
68		/**
69		* @param string $fileName
70		* @return \Generator<int, array <int, string>, mixed, void>
71		* @throws CrossTableException
72		*/
73	5	private function readLineByLine(string $fileName): \Generator
74		{
75	5	if (!is_readable($fileName)) {
76	1	throw CrossTableException::fileNotFoundOrNotReadable($fileName);
77		}
78	4	$fileHandle = fopen($fileName, 'r');
79	4	if ($fileHandle === false) {
80		// @codeCoverageIgnoreStart
81		throw CrossTableException::fileNotFoundOrNotReadable($fileName);
82		// @codeCoverageIgnoreEnd
83		}
84	4	while ($row = fgetcsv($fileHandle, 0, ';')) {
85	4	yield $row;
86		}
87	3	}
88
89		/**
90		* @param array<int, string> $headers
91		* @param array<int, string> $measureColums
92		* @return array<int, string>
93		* @throws CrossTableException
94		*/
95	4	private function getIdColums(array $headers, array $measureColums): array
96		{
97	4	$idColums = array_diff($headers, $measureColums);
98	4	if (count($idColums) + 2 !== count($headers)) {
99		throw CrossTableException::errorParsingCsvLine();
100		}
101	4	return $idColums;
102		}
103
104		/**
105		* @param array<string, string> $row
106		* @param array<int, string> $idCols
107		* @param array<string, string> $cache
108		* @return bool
109		*/
110	3	private function hasSameValuesInIdColumsAsRowBefore(array $row, array $idCols, array $cache): bool
111		{
112		// first line?
113	3	if (count($cache) === 0) {
114	3	return false;
115		}
116		// compare values in the id columns
117		/** @var string $id */
118	3	foreach ($idCols as $id) {
119	3	if ($cache[$id] !== $row[$id]) {
120	3	return false;
121		}
122		}
123	3	return true;
124		}
125		}
126

datapp / tableau-cross-table

Issues (5)

Security Analysis no request data

src/CrossTable.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like